[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282108#comment-16282108 ] ASF GitHub Bot commented on JENA-1430: -- Github user afs commented on the issue: h

[GitHub] jena issue #314: JENA-1430

2017-12-07 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/314 `ja:data` isn't mentioned in `DatasetAssembler` except to redirect to TIM. Which two different kinds of dataset? Would you like to move `public static final Property data = property( "data" );`

Re: [GitHub] jena pull request #314: JENA-1430

2017-12-07 Thread Andy Seaborne
Claude - it isn't subclassed. Some tests are of assemblers themselves reading real, normal RDF data files because that is what the assembler is supplied to do. It isn't a case of putting in a jar. Andy On 07/12/17 15:25, Claude Warren wrote: Q: What about when the tests are used by su

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282066#comment-16282066 ] ASF GitHub Bot commented on JENA-1430: -- Github user ajs6f commented on the issue:

[GitHub] jena issue #314: JENA-1430

2017-12-07 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/314 I'm saying that `ja:data` is now used for loading quads into two different kinds of datasets, but loading triples into only one. That's confusing at best. I want to make it clearer by getting rid of the

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282038#comment-16282038 ] ASF GitHub Bot commented on JENA-1430: -- Github user afs commented on the issue: h

[GitHub] jena issue #314: JENA-1430

2017-12-07 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/314 @ajs6f I do not understand your point - it is to abstract talking about "predicates". Some examples maybe? How do you deprecate in Turtle assembler files? `ja:graph` isn't unused by TIM.

[jira] [Commented] (JENA-1445) Add more error checking for the memory/general assemblers.

2017-12-07 Thread A. Soroka (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282008#comment-16282008 ] A. Soroka commented on JENA-1445: - I'd like to make the predicate semantics clearer as part

Re: [GitHub] jena pull request #314: JENA-1430

2017-12-07 Thread Claude Warren
Q: What about when the tests are used by subclasses in a different package. The test files would then need to be loaded from the class path. I ran into this issue trying to run tests on graph implementations before. However, it my not apply in this specific case with assemblers. So I am asking,

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281988#comment-16281988 ] ASF GitHub Bot commented on JENA-1430: -- Github user ajs6f commented on the issue:

[GitHub] jena issue #314: JENA-1430

2017-12-07 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/314 Ouch! I realize I wasn't clear enough at all in my last comment: I was actually -1 on this. I think the confusion that `ja:data` now has in its semantics is too much, and I completely disagree with:

[jira] [Issue Comment Deleted] (JENA-1445) Add more error checking for the memory/general assemblers.

2017-12-07 Thread wei liu (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wei liu updated JENA-1445: -- Comment: was deleted (was: {panel:title=My Title|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1|bgColo

[jira] [Comment Edited] (JENA-1445) Add more error checking for the memory/general assemblers.

2017-12-07 Thread wei liu (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281960#comment-16281960 ] wei liu edited comment on JENA-1445 at 12/7/17 2:59 PM: *strong* *

[jira] [Issue Comment Deleted] (JENA-1445) Add more error checking for the memory/general assemblers.

2017-12-07 Thread wei liu (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wei liu updated JENA-1445: -- Comment: was deleted (was: *strong* *adsfdasf*) > Add more error checking for the memory/general assemblers. >

[jira] [Commented] (JENA-1445) Add more error checking for the memory/general assemblers.

2017-12-07 Thread wei liu (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281960#comment-16281960 ] wei liu commented on JENA-1445: --- {color:red language=sql title=code} select * from table1

[jira] [Commented] (JENA-1445) Add more error checking for the memory/general assemblers.

2017-12-07 Thread wei liu (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281957#comment-16281957 ] wei liu commented on JENA-1445: --- {panel:title=My Title|borderStyle=dashed|borderColor=#ccc|t

[jira] [Created] (JENA-1445) Add more error checking for the memory/general assemblers.

2017-12-07 Thread Andy Seaborne (JIRA)
Andy Seaborne created JENA-1445: --- Summary: Add more error checking for the memory/general assemblers. Key: JENA-1445 URL: https://issues.apache.org/jira/browse/JENA-1445 Project: Apache Jena Is

[jira] [Resolved] (JENA-1430) Quad loading for in-memory assemblers

2017-12-07 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Seaborne resolved JENA-1430. - Resolution: Fixed Fix Version/s: Jena 3.6.0 > Quad loading for in-memory assemblers > --

[jira] [Commented] (JENA-1340) Regression: Problem with using riot on csv->rdf with Jena 3.3.0 (tested that works on 3.1.1)

2017-12-07 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281916#comment-16281916 ] Andy Seaborne commented on JENA-1340: - (Typo - the last comment in fact about to JENA-1

[jira] [Commented] (JENA-1340) Regression: Problem with using riot on csv->rdf with Jena 3.3.0 (tested that works on 3.1.1)

2017-12-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281912#comment-16281912 ] ASF subversion and git services commented on JENA-1340: --- Commit 74cbc

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-12-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281911#comment-16281911 ] ASF subversion and git services commented on JENA-1430: --- Commit 3e13d

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-12-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281910#comment-16281910 ] ASF subversion and git services commented on JENA-1430: --- Commit d174e

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281914#comment-16281914 ] ASF GitHub Bot commented on JENA-1430: -- Github user asfgit closed the pull request at:

[GitHub] jena pull request #314: JENA-1430

2017-12-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/314 ---

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281905#comment-16281905 ] ASF GitHub Bot commented on JENA-1430: -- Github user afs commented on the issue: h

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281904#comment-16281904 ] ASF GitHub Bot commented on JENA-1430: -- Github user afs commented on a diff in the pul

[GitHub] jena issue #314: JENA-1430

2017-12-07 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/314 Merged in order to progress Jena 3.6.0. ---

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281903#comment-16281903 ] ASF GitHub Bot commented on JENA-1430: -- Github user afs commented on a diff in the pul

[GitHub] jena pull request #314: JENA-1430

2017-12-07 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r155532650 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/DatasetAssemblerVocab.java --- @@ -31,7 +31,7 @@ // General dataset publi

[GitHub] jena pull request #314: JENA-1430

2017-12-07 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r155532515 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/DatasetAssembler.java --- @@ -26,25 +30,29 @@ import org.apache.jena.atlas.logging.Log

[jira] [Closed] (JENA-1444) ASK queries return inconsistent results when contain blank nodes

2017-12-07 Thread Fabian Polkosnik (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Polkosnik closed JENA-1444. -- Resolution: Not A Bug > ASK queries return inconsistent results when contain blank nodes > --