[jira] [Commented] (JENA-1556) text:query multilingual enhancements

2018-06-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518605#comment-16518605 ] ASF GitHub Bot commented on JENA-1556: -- Github user xristy commented on the issue:

[GitHub] jena issue #436: JENA-1556 implementation

2018-06-20 Thread xristy
Github user xristy commented on the issue: https://github.com/apache/jena/pull/436 Thanks everyone. I seemed to have finally merged PR#436. I ended up using @rvesse plus a bit from the commit workflow (which I agree should be linked on the Contributing page): > git

[GitHub] jena pull request #436: JENA-1556 implementation

2018-06-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/436 ---

[jira] [Commented] (JENA-1556) text:query multilingual enhancements

2018-06-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518591#comment-16518591 ] ASF GitHub Bot commented on JENA-1556: -- Github user asfgit closed the pull request at:

Re: Commit workflow

2018-06-20 Thread ajs6f
As for gitbox, the last result of my investigation was that we won't _currently_ have the same JIRA integrations that we now have, because INFRA hasn't done that yet. (And they would love to have some help doing that!) I left the matter there. For my money, we might do well to revisit the JIRA

Re: Commit workflow

2018-06-20 Thread Aaron Coburn
Thanks Andy, this is very helpful. Best, Aaron > On Jun 20, 2018, at 6:02 AM, Andy Seaborne wrote: > > Aaron, Chris, all, > > One thing to mention - with the master repo on Apache hardware and PRs on the > mirror (which we don't have write access to) there is a workflow for merging > into

[jira] [Commented] (JENA-1556) text:query multilingual enhancements

2018-06-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518005#comment-16518005 ] ASF GitHub Bot commented on JENA-1556: -- Github user kinow commented on the issue:

[GitHub] jena issue #436: JENA-1556 implementation

2018-06-20 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/436 The docs look really good! Only feedback I have: * It's possible to avoid the empty commit, by amending the last commit adding "this closes #123". That's what I normally do when I work in other

Commit workflow

2018-06-20 Thread Andy Seaborne
Aaron, Chris, all, One thing to mention - with the master repo on Apache hardware and PRs on the mirror (which we don't have write access to) there is a workflow for merging into the Apache github repo: https://cwiki.apache.org/confluence/display/JENA/Commit+Workflow+for+Github-ASF Andy

RE: CMS diff: TDB Datasets

2018-06-20 Thread Greg Albiston
Hi Andy, Thanks for the response. Your suggestion worked and the query completed in a similar time to the union graph approach. I'd tried moving the filter into the graph clause but not swapping the graph order. I added that update on the documentation so if anyone else was having similar

[jira] [Commented] (JENA-1556) text:query multilingual enhancements

2018-06-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517984#comment-16517984 ] ASF GitHub Bot commented on JENA-1556: -- Github user afs commented on the issue:

[GitHub] jena issue #436: JENA-1556 implementation

2018-06-20 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/436 I have a copy of Jena cloned from git-wip-us.apache.org = a added second remote for github (this is so it is called as "github", not the full URL "https://github.com/apache/jena.git;). To merge,

[jira] [Commented] (JENA-1556) text:query multilingual enhancements

2018-06-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517973#comment-16517973 ] ASF GitHub Bot commented on JENA-1556: -- Github user afs commented on the issue:

[GitHub] jena issue #436: JENA-1556 implementation

2018-06-20 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/436 Committer workflow: https://cwiki.apache.org/confluence/display/JENA/Commit+Workflow+for+Github-ASF ---

[jira] [Commented] (JENA-1556) text:query multilingual enhancements

2018-06-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517938#comment-16517938 ] ASF GitHub Bot commented on JENA-1556: -- Github user rvesse commented on the issue:

[GitHub] jena issue #436: JENA-1556 implementation

2018-06-20 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/436 @xristy I think you can just merge as you would normally though you probably need to be explicit about the remote and branch you are using for remote operations: ``` > git checkout master