[GitHub] [jena] strangepleasures commented on a change in pull request #637: JENA-1784 CacheSimple doesn't check keys for equality

2019-11-26 Thread GitBox
strangepleasures commented on a change in pull request #637: JENA-1784 CacheSimple doesn't check keys for equality URL: https://github.com/apache/jena/pull/637#discussion_r350975531 ## File path: jena-base/src/test/java/org/apache/jena/atlas/lib/cache/CacheSimpleTest.java

[GitHub] [jena] ajs6f commented on a change in pull request #637: JENA-1784 CacheSimple doesn't check keys for equality

2019-11-26 Thread GitBox
ajs6f commented on a change in pull request #637: JENA-1784 CacheSimple doesn't check keys for equality URL: https://github.com/apache/jena/pull/637#discussion_r350973044 ## File path: jena-base/src/test/java/org/apache/jena/atlas/lib/cache/CacheSimpleTest.java ## @@ -40,

[GitHub] [jena] strangepleasures commented on issue #637: JENA-1784 CacheSimple doesn't check keys for equality

2019-11-26 Thread GitBox
strangepleasures commented on issue #637: JENA-1784 CacheSimple doesn't check keys for equality URL: https://github.com/apache/jena/pull/637#issuecomment-558809225 Agree. Thank you for your suggestion. This is an automated me

[jira] [Assigned] (JENA-1784) CacheSimple doesn't check keys for equality

2019-11-26 Thread Andy Seaborne (Jira)
[ https://issues.apache.org/jira/browse/JENA-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Seaborne reassigned JENA-1784: --- Assignee: Andy Seaborne > CacheSimple doesn't check keys for equality >

[GitHub] [jena] afs commented on issue #637: JENA-1784 CacheSimple doesn't check keys for equality

2019-11-26 Thread GitBox
afs commented on issue #637: JENA-1784 CacheSimple doesn't check keys for equality URL: https://github.com/apache/jena/pull/637#issuecomment-558737355 Thank you - I agree with the fix. Writing the test is harder! :-) Rather than rely on the interesting fact that `hash("Aa") ==

[jira] [Commented] (JENA-1783) Clean up use of Class.newInstance

2019-11-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/JENA-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982682#comment-16982682 ] ASF subversion and git services commented on JENA-1783: --- Commit f5c9

[jira] [Commented] (JENA-1783) Clean up use of Class.newInstance

2019-11-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/JENA-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982683#comment-16982683 ] ASF subversion and git services commented on JENA-1783: --- Commit 0f98

[jira] [Resolved] (JENA-1783) Clean up use of Class.newInstance

2019-11-26 Thread Andy Seaborne (Jira)
[ https://issues.apache.org/jira/browse/JENA-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Seaborne resolved JENA-1783. - Fix Version/s: Jena 3.14.0 Resolution: Fixed > Clean up use of Class.newInstance > ---

[GitHub] [jena] afs merged pull request #636: JENA-1783: Replace use of Class.newInstance

2019-11-26 Thread GitBox
afs merged pull request #636: JENA-1783: Replace use of Class.newInstance URL: https://github.com/apache/jena/pull/636 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [jena] strangepleasures opened a new pull request #637: JENA-1784 CacheSimple doesn't check keys for equality

2019-11-26 Thread GitBox
strangepleasures opened a new pull request #637: JENA-1784 CacheSimple doesn't check keys for equality URL: https://github.com/apache/jena/pull/637 Added an explicit check for keys' equality This is an automated message from

[jira] [Created] (JENA-1784) CacheSimple doesn't check keys for equality

2019-11-26 Thread Pavel Mikhailovskii (Jira)
Pavel Mikhailovskii created JENA-1784: - Summary: CacheSimple doesn't check keys for equality Key: JENA-1784 URL: https://issues.apache.org/jira/browse/JENA-1784 Project: Apache Jena Issu