[GitHub] jena issue #490: JENA-1635 Fix invalid Automatic-Module-Name values

Github user acoburn commented on the issue: https://github.com/apache/jena/pull/490 @afs feel free to pull this into #486. I used `fuseki2` because that's what was used [here](https://github.com/apache/jena/blob/master/jena-fuseki2/pom.xml#L57), but I'd also prefer just `fuseki

[GitHub] jena pull request #490: JENA-1635 Fix invalid Automatic-Module-Name values

GitHub user acoburn opened a pull request: https://github.com/apache/jena/pull/490 JENA-1635 Fix invalid Automatic-Module-Name values The jena-fuseki-access, jena-fuseki-core and jena-fuseki-main modules have invalid data for Automatic-Module-Name. This aligns the data

[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

Github user acoburn commented on the issue: https://github.com/apache/jena/pull/474 It is possibly worth noting here that these changes also make it possible to build Jena on JDK 11. ---

[GitHub] jena pull request #467: JENA-1599: Upgrade to jsonld-java 0.12.1

GitHub user acoburn opened a pull request: https://github.com/apache/jena/pull/467 JENA-1599: Upgrade to jsonld-java 0.12.1 This upgrades jsonld-java to the latest version. That version does not require an extra import of Guava in an OSGi environment (Guava is shaded in jsonld

[GitHub] jena issue #428: Update OSGi imports

Github user acoburn commented on the issue: https://github.com/apache/jena/pull/428 FYI, I have submitted a related PR to `jsonld-java`: https://github.com/jsonld-java/jsonld-java/pull/234 Once that change makes it into a `jsonld-java` release, it should be possible

[GitHub] jena pull request #428: Update OSGi imports

Github user acoburn commented on a diff in the pull request: https://github.com/apache/jena/pull/428#discussion_r194126560 --- Diff: apache-jena-osgi/jena-osgi-features/src/main/resources/features.xml --- @@ -21,28 +21,24 @@ mvn:org.apache.jena/jena-osgi

[GitHub] jena issue #428: Update OSGi imports

Github user acoburn commented on the issue: https://github.com/apache/jena/pull/428 I built Jena with your change in #429 along with the changes from this PR, and for some reason the `jena-osgi` module still wants to import the `com.google.errorprone.annotations

[GitHub] jena issue #428: Update OSGi imports

Github user acoburn commented on the issue: https://github.com/apache/jena/pull/428 Explicitly marking the dependency as optional might work. If that doesn't work, the import declaration in `jena-osgi` for `com.google.errorprone.annotations` is in the same category

[GitHub] jena issue #428: Update OSGi imports

Github user acoburn commented on the issue: https://github.com/apache/jena/pull/428 I am definitely no expert on shaded jars. The above comment was based on running `mvn dependency:tree` and seeing these compile-scoped dependencies: ``` [INFO] +- org.apache.jena:jena

[GitHub] jena issue #428: Update OSGi imports

Github user acoburn commented on the issue: https://github.com/apache/jena/pull/428 I believe the Guava dependencies are brought in as part of the shading process. Those dependencies are not typically required for Guava itself (they are only test-scoped dependencies). So perhaps

[GitHub] jena pull request #428: Update OSGi imports

GitHub user acoburn opened a pull request: https://github.com/apache/jena/pull/428 Update OSGi imports Resolves: JENA-1557 This adds an exclusion for `org.checkerframework.checker.*`, which is now pulled in by `jena-shaded-guava`. This also adds guava (jsonld-java depends

[GitHub] jena issue #411: Include TDB2 in the jena-osgi module

Github user acoburn commented on the issue: https://github.com/apache/jena/pull/411 This deploys just fine in Karaf. ---

[GitHub] jena issue #411: Include TDB2 in the jena-osgi module

Github user acoburn commented on the issue: https://github.com/apache/jena/pull/411 After adding the `tdb2` dependency as in this PR, the `jena-osgi` bundle includes the `org.apache.jena.dboe.*` classes. For example: ```bash $ bnd print ./target/jena-osgi-3.8.0

[GitHub] jena pull request #411: Include TDB2 in the jena-osgi module

GitHub user acoburn opened a pull request: https://github.com/apache/jena/pull/411 Include TDB2 in the jena-osgi module Resolves https://issues.apache.org/jira/browse/JENA-1538 This adds the TDB2 packages to the jena-osgi artifact. You can merge this pull request

[GitHub] jena pull request #386: JENA-1508 Update OSGi provisioning features

GitHub user acoburn opened a pull request: https://github.com/apache/jena/pull/386 JENA-1508 Update OSGi provisioning features This marks the `com.google.errorprone.annotations.concurrent` package as optional. It also adds the (currently missing) `commons-codec` dependency

[GitHub] jena issue #210: Fixing JENA-1283 by using Maven properties to control versi...

Github user acoburn commented on the issue: https://github.com/apache/jena/pull/210 I was able to install this successfully in a Karaf 4.x container. 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] jena issue #194: JENA-1263: Recommended redirect behavior

Github user acoburn commented on the issue: https://github.com/apache/jena/pull/194 I can confirm that this patch solves the issue related to 303 redirects, outlined in JENA-1263. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] jena issue #139: JSON-LD output

Github user acoburn commented on the issue: https://github.com/apache/jena/pull/139 While this isn't exactly a review, I would add that what @fpservant has implemented here is _exactly_ what I need for some projects I work on -- projects that make heavy use of Jena, but when it comes