kinow commented on a change in pull request #9:
URL: https://github.com/apache/jena-site/pull/9#discussion_r419040132



##########
File path: source/documentation/fuseki2/fuseki-configuration.md
##########
@@ -124,9 +124,71 @@ An in-memory dataset, with data in the default graph taken 
from a local file.
         ## tdb:unionDefaultGraph true ;
          .
 
+#### TDB2
+
+    <#dataset> rdf:type      tdb:DatasetTDB2 ;
+        tdb:location "/some/path" ;
+        # this can also have unionDefaultGraph, etc.

Review comment:
       Maybe use the same example above from TDB? Copying that part with the 
timeout (quite sure it's the same syntax, there's another example in [the 
docs](https://jena.apache.org/documentation/fuseki2/fuseki-config-endpoint.html)).
   
   Same for `unionDefaultGraph`. Maybe just leave it commented out.

##########
File path: source/documentation/fuseki2/fuseki-configuration.md
##########
@@ -124,9 +124,71 @@ An in-memory dataset, with data in the default graph taken 
from a local file.
         ## tdb:unionDefaultGraph true ;
          .
 
+#### TDB2
+
+    <#dataset> rdf:type      tdb:DatasetTDB2 ;
+        tdb:location "/some/path" ;
+        # this can also have unionDefaultGraph, etc.
+         .
+
 #### Inference
 
-> @@
+An inference reasoner can be layered on top of a dataset as defined above. The 
type of reasoner must be selected carefully and should not include more 
reasoning than is required by the application, as extensive reasoning can be 
detrimental to performance.
+
+You have to build up layers of dataset, inference model, and graph.
+
+    <#dataset> rdf:type ja:RDFDataset;
+         ja:defaultGraph <#inferenceModel>
+         .
+         
+    <#inferenceModel> rdf:type      ja:InfModel;
+         ja:reasoner [ ja:reasonerURL <http://example/someReasonerURLHere> ];

Review comment:
       Maybe make a reference somewhere in the docs that this one here, is one 
of the values from the reasoners listed in the next section?

##########
File path: source/documentation/fuseki2/fuseki-configuration.md
##########
@@ -124,9 +124,71 @@ An in-memory dataset, with data in the default graph taken 
from a local file.
         ## tdb:unionDefaultGraph true ;
          .
 
+#### TDB2
+
+    <#dataset> rdf:type      tdb:DatasetTDB2 ;
+        tdb:location "/some/path" ;
+        # this can also have unionDefaultGraph, etc.
+         .
+
 #### Inference
 
-> @@
+An inference reasoner can be layered on top of a dataset as defined above. The 
type of reasoner must be selected carefully and should not include more 
reasoning than is required by the application, as extensive reasoning can be 
detrimental to performance.
+
+You have to build up layers of dataset, inference model, and graph.
+
+    <#dataset> rdf:type ja:RDFDataset;
+         ja:defaultGraph <#inferenceModel>
+         .
+         
+    <#inferenceModel> rdf:type      ja:InfModel;
+         ja:reasoner [ ja:reasonerURL <http://example/someReasonerURLHere> ];
+         ja:baseModel <#baseModel>;
+         .
+    <#baseModel> rdf:type tdb:GraphTDB2;  # for example.
+         tdb2:location "/some/path/to/store/data/to";
+         # etc
+         .
+
+
+##### Possible reasoners:
+
+* **Generic Rule Reasoner**: `http://jena.hpl.hp.com/2003/GenericRuleReasoner`
+  
+  The specific rule set and mode configuration can be set either be method 
calls to the created reasoner or though parameters in the configuration Model.

Review comment:
       "can be set either be method"... by method?
   
   "or though"... or through? (not a native speaker, so take it with a grain of 
salt)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to