[GitHub] grahamtriggs commented on issue #533: Feature/sdborder

2019-02-20 Thread GitBox
grahamtriggs commented on issue #533: Feature/sdborder URL: https://github.com/apache/jena/pull/533#issuecomment-465710002 @afs Ooops! I've added the Apache header to both of those files. This is an automated message from the

[GitHub] grahamtriggs commented on issue #533: Feature/sdborder

2019-02-19 Thread GitBox
grahamtriggs commented on issue #533: Feature/sdborder URL: https://github.com/apache/jena/pull/533#issuecomment-465351735 @afs Hi - I've added some basic tests: 1) There is a test to check that scopes added to the ScopeBase are returned in the correct order 2) There is a

[GitHub] grahamtriggs commented on issue #533: Feature/sdborder

2019-02-15 Thread GitBox
grahamtriggs commented on issue #533: Feature/sdborder URL: https://github.com/apache/jena/pull/533#issuecomment-464205740 Functionally, the LinkedHastSet (order of Scope), and DISTINCT / GROUP BY translation are tested multiple times during the existing tests - the code is exercised and