[GitHub] jena issue #153: JENA-1090: Txn - a java8-centric transaction API

2016-07-12 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/153 Merged but this code always benefits from ongoing code review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] jena issue #153: JENA-1090: Txn - a java8-centric transaction API

2016-07-11 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/153 Okay, so the appropriateness of `finally` depends on where you are (app vs. system code). Makes sense. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] jena issue #153: JENA-1090: Txn - a java8-centric transaction API

2016-07-11 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/153 If one of the transaction operations throws anything then the system is broken. It should not happen and would indicate an unrepairable error condition (e.g. NPE, broken journal). After that,

[GitHub] jena issue #153: JENA-1090: Txn - a java8-centric transaction API

2016-07-10 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/153 We usually use `try-finally` for the transaction cycle, i.e. ``` try { transactionalThing.begin(readWrite); //do some stuff transactionalThing.commit(); // if a write

[GitHub] jena issue #153: JENA-1090: Txn - a java8-centric transaction API

2016-07-09 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/153 There is markdown documentation to go with this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature