[GitHub] jena issue #159: JENA-1210: Call model.read

2016-07-24 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/159 This makes sense-- one question: currently `RdfDataMgr.read(Model m, etc)` falls through to `RdfDataMgr.read(m.getGraph(), etc)`. Should it be changed to call `Model.read`? --- If your project is set u

[GitHub] jena issue #159: JENA-1210: Call model.read

2016-07-24 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/159 That will go in circles! Plain `model.read` goes to `RDFReaderRIOT` (The old RDFReader interface adapter to RIOT) which makes all calls go to `RDFDataMgr.read(model,...)`. If that calls `model.read` we hav

[GitHub] jena issue #159: JENA-1210: Call model.read

2016-07-24 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/159 Okay, cool, in that case maybe we can put a couple of comments into `RdfDataMgr` to indicate that it can only ever do the "vanilla" stuff, and that if you expect action associated with a particular type

[GitHub] jena issue #159: JENA-1210: Call model.read

2016-07-25 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/159 There's a comment in `AdapterFileManager.readModelWorker` about override of `Model.read`. `RDFDataMgr` does say at the top "Read data from a location into a Model/Dataset etc" so it's not promisin

[GitHub] jena issue #159: JENA-1210: Call model.read

2016-07-25 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/159 Sure, but unless you object, I don't think it can hurt to be even more specific, with some brief phrases like "The methods in this class treat all types of Model in the same way. For behavior specific to

[GitHub] jena issue #159: JENA-1210: Call model.read

2016-07-25 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/159 No problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu