[GitHub] jena issue #246: Generic text analyzers

Github user osma commented on the issue: https://github.com/apache/jena/pull/246 Thanks for the contribution! I think this will take a while to digest. I'm currently on a business trip to California and don't have time to look at this very closely, but I will do so when I hav

[GitHub] jena issue #246: Generic text analyzers

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/246 I second what @osma said and I would add that there is a possible further learning challenge with this new functionality in that the two selections for test indexing, Lucene and ElasticSearch, would (aft

[GitHub] jena issue #246: Generic text analyzers

Github user xristy commented on the issue: https://github.com/apache/jena/pull/246 @osma I'm happy to give some background. We are developing a multilingual cultural heritage system to handle in particular Tibetan, Pali, and Sanskrit which are not handled currently among the various L

[GitHub] jena issue #246: Generic text analyzers

Github user osma commented on the issue: https://github.com/apache/jena/pull/246 @xristy Thanks for the excellent explanation about the background for this PR! As you said, this came a bit out of nowhere and it would perhaps had been easier to get oriented if you had proposed it a bit

[GitHub] jena issue #246: Generic text analyzers

Github user afs commented on the issue: https://github.com/apache/jena/pull/246 Hopefully, putting in 3.4.0 will not be too long - one reason the project wants to have a more frequent release cycles is so that new features can come in with less wait. --- If your project is set up f

[GitHub] jena issue #246: Generic text analyzers

Github user xristy commented on the issue: https://github.com/apache/jena/pull/246 I understand that there's a lot on the plate for 3.3.0 now and it makes sense to wait until after the code and docs have settled regarding [PR # 245](https://github.com/apache/jena/pull/245). I will add

[GitHub] jena issue #246: Generic text analyzers

Github user xristy commented on the issue: https://github.com/apache/jena/pull/246 I've made considerable updates to text-query.mdtext which are attached. I hope these updates are moving in a useful direction. [text-query.mdtext.zip](https://github.com/apache/jena/files/10623

[GitHub] jena issue #246: Generic text analyzers

Github user xristy commented on the issue: https://github.com/apache/jena/pull/246 I've resolved the conflict in TextVocab.java and add further updates to the text-querty.mdtext a couple of weeks ago. What are the next steps that I need to take to get this PR accepted? --- If your p

[GitHub] jena issue #246: Generic text analyzers

Github user osma commented on the issue: https://github.com/apache/jena/pull/246 I read through the text-query.mdtext @xristy attached on 8 June and it looks really excellent! All the features are still there, but the overall story is now much clearer. --- If your project is set up

[GitHub] jena issue #246: Generic text analyzers

Github user osma commented on the issue: https://github.com/apache/jena/pull/246 The new features introduced by this PR seem useful and worthwhile, and the implementation looks solid. This clearly doesn't conflict with existing code. However, there is some overlap in function

[GitHub] jena issue #246: Generic text analyzers

Github user xristy commented on the issue: https://github.com/apache/jena/pull/246 I've added `JenaSystem.init()` to the jena-text tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] jena issue #246: Generic text analyzers

Github user afs commented on the issue: https://github.com/apache/jena/pull/246 @xristy - Thank you very much. Now merged into Jena master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] jena issue #246: Generic text analyzers

Github user xristy commented on the issue: https://github.com/apache/jena/pull/246 @afs Thank you for your patience and help. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] jena issue #246: Generic text analyzers

Github user afs commented on the issue: https://github.com/apache/jena/pull/246 Documentation updated: http://jena.staging.apache.org/documentation/query/text-query.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as