[GitHub] jena issue #368: JENA-1495 Return Model from PrefixMapping methods.

2018-03-04 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/368 This seems like a useful change, but it is not back-compatible, so in theory we should hold it for a major version release. ---

[GitHub] jena issue #368: JENA-1495 Return Model from PrefixMapping methods.

2018-03-04 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/368 Urp, just realized that `Model extends PrefixMapping`, so this is fine wrt compatibility. Sorry for the confusion! ---

[GitHub] jena issue #368: JENA-1495 Return Model from PrefixMapping methods.

2018-03-05 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/368 This looks basically good to me: with an additional commit addressing https://github.com/apache/jena/pull/368#pullrequestreview-101006841, I'll be happy to merge this. ---

[GitHub] jena issue #368: JENA-1495 Return Model from PrefixMapping methods.

2018-03-09 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/368 Closing this PR. I see these commits in the codebase under different SHA1 ids (b8b482ecaa and 036ebce8ed). @jaco0646 - thanks! ---