[GitHub] jena issue #421: Escape @xerces.internal annotations

2018-05-12 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/421 Okay, either way works for me. This is already done, so easier! ---

[GitHub] jena issue #421: Escape @xerces.internal annotations

2018-05-12 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/421 The PR leaves the code as much as-is by escaping the annotation in a `{@literal ...}`. By making this reversible change, comparing to the original easier, if it is ever needed. We could remove it

[GitHub] jena issue #421: Escape @xerces.internal annotations

2018-05-12 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/421 I've never seen `@xerces.internal` before, but it seems to denote types internal to Xerces, right? My one question is: do we need to keep it on all types or can we stick it on a package comment? (Since