Github user osma commented on the pull request:
https://github.com/apache/jena/pull/101#issuecomment-158934853
I see, thanks for the clarification. But I think my question about what
kind of code we want is still valid - after all, this isn't my project, but
maintained collectively.
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/101#issuecomment-158935620
Sure, I was just responding to the question about commits. I agree that
code must be written in a style that supports maintenance over the long term.
I'd make two points
Github user osma commented on the pull request:
https://github.com/apache/jena/pull/101#issuecomment-158932591
Thanks @ajs6f - there's quite a lot of fixes in here!
In general, I feel positive about cleanups like this. And it's nice to have
a patch which actually *reduces*
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/101#issuecomment-158933847
Maybe there's confusion about what this PR is for-- I wasn't intending that
it would be merged, but that you would use it as a source of examples, like I
wrote. The
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/101#issuecomment-158938940
Just to be clear, I don't mean to argue that Jena's code is particularly
archaic, just that we should aim for balance between taking advantage of new
capabilities and
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/101#issuecomment-159004022
@osma makes a valid point - Java8 is still quite new and many (most?)
people are not going to see some of the new idioms as natural or easier, and
they can be slower.
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/101#issuecomment-159008507
Sure, @afs . It might be good to get some of this written down in the docs.
I'll happily close this PR and leave the one directly to @osma's clone in place
for him to do
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/101
A few suggestions for @osma
These are a few small suggestions for @osma for using Guava or Java 8
features to slightly tighen code in `jena-text`. They are far from exhaustive,
just meant to be
