[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function

GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/54 Deprecating Map1 in favor of Java8 Function Deprecating Map1 in favor of Java8 Function. I believe I have managed to avoid mangling any public contracts presented by Jena. You can merge this pu

[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function

Github user afs commented on the pull request: https://github.com/apache/jena/pull/54#issuecomment-98128625 Looks good but I'm having a problem with {{OntResourceImpl.AsMapper}}. This is removed in {{OntResourceImpl}] but still in use in {{OntClassImpl}}, {{EnumeratedClassImpl}}, {{B

[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function

Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/54#issuecomment-98128730 Hm. That does sound weird. I'll take a look and straighten it out. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function

Github user afs commented on the pull request: https://github.com/apache/jena/pull/54#issuecomment-98129164 Created JENA-929 to help track this long-term. Just mention JENA-929 in comments and the JIRA wil be updated automatically. --- If your project is set up for it, you can reply

[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function

Github user afs commented on the pull request: https://github.com/apache/jena/pull/54#issuecomment-98129528 Restoring {{AsMapper}} seemed to fix things - at least , it compiled then, just a bunch of warnings about use of {{Map1}} and unused {{java.util.Function}} imports so it does lo

[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function

Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/54#issuecomment-98129632 Yep-- Git weirdness. I think that should square it. I'm not mentioning the Jira issue here because Git mistakes don't seem like part of the long-term record. --- If your pro

[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function

Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/54#issuecomment-98129734 Right-- I just amended the commit to fully excise AsMapper. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function

Github user afs commented on the pull request: https://github.com/apache/jena/pull/54#issuecomment-98133080 Got it - it's clean now. I remove unused imports, replaced Statement.Util and some Triple statics by rewriting the few uses in place e.g. Statement::getSubject. --- If your p

[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function

Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/54 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function

Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/54#issuecomment-98133375 Thanks! P.S. Sorry about unused imports and the like. That was sloppy. --- If your project is set up for it, you can reply to this email and have your reply appear on