[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in jena-jdbc

2015-05-21 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-104236721 Re: private methods I turned on Eclipse's warn on unused private member which includes private methods, (it does not seem to separate the two). A quick scan

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in jena-jdbc

2015-05-21 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-104258333 Okay, that's cool. If you're confident that that stuff is real, only not currently interesting, then we need it. I would have removed it and retrieved it when wanted from

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in jena-jdbc

2015-05-20 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103971350 No problemo. Because it was a single commit, it was no harder than a `git reset` to before that commit and then some tap dancing between `git add`ing changes, committing

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in jena-jdbc

2015-05-20 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103970644 Thanks for the splitting. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this