[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-11-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15661290#comment-15661290 ] ASF subversion and git services commented on JENA-1233: --- Commit b237c

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-11-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15661288#comment-15661288 ] ASF subversion and git services commented on JENA-1233: --- Commit 69f50

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-11-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15661289#comment-15661289 ] ASF GitHub Bot commented on JENA-1233: -- Github user asfgit closed the pull request at:

Re: [jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-11-09 Thread Stian Soiland-Reyes
Wonder what a bit of winter air does.. I checked deeper - I think the code should be safe. The new Jena code doesn't make it's own ObjectInputStream and as your wrapper classes basically hijack the java.io.ObjectOutputStream and java.io.ObjectInputStream (given to Thrift as pure Input/OutputStream

Re: [jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-11-09 Thread Stian Soiland-Reyes
Just raising it as something to check.. I don't think your code looks particularly vulnerable, as the main job is done by Thrift. About "final" - good practice is to use 'final' unless a class is meant to be extended. As the S classes are just serialisation capsules I think this would be the case

Re: [jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-11-09 Thread Andy Seaborne
On 08/11/16 16:58, Stian Soiland-Reyes wrote: Looks like an OK solutions. Could the S classes be made "final"..? There are some security concerns with readObject() that can expose remote code execution, by for instance building a sorted collection with comparable objects, where one of those obje

Re: [jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-11-08 Thread Stian Soiland-Reyes
Looks like an OK solutions. Could the S classes be made "final"..? There are some security concerns with readObject() that can expose remote code execution, by for instance building a sorted collection with comparable objects, where one of those objects allow custom comparison code (e.g. a groovy

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15647325#comment-15647325 ] ASF GitHub Bot commented on JENA-1233: -- GitHub user afs opened a pull request: ht

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-11-06 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15642341#comment-15642341 ] Andy Seaborne commented on JENA-1233: - A plan: Java serialization has a mechanism to a

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-11-03 Thread Rob Vesse (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633396#comment-15633396 ] Rob Vesse commented on JENA-1233: - Ideally the {{Writable}} wrappers for those types in the

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-11-03 Thread A. Soroka (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632695#comment-15632695 ] A. Soroka commented on JENA-1233: - +1 to adding {{Serializable}} to those types. They are m

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-11-03 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15631927#comment-15631927 ] Andy Seaborne commented on JENA-1233: - Thank you for that. I propose that we add {{Ser

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-11-02 Thread Itsuki Toyota (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15631290#comment-15631290 ] Itsuki Toyota commented on JENA-1233: - I confirmed that your sample code works fine in

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-11-02 Thread Itsuki Toyota (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15629379#comment-15629379 ] Itsuki Toyota commented on JENA-1233: - Thanks for your neat explanation and sorry for m

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-11-02 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15629297#comment-15629297 ] Andy Seaborne commented on JENA-1233: - The output is correct - BEFORE and AFTER are wri

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-11-02 Thread Itsuki Toyota (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15629123#comment-15629123 ] Itsuki Toyota commented on JENA-1233: - Sorry to my late reply. I tested your sample pro

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-11-01 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626907#comment-15626907 ] Andy Seaborne commented on JENA-1233: - Did the serialization wrappers {{SNode}}, {{STri

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-09-08 Thread Itsuki Toyota (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15475305#comment-15475305 ] Itsuki Toyota commented on JENA-1233: - Thanks a lot! I'll try it later. > Make RDF pri

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-09-08 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15475019#comment-15475019 ] Andy Seaborne commented on JENA-1233: - Hmm - spark seems rather locked to default objec

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-09-08 Thread Itsuki Toyota (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15474351#comment-15474351 ] Itsuki Toyota commented on JENA-1233: - Thanks for your reply. > The other thing you ca

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-09-08 Thread Rob Vesse (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15474301#comment-15474301 ] Rob Vesse commented on JENA-1233: - Even if you use Elephas it won't work entirely out-of-th

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-09-08 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15474241#comment-15474241 ] Andy Seaborne commented on JENA-1233: - If serializable is provided, then it could use R

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-09-08 Thread Itsuki Toyota (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15474225#comment-15474225 ] Itsuki Toyota commented on JENA-1233: - > Triple, Node, Quad? Yes, I mean the these thre

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-09-08 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15474207#comment-15474207 ] Andy Seaborne commented on JENA-1233: - Blank nodes aren't a problem at this level ; jav

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-09-08 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15474204#comment-15474204 ] Andy Seaborne commented on JENA-1233: - So what's the complete list: Triple, Node, Quad

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-09-08 Thread Itsuki Toyota (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15474191#comment-15474191 ] Itsuki Toyota commented on JENA-1233: - > Which objects? The RDD-wrapped object what I i

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-09-08 Thread Paul Houle (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15474177#comment-15474177 ] Paul Houle commented on JENA-1233: -- In theory the identity of blank nodes between differen

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-09-08 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15474145#comment-15474145 ] Andy Seaborne commented on JENA-1233: - Which objects? Have you looked at jena-elephas?

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-09-08 Thread Itsuki Toyota (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15474132#comment-15474132 ] Itsuki Toyota commented on JENA-1233: - Thanks for your reply. So, you want to say that

[jira] [Commented] (JENA-1233) Make RDF primitives Serializable

2016-09-08 Thread A. Soroka (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15474040#comment-15474040 ] A. Soroka commented on JENA-1233: - I think there may be some subtleties here because of bla