Re: JSON-LD upgrade - impact on Elephas

2015-10-18 Thread Andy Seaborne
On 13/10/15 14:21, Rob Vesse wrote: If the counts are different purely because we are failing in a different (but predictable) way then I see no reason not to change them Rob Change made - the tests now ask what the expected answer are and the JSON-LD (triples, quads) tests return their own d

Re: JSON-LD upgrade - impact on Elephas

2015-10-13 Thread Rob Vesse
If the counts are different purely because we are failing in a different (but predictable) way then I see no reason not to change them Rob On 09/10/2015 16:42, "Andy Seaborne" wrote: >Rob - Would changing the count results be acceptable? > > Andy > >On 05/10/15 13:22, Andy Seaborne wrote:

Re: JSON-LD upgrade - impact on Elephas

2015-10-09 Thread Andy Seaborne
Rob - Would changing the count results be acceptable? Andy On 05/10/15 13:22, Andy Seaborne wrote: On 05/10/15 09:31, Rob Vesse wrote: Yes the tests are designed to be pragmatic If you are processing large amounts of data on Hadoop there are two cases: - You want to skip/ignore bad d

Re: JSON-LD upgrade - impact on Elephas

2015-10-05 Thread Andy Seaborne
On 05/10/15 09:31, Rob Vesse wrote: Yes the tests are designed to be pragmatic If you are processing large amounts of data on Hadoop there are two cases: - You want to skip/ignore bad data - You want to fail fast on bad data The failing tests are presumably the ones testing the second case.

Re: JSON-LD upgrade - impact on Elephas

2015-10-05 Thread Rob Vesse
Yes the tests are designed to be pragmatic If you are processing large amounts of data on Hadoop there are two cases: - You want to skip/ignore bad data - You want to fail fast on bad data The failing tests are presumably the ones testing the second case. My general hacky approach to testing th

Re: JSON-LD upgrade - impact on Elephas

2015-10-04 Thread Andy Seaborne
Claude, The point is more on the pragmatic side than the ideal design with a tradeoff between maintaining our own code vs using a maintained library. The jsonld-java parsing process isn't streaming in either use case so it's not a case of some triples read from the input. The jsonld-java pr

Re: JSON-LD upgrade - impact on Elephas

2015-10-04 Thread Claude Warren
not Rob but my 2 cents. I think that when we read turtle documents if there is an error the triples we have already read and left in the graph/model (yes, transactions can change this). Shouldn't all parsers follow the same pattern? Currently that pattern seems to be: read until eof or erro

JSON-LD upgrade - impact on Elephas

2015-10-03 Thread Andy Seaborne
Upgrading the dependency for jsonld-java to 0.7.0 picks up a bug fix (jsonld-java issue 144) that Jena has a workaround for. The issue is that the Jackson JSON parser does not flag trailing junk. It reads the JSON object and stops there. Worse, it creates a buffered reader so the caller can't