Re: A patch for TCP Sampler

2012-11-30 Thread Kurt Hong
Great thanks for your kind help:-) The reason why I was thinking of removing "Re-Use Connection" checkbox and so on from one of them is... In case checkboxes, If user utilizes TCP Sampler and TCP Sampler Config together, the settings on the TCP Sampler Config are meaningless. So now I'm think

Re: A patch for TCP Sampler

2012-11-30 Thread Philippe Mouawad
Hello, Thanks for proposal, see my answers below. Regards Philippe On Friday, November 30, 2012, Kurt Hong wrote: > Dear apache jmeter developers, > > I'm warring if these questions would make you feel like a burden as I'm > not familiar with open source committing process. I’m reading most of y

RE: A patch for TCP Sampler

2012-11-30 Thread Anthony Johnson
Hey Kurt, I have always attached my source diffs to a bug and then replied here with the bug number. One of the devs with commit rights will review, give feedback if needed, and merge if all is well. The normal gotcha is the documentation updates. Hope this helps, Anthony From: Kurt Hong Sent: 1

A patch for TCP Sampler

2012-11-30 Thread Kurt Hong
Dear apache jmeter developers, I'm warring if these questions would make you feel like a burden as I'm not familiar with open source committing process. I’m reading most of your documents though. If you advise several URL or document, that would be very helpful too. Questions, 1. Once I m