Usage of final methods in newly added report package

Hi all, I see a lot of methods in the newly added report package, that are declared final. What is the reasoning behind this? Regards, Felix

null checks and ArgumentNullException in report package

Hi all, in the new report package, there are a lot of null-checks of the sort if (foo == null) { throw new ArgumentNullException("foo"); } The ArgumentNullException is a new class from report.core. We could use Validate.notNull() from commons lang3 instead. It will throw an

[GitHub] jmeter pull request: Simplification and clarification of the test ...

Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Cleanup extras folder

Hi, Any feedback ? can I drop all the files I mentioned as droppable ? What about jmeter.fb ? Anybody knows what it's for ? Thanks On Saturday, December 12, 2015, Philippe Mouawad wrote: > Hello, > Looking at extras content I wonder if we should not cleanup some

Drop old behavioural properties

Hi, I propose to drop 2 old behavioural properties. The first one jmeterthread.reversePostProcessors Is very old, and if anybody still relies on it, he can just change the order of post processors. The second one: jmeterengine.startlistenerslater Was here in case StandardJMeterEngine

Re: Usage of final methods in newly added report package

Hi Felix, Do you have an example where it does not seem justified ? Thanks On Sunday, December 13, 2015, Felix Schumacher < felix.schumac...@internetallee.de> wrote: > Hi all, > > I see a lot of methods in the newly added report package, that are > declared final. > > What is the reasoning

Re: null checks and ArgumentNullException in report package

ok or use IllegalArgumentException. Regards On Sunday, December 13, 2015, Felix Schumacher < felix.schumac...@internetallee.de> wrote: > Hi all, > > in the new report package, there are a lot of null-checks of the sort > > if (foo == null) { > throw new ArgumentNullException("foo"); > } > >

[GitHub] jmeter pull request: Bug 58726 - Remove the jmeterthread.startearl...

Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/58 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Issues when upgrading from 3 to 4.2.6 or 4.5.1

Hi, I created https://issues.apache.org/jira/browse/HTTPCLIENT-1704 with JUnit test case so that you understand the difference we have. Regards On Sat, Dec 5, 2015 at 1:26 PM, Oleg Kalnichevski wrote: > On Fri, 2015-12-04 at 21:43 +0100, Philippe Mouawad wrote: > > Thanks

Re: Issues when upgrading from 3 to 4.2.6 or 4.5.1

Hi Oleg, Created https://issues.apache.org/jira/browse/HTTPCLIENT-1705 to show issue with Cookie Header ordering. Regards On Sun, Dec 13, 2015 at 9:30 PM, Philippe Mouawad < philippe.moua...@gmail.com> wrote: > Hi, > I created https://issues.apache.org/jira/browse/HTTPCLIENT-1704 with > JUnit

Re: Issues when upgrading from 3 to 4.2.6 or 4.5.1

Finally, for those 2 I am not sure as per RFC6265, to use them , put code in org.apache.http.client.protocol.TestResponseProcessCookies. They worked with HC3 but it does not mean they should work with HC4, but I would like a confirmation: @Test public void testParseCookies() throws

Re: Issues when upgrading from 3 to 4.2.6 or 4.5.1

Hi, Created https://issues.apache.org/jira/browse/HTTPCLIENT-1705 with a Test case in it to show issue with Domain starting with ".". Regards On Sun, Dec 13, 2015 at 9:50 PM, Philippe Mouawad < philippe.moua...@gmail.com> wrote: > Hi Oleg, > Created