[GitHub] jmeter pull request: Minimum height for TableEditor widget

GitHub user vherilier opened a pull request: https://github.com/apache/jmeter/pull/128 Minimum height for TableEditor widget BugzillaId #58870: Set a minimum height for TableEditor widget when the element screen, that contains a such widgget, has its size is reduced, not to reduce

[GitHub] jmeter pull request: Refactored addKeyData in AbstractGraphConsume...

GitHub user ham1 opened a pull request: https://github.com/apache/jmeter/pull/129 Refactored addKeyData in AbstractGraphConsumer and other minor formatting Mainly removing duplicate code and renaming things to make it easier to understand. You can merge this pull request into a Gi

[GitHub] jmeter pull request: Minimum height for TableEditor widget

Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] jmeter pull request: Removing unnecessary (un)boxing

Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/123 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] jmeter pull request: Removing duplicate code.

Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/126 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] jmeter pull request: Removing unnecessary modifiers

Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/122 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] jmeter pull request: Refactored addKeyData in AbstractGraphConsume...

Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/129#issuecomment-185728403 Hello, I think there is an issue with your refactoring of AbstractGraphConsumer. at lines 341 to 351, you have refactored the Map iteration but: 1) One contai

[GitHub] jmeter pull request: Refactored addKeyData in AbstractGraphConsume...

Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/129 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] jmeter pull request: Refactored addKeyData in AbstractGraphConsume...

Github user ham1 commented on the pull request: https://github.com/apache/jmeter/pull/129#issuecomment-185733398 @pmouawad Yes, you are correct. Good spot. I will try again and also try to keep formatting separate from changes - would 2 commits on the same PR be preferred or just 2 PR

[GitHub] jmeter pull request: Bug 59028 : use the SystemDefaultDnsResolver ...

GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/130 Bug 59028 : use the SystemDefaultDnsResolver singleton instead of a new one for each thread You can merge this pull request into a Git repository by running: $ git pull https://github.com/ben

[GitHub] jmeter pull request: Bug 59028 : use the SystemDefaultDnsResolver ...

Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/130 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

Re: svn commit: r1731062 - in /jmeter/trunk/src: core/org/apache/jmeter/gui/util/JMeterToolBar.java core/org/apache/jmeter/report/processor/graph/AbstractVersusRequestsGraphConsumer.java jorphan/org/a

On 18 February 2016 at 12:56, wrote: > Author: pmouawad > Date: Thu Feb 18 12:56:21 2016 > New Revision: 1731062 > > URL: http://svn.apache.org/viewvc?rev=1731062&view=rev > Log: > #resolve #123 That does not say why the changes were committed; please ensure that the commit message has sufficien

HTTPS broken by commit of https://bz.apache.org/bugzilla/show_bug.cgi?id=58099

Hello, I broke HTTPS in JMeter with commit 1730947. I will fix it in few minutes. But it is strange that no JUnit test caught this big issue. I will commit a Test Plan testing HTTPS and SNI. -- Regards. Philippe M.

[GitHub] jmeter pull request: Refactoring of HTTPSamplerBase

GitHub user ham1 opened a pull request: https://github.com/apache/jmeter/pull/131 Refactoring of HTTPSamplerBase Removal of unused method. Minor simplifications of some boolean expressions. Code formatting. Spelling. I've split the removal of the method and the f

Build failed in Jenkins: JMeter-trunk #4968

See Changes: [pmouawad] svn:eol [pmouawad] Add HTTPs test -- [...truncated 1229 lines...] [anakia] Output:

Re: HTTPS broken by commit of https://bz.apache.org/bugzilla/show_bug.cgi?id=58099

Hi, I added the tests and now issue is detected. I commited the fix to Bug 58099 fixing regression. But I think next test will still fail due to this in logs: WARN - jmeter.util.SSLManager: Keystore file not found, loading empty keystore What shall we do about that ? Regards Philippe On Fri, Fe

Build failed in Jenkins: JMeter-trunk #4969

See Changes: [pmouawad] Bug 58099 - Performance : Lazily initialize HttpClient SSL Context to avoid its initialization even for HTTP only scenarios Fix regression on HTTPS tests, No route to host... Bugzilla Id: 58099 ---

Build failed in Jenkins: JMeter-trunk #4970

See -- [...truncated 903 lines...] [anakia] Output: [anakia] Input: usermanual/listeners.xml [ana

buildbot failure in on jmeter-trunk

The Buildbot has detected a new failure on builder jmeter-trunk while building . Full details are available at: https://ci.apache.org/builders/jmeter-trunk/builds/636 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: The AnyBranchScheduler scheduler

buildbot success in on jmeter-trunk

The Buildbot has detected a restored build on builder jmeter-trunk while building . Full details are available at: https://ci.apache.org/builders/jmeter-trunk/builds/637 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: The AnyBranchScheduler schedu

Jenkins build is back to normal : JMeter-trunk #4971

See

Re: HTTPS broken by commit of https://bz.apache.org/bugzilla/show_bug.cgi?id=58099

Am 19. Februar 2016 00:47:04 MEZ, schrieb Philippe Mouawad : >Hi, >I added the tests and now issue is detected. >I commited the fix to Bug 58099 fixing regression. There is another bug open, to remove all references to apache.org. Could we start a local server with sni enabled ssl connector?