Re: [GitHub] jmeter pull request: java constants naming

Philippe>- LOG (Upper Case) for static is the usual policy that is applied by all Philippe> of us since few time In my opinion, log/logger is better treated as exception from "static final upper case" policy. It is used more often than other kind of static finals => it might deserve some excepti

Re: svn commit: r1735407 - in /jmeter/trunk: build.properties build.xml eclipse.classpath lib/ lib/aareadme.txt res/maven/ApacheJMeter_parent.pom xdocs/changes.xml

I see the maintenance issue now. The LICENSE file relies on the contents of licenses/bin to document 3rd party jars. As such, even jars under the AL need a file. It would be easier for the user - and probably easier to maintain - if the LICENSE file listed all the 3rd party jars by name and versi

[GitHub] jmeter pull request: Bug59190_BetterProxyExcludesSuggestedCaseSens...

Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/169 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

Re: Remaining Work before Release of 3.0

On Thu, Mar 17, 2016 at 6:10 PM, sebb wrote: > On 17 March 2016 at 16:59, Philippe Mouawad > wrote: > > Hi sebb, > > I have fixed 1/4 issues reported in 59173 and think other "issues" should > > be mentioned in changes and not fixed as I think some cannot be without > > important work without re

[GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Github user vlsi commented on a diff in the pull request: https://github.com/apache/jmeter/pull/167#discussion_r56465359 --- Diff: src/core/org/apache/jmeter/services/FileServer.java --- @@ -418,16 +418,20 @@ private BufferedReader getReader(String alias, boolean recycle, boolean f

Re: svn commit: r1735575 - in /jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser: NotReusableParser.java ReusableParser.java TestBaseParser.java

Thanks Felix ! On Fri, Mar 18, 2016 at 12:17 PM, wrote: > Author: fschumacher > Date: Fri Mar 18 11:17:47 2016 > New Revision: 1735575 > > URL: http://svn.apache.org/viewvc?rev=1735575&view=rev > Log: > Unittests for BaseParser. > > Added: > > jmeter/trunk/test/src/org/apache/jmeter/protocol/htt

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Hi all, Do I need to modify something to allow the PR be accepted? Thank Antonio 2016-03-17 14:45 GMT+01:00 Antonio Gomes Rodrigues : > Hi, > > Unitary tests fixed > > Antonio > > Cet e-mail a été envoyé depuis un ordinateur protégé par Avast. > www.avast.com >

buildbot failure in on jmeter-trunk

The Buildbot has detected a new failure on builder jmeter-trunk while building . Full details are available at: https://ci.apache.org/builders/jmeter-trunk/builds/839 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: The AnyBranchScheduler scheduler

Re: svn commit: r1735407 - in /jmeter/trunk: build.properties build.xml eclipse.classpath lib/ lib/aareadme.txt res/maven/ApacheJMeter_parent.pom xdocs/changes.xml

Yes, every 3rd party jar needs to be mentioned in LICENSE It's important that users have confidence that the code is available under the AL. If a jar is not mentioned, then it is not obvious whether it is compatible or not. Users should not have to work out which jars belong to the same project.

[GitHub] jmeter pull request: deprecate some methods in JMeterUtils

Github user benbenw commented on the pull request: https://github.com/apache/jmeter/pull/148#issuecomment-198284154 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

Re: Management of Redirect and rfc7231

+1 for this change @all thoughts ? On Thu, Mar 17, 2016 at 4:15 PM, UBIK LOAD PACK Support < supp...@ubikloadpack.com> wrote: > Hello Team, > Is JMeter 3.0 supposed to support : > >- https://tools.ietf.org/html/rfc7231 > > > 1/ If so there may be an issue in support of Redirect: > >- htt

Management of Redirect and rfc7231

Hello Team, Is JMeter 3.0 supposed to support : - https://tools.ietf.org/html/rfc7231 1/ If so there may be an issue in support of Redirect: - https://tools.ietf.org/html/rfc7231#section-6.4 Currently only Head is considered as Safe: - https://github.com/apache/jmeter/blob/trunk

[GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Github user ra0077 commented on the pull request: https://github.com/apache/jmeter/pull/167#issuecomment-197735103 New commit with formating and swap else branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

Re: svn commit: r1735407 - in /jmeter/trunk: build.properties build.xml eclipse.classpath lib/ lib/aareadme.txt res/maven/ApacheJMeter_parent.pom xdocs/changes.xml

All 3rd party jars need to be mentioned in LICENSE.txt even if they use AL2.0 On 17 March 2016 at 19:22, Philippe Mouawad wrote: > Done > > On Thu, Mar 17, 2016 at 4:56 PM, sebb wrote: > >> This is a new 3rd party jar. >> The license needs to be checked for compatibility and if OK must be >> doc

buildbot failure in on jmeter-trunk

The Buildbot has detected a new failure on builder jmeter-trunk while building . Full details are available at: https://ci.apache.org/builders/jmeter-trunk/builds/833 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: The AnyBranchScheduler scheduler

Re: Deprecate Java Implementation in HTTP Request before dropping it in N+2 version ?

Hello, Any thoughts on this one ? Some additional reasons: - What is the RFC supported ? With HttpClient we support RFC2616, which one do we support with Java when we delegate Redirection management to it ? Thanks On Sun, Mar 6, 2016 at 12:30 PM, Antonio Gomes Rodrigues wrote: > Hi, > >

Re: [GitHub] jmeter pull request: java constants naming

On 18 March 2016 at 16:44, benbenw wrote: > GitHub user benbenw opened a pull request: > > https://github.com/apache/jmeter/pull/171 > > java constants naming > > > > You can merge this pull request into a Git repository by running: > > $ git pull https://github.com/benbenw/jmeter java

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

I will fix the unit test asap Can you provide the checkstyle configuration to run it in local before commit the change? Antonio Cet e-mail a été envoyé depuis un ordinateur protégé par Avast. www.avast.com

Re: Management of Redirect and rfc7231

Well, httpclient 4.5.2 supports Rfc 2616 Only httpclient 5.0 will support Rfc 7230 So for now we will stick to the current behaviour. When switching to 5.0 we will reconsider this. Thanks for reporting On Friday, March 18, 2016, sebb wrote: > Not sure what you mean by that. > > JMeter should

Re: [GitHub] jmeter pull request: java constants naming

>Why change log to LOGGER? >It would make more sense to change it to LOG Frankly speaking, I think lowercase log is just perfect. What is the purpose of making LOG shout at you? Isn't log.info(...) self-descriptive enough? Vladimir

[GitHub] jmeter pull request: Force JSONPATH to always return list of Objec...

Github user max3163 commented on the pull request: https://github.com/apache/jmeter/pull/168#issuecomment-19667 First of all, In the present state of JMeter I can't use the the JSON-PATH post-processor : This error happen : 2016/03/17 09:53:18 ERROR - jmeter.threads.J

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

On 17 March 2016 at 07:39, vlsi wrote: > Github user vlsi commented on a diff in the pull request: > > https://github.com/apache/jmeter/pull/167#discussion_r56465359 > > --- Diff: src/core/org/apache/jmeter/services/FileServer.java --- > @@ -418,16 +418,20 @@ private BufferedReader get

[GitHub] jmeter pull request: java constants naming

Github user vlsi commented on the pull request: https://github.com/apache/jmeter/pull/171#issuecomment-198529464 @benbenw , thanks for bringing this up. Can you please enable relevant checkstyle rule so it would capture non-capital static finals violations in the future? --- If y

Re: Management of Redirect and rfc7231

Ideally JMeter should delegate the redirect decision to the HTTP library. However this may not be possible for all libraries. On 17 March 2016 at 20:46, Philippe Mouawad wrote: > +1 for this change > > @all thoughts ? > > On Thu, Mar 17, 2016 at 4:15 PM, UBIK LOAD PACK Support < > supp...@ubiklo

Re: [GitHub] jmeter pull request: java constants naming

On Fri, Mar 18, 2016 at 9:20 PM, Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Philippe>1/ I think you should put yourself at the place of the > contributor here. > Philippe>Why not say hello, thanks before discussing ? > > You are right. That makes sense. > > Philippe>2/ Discussion is

[GitHub] jmeter pull request: Bug 59197 : it should be possible to only run...

Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] jmeter pull request: Bug59190_BetterProxyExcludesSuggestedCaseSens...

GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/169 Bug59190_BetterProxyExcludesSuggestedCaseSensitive Hi, I have modified the suggested excludes to be no case sensitive like in Templates Antonio You can merge this pull request i

Version of BouncyCastle

Hi all, any reason why we still use bc 1.49 instead of current 1.54? Regards, Felix

Re: [GitHub] jmeter pull request: java constants naming

On 18 March 2016 at 17:55, Vladimir Sitnikov wrote: >>Why change log to LOGGER? >>It would make more sense to change it to LOG > > Frankly speaking, I think lowercase log is just perfect. > What is the purpose of making LOG shout at you? > > Isn't log.info(...) self-descriptive enough? Good point

buildbot failure in on jmeter-trunk

The Buildbot has detected a new failure on builder jmeter-trunk while building . Full details are available at: https://ci.apache.org/builders/jmeter-trunk/builds/853 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: The AnyBranchScheduler scheduler

Re: [GitHub] jmeter pull request: java constants naming

Philippe> No strong opinion on this: What's your opinion on "log"? Vladimir

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Hi, Thanks to the feedback check exists() is not necessary canRead public boolean canRead() Tests whether the application can read the file denoted by this abstract pathname. Returns:true if and only if the file specified by this abstract pathname exists *and* can be read by the application; f

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Hi, Unitary tests fixed Antonio Cet e-mail a été envoyé depuis un ordinateur protégé par Avast. www.avast.com <#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2> 2016-03-1

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Antonio>Do we have a checkstyle configuration or something like that to avoid waste Antonio>time (your time and mine) in how to code to JMeter? There's a checkstyle (it is run as a part of Travis job), however it would never check 100% of the issues. My "else branch swap" request was just to make

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Hi, Modification made and new commit provided Do we have a checkstyle configuration or something like that to avoid waste time (your time and mine) in how to code to JMeter? Antonio Cet e-mail a été envoyé depuis un ordinateur protégé par Avast. www.avast.com

[GitHub] jmeter pull request: Bug 59197 : it should be possible to only run...

GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/170 Bug 59197 : it should be possible to only run a single threadgroup or a selection of threadgroups. Right click on the TG and choose Start or Start no pauses You can merge this pull request into a G

Re: svn commit: r1735407 - in /jmeter/trunk: build.properties build.xml eclipse.classpath lib/ lib/aareadme.txt res/maven/ApacheJMeter_parent.pom xdocs/changes.xml

But accessors-smart is part of json-smart: https://github.com/netplex/json-smart-v2 Do I need to add a file for accessort-smart ? This is becoming a bit cumbersome each time we change a version On Thu, Mar 17, 2016 at 8:24 PM, sebb wrote: > All 3rd party jars need to be mentioned in LICENSE.tx

Re: [GitHub] jmeter pull request: java constants naming

Hi Vladimir, 1/ I think you should put yourself at the place of the contributor here. Why not say hello, thanks before discussing ? My note is about the first reaction by sebb here and the reply on another PR by same contributor the same day: - https://bz.apache.org/bugzilla/show_bug.cgi?id=5

[GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Github user vlsi commented on a diff in the pull request: https://github.com/apache/jmeter/pull/167#discussion_r56486961 --- Diff: src/core/org/apache/jmeter/services/FileServer.java --- @@ -428,7 +431,7 @@ private BufferedReader createBufferedReader(FileEntry fileEntry) throws IOE

Re: [GitHub] jmeter pull request: java constants naming

Philippe>1/ I think you should put yourself at the place of the contributor here. Philippe>Why not say hello, thanks before discussing ? You are right. That makes sense. Philippe>2/ Discussion is great but In my opinion, discussion on the naming of a Philippe>static variable contributed by somebo

Re: Remaining Work before Release of 3.0

Am 16. März 2016 20:16:22 MEZ, schrieb Philippe Mouawad : >Hi sebb, >With the last commits and comments on the issues you mentioned, >can we consider that remaining work is the following: >- sort the columns of saved columns per english translation : you seem >to >be handling it >- for the outpu

Re: Remaining Work before Release of 3.0

Hi sebb, With the last commits and comments on the issues you mentioned, can we consider that remaining work is the following: - sort the columns of saved columns per english translation : you seem to be handling it - for the output of reports, check that if -o is not used the default target folder

Re: IllegalAccessError when running ant run_gui

I also get this one before If my plan contains a CookieManager: 2016/03/17 20:42:20 ERROR - jmeter.protocol.http.control.CookieManager: Unable to load or invoke class: org.apache.jmeter.protocol.http.control.HC4CookieHandler org.apache.jorphan.util.JMeterException: java.lang.ClassNotFoundException: