Re: [VOTE] Release JMeter 3.0 RC3

2016-05-07 Thread Philippe Mouawad
Hello, I reviewed the code today and made some fixes and further tests. On my side it is ok to proceed with RM. Thank to RM for his hard work on this 3.0 Regards On Sat, May 7, 2016 at 11:29 AM, Philippe Mouawad < philippe.moua...@gmail.com> wrote: > I retire the veto but please ensure report

Jenkins build is back to normal : JMeter-trunk #5282

2016-05-07 Thread Apache Jenkins Server
See

Re: svn commit: r1742642 - in /jmeter/trunk: bin/jmeter.properties bin/reportgenerator.properties src/core/org/apache/jmeter/report/dashboard/ReportGenerator.java

2016-05-07 Thread Philippe Mouawad
Another comment, AFAIU, reportgenerator.properties must be added to bundles ? I commited the fix, but please review as I am not sure. On Sat, May 7, 2016 at 12:06 AM, sebb wrote: > On 6 May 2016 at 22:44, Philippe Mouawad > wrote: > > -1 > > > > I thought no important modification was to be don

Re: svn commit: r1742642 - in /jmeter/trunk: bin/jmeter.properties bin/reportgenerator.properties src/core/org/apache/jmeter/report/dashboard/ReportGenerator.java

2016-05-07 Thread Philippe Mouawad
On Sat, May 7, 2016 at 12:14 PM, sebb wrote: > On 7 May 2016 at 10:33, Philippe Mouawad > wrote: > > On Saturday, May 7, 2016, sebb wrote: > > > >> On 7 May 2016 at 07:10, Philippe Mouawad >> > wrote: > >> > Hello, > >> > I don't see docs update neither. > >> > >> The only relevant place I can

Re: svn commit: r1742100 - in /jmeter/trunk: bin/jmeter.properties bin/user.properties src/core/org/apache/jmeter/report/config/ReportGeneratorConfiguration.java xdocs/usermanual/generating-dashboard.

2016-05-07 Thread Philippe Mouawad
Fixed On Sat, May 7, 2016 at 7:17 PM, Philippe Mouawad wrote: > > > On Saturday, May 7, 2016, sebb wrote: > >> On 3 May 2016 at 12:33, wrote: >> > Author: pmouawad >> > Date: Tue May 3 11:33:46 2016 >> > New Revision: 1742100 >> > >> > URL: http://svn.apache.org/viewvc?rev=1742100&view=rev >

[GitHub] jmeter pull request: Used multi-catch, enhanced for loops, contain...

2016-05-07 Thread ham1
Github user ham1 commented on a diff in the pull request: https://github.com/apache/jmeter/pull/174#discussion_r62420814 --- Diff: src/core/org/apache/jmeter/reporters/ResultCollector.java --- @@ -386,16 +384,14 @@ public void loadExistingFile() { S

[GitHub] jmeter pull request: Refactoring of HTTPSamplerBase

2016-05-07 Thread ham1
Github user ham1 closed the pull request at: https://github.com/apache/jmeter/pull/131 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

Re: svn commit: r1742100 - in /jmeter/trunk: bin/jmeter.properties bin/user.properties src/core/org/apache/jmeter/report/config/ReportGeneratorConfiguration.java xdocs/usermanual/generating-dashboard.

2016-05-07 Thread Philippe Mouawad
On Saturday, May 7, 2016, sebb wrote: > On 3 May 2016 at 12:33, > wrote: > > Author: pmouawad > > Date: Tue May 3 11:33:46 2016 > > New Revision: 1742100 > > > > URL: http://svn.apache.org/viewvc?rev=1742100&view=rev > > Log: > > Report generation : Better defaults > > filters_only_sample_serie

Build failed in Jenkins: JMeter-trunk #5281

2016-05-07 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on ubuntu-6 (docker Ubuntu ubuntu yahoo-not-h2) in workspace

Build failed in Jenkins: JMeter-trunk #5280

2016-05-07 Thread Apache Jenkins Server
See Changes: [sebb] Note that the class now supports JUnit4 Synch log with JUnit3 version -- [...truncated 952 lines...] [anakia] Output:

Build failed in Jenkins: JMeter-trunk #5279

2016-05-07 Thread Apache Jenkins Server
See Changes: [sebb] Add tests for properties files -- [...truncated 954 lines...] [anakia] Output:

Build failed in Jenkins: JMeter-trunk #5278

2016-05-07 Thread Apache Jenkins Server
See Changes: [sebb] Drop some bug reports that relate to nightly builds only -- [...truncated 950 lines...] [anakia] Output:

Re: svn commit: r1742100 - in /jmeter/trunk: bin/jmeter.properties bin/user.properties src/core/org/apache/jmeter/report/config/ReportGeneratorConfiguration.java xdocs/usermanual/generating-dashboard.

2016-05-07 Thread sebb
On 3 May 2016 at 12:33, wrote: > Author: pmouawad > Date: Tue May 3 11:33:46 2016 > New Revision: 1742100 > > URL: http://svn.apache.org/viewvc?rev=1742100&view=rev > Log: > Report generation : Better defaults > filters_only_sample_series must be true to avoid empty graphs > > Modified: > jm

Re: svn commit: r1742642 - in /jmeter/trunk: bin/jmeter.properties bin/reportgenerator.properties src/core/org/apache/jmeter/report/dashboard/ReportGenerator.java

2016-05-07 Thread sebb
On 7 May 2016 at 10:33, Philippe Mouawad wrote: > On Saturday, May 7, 2016, sebb wrote: > >> On 7 May 2016 at 07:10, Philippe Mouawad > > wrote: >> > Hello, >> > I don't see docs update neither. >> >> The only relevant place I can find is properties_reference which I have >> updated. >> If there

Build failed in Jenkins: JMeter-trunk #5277

2016-05-07 Thread Apache Jenkins Server
See Changes: [sebb] Mention reportgeenrator.properties -- [...truncated 950 lines...] [anakia] Output:

Re: svn commit: r1742642 - in /jmeter/trunk: bin/jmeter.properties bin/reportgenerator.properties src/core/org/apache/jmeter/report/dashboard/ReportGenerator.java

2016-05-07 Thread Philippe Mouawad
On Saturday, May 7, 2016, sebb wrote: > On 7 May 2016 at 07:10, Philippe Mouawad > wrote: > > Hello, > > I don't see docs update neither. > > The only relevant place I can find is properties_reference which I have > updated. > If there are any other places let me know. i see no mention of this

Re: [VOTE] Release JMeter 3.0 RC3

2016-05-07 Thread Philippe Mouawad
I retire the veto but please ensure report generation works fine: - locally - in distributed testing - with properties modified It would be sad to discover an issue in rc4 due to it. I 've been testing this feature thorougjly on rc3. I don't have time to renew tests on rc4 Thanks On Saturday, May

Re: [VOTE] Release JMeter 3.0 RC3

2016-05-07 Thread Felix Schumacher
Ok for me Thanks for rm Felix Am 7. Mai 2016 09:55:24 MESZ, schrieb Milamber : >Hello, > >Are you ready for the RC4 ? I can start the release process tonight or >tomorrow ? > >Milamber > >On 01/05/2016 14:48, Philippe Mouawad wrote: >> Hi Milamber, >> It appears we have a last minute regression

Re: [VOTE] Release JMeter 3.0 RC3

2016-05-07 Thread sebb
OK for me assuming that the veto against the changes to the location of the RG properties is withdrawn. On 7 May 2016 at 09:31, Philippe Mouawad wrote: > ok for me > > On Saturday, May 7, 2016, Milamber wrote: > >> Hello, >> >> Are you ready for the RC4 ? I can start the release process tonight

Re: svn commit: r1742642 - in /jmeter/trunk: bin/jmeter.properties bin/reportgenerator.properties src/core/org/apache/jmeter/report/dashboard/ReportGenerator.java

2016-05-07 Thread sebb
On 7 May 2016 at 07:10, Philippe Mouawad wrote: > Hello, > I don't see docs update neither. The only relevant place I can find is properties_reference which I have updated. If there are any other places let me know. > But for me it should have been discussed before and commited only after 3.0 >

Re: [VOTE] Release JMeter 3.0 RC3

2016-05-07 Thread Philippe Mouawad
ok for me On Saturday, May 7, 2016, Milamber wrote: > Hello, > > Are you ready for the RC4 ? I can start the release process tonight or > tomorrow ? > > Milamber > > On 01/05/2016 14:48, Philippe Mouawad wrote: > >> Hi Milamber, >> It appears we have a last minute regression report: >> - https:/

Re: [VOTE] Release JMeter 3.0 RC3

2016-05-07 Thread Milamber
Hello, Are you ready for the RC4 ? I can start the release process tonight or tomorrow ? Milamber On 01/05/2016 14:48, Philippe Mouawad wrote: Hi Milamber, It appears we have a last minute regression report: - https://bz.apache.org/bugzilla/show_bug.cgi?id=59401 I confirm the issue. Issue i