[GitHub] jmeter issue #240: Improves JMS component robustness

2016-12-28 Thread loganmzz
Github user loganmzz commented on the issue: https://github.com/apache/jmeter/pull/240 Close publisher isn't supposed to throw exception. A quick view at the code, confirms only system (in VM sense) error can be raised. What is supposed to be done in this case ? --- If your project

NewDriver : MalformedURLException

2016-12-28 Thread Philippe Mouawad
Hello, Looking at sonar analysis, we see in NewDriver class that a lot MalformedURLException are ignored and just logged (using printStackTrace). Looking at code, I don't understand why we don't let them trigger instead of just logging . Thanks Regards

[GitHub] jmeter issue #237: Adds a time boxed sampling for backend listeners

2016-12-28 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/237 Hello Team, PR looks fine to me. Do you agree with enhancement ? Thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] jmeter pull request #242: BUGID #60154

2016-12-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/242 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Jenkins build is back to normal : JMeter-trunk #5653

2016-12-28 Thread Apache Jenkins Server
See

[GitHub] jmeter issue #240: Improves JMS component robustness

2016-12-28 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/240 Thanks for contribution. Few notes: - docs (component-reference.xml) should be updated - In handleError, I think you should surround close line 232 with try/catch

[GitHub] jmeter issue #241: Support variable for all JMS messages (bytes, object, ......

2016-12-28 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/241 Hello @loganmzz , Is this PR a duplicate of PR 239 ? If so, could you close 239? Did you check the performance impact of this feature ? Thanks a lot for your contribution.

[GitHub] jmeter pull request #232: Added nano resolution on elapsed to Jms publisher.

2016-12-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/232 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] jmeter pull request #236: Bug 59937: Sub menus addition

2016-12-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/236 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] jmeter issue #227: Bug 55258

2016-12-28 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/227 Hi Team, Shall I merge this one ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] jmeter pull request #210: Added a Graphite sender to send metrics in statsd ...

2016-12-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/210 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Build failed in Jenkins: JMeter-trunk #5652

2016-12-28 Thread Philippe Mouawad
Hi Felix, If you look at my other question after a random failure of tests, I think we globally have an issue with tests that sleep, I suspect it might be to Jenkins agent load sometimes and some tests not sleeping at the right moment. I agree nothing was touched on this component nor on tests

Re: Lock usage in SessionFilter

2016-12-28 Thread Vladimir Sitnikov
>managersInUse should be cleared by >threadFinished What are the cases when JMeter uses Thread#interrupt? I think the only case is when user terminates the test (e.g. by clicking "stop") Then: 1) The test should be terminated, thread should be re-interrupted (to break similar while(){...wait...}

Re: Build failed in Jenkins: JMeter-trunk #5652

2016-12-28 Thread Felix Schumacher
Am 28.12.2016 um 13:25 schrieb Apache Jenkins Server: See -- [...truncated 988 lines...] [javadoc] Javadoc execution [javadoc] Loading source files for package org.apache.jmeter... [javadoc]

Build failed in Jenkins: JMeter-trunk #5652

2016-12-28 Thread Apache Jenkins Server
See -- [...truncated 988 lines...] [javadoc] Javadoc execution [javadoc] Loading source files for package org.apache.jmeter... [javadoc] Loading source files for package

Build failed in Jenkins: JMeter-trunk #5651

2016-12-28 Thread Apache Jenkins Server
See -- [...truncated 537 lines...] _get_jarfile: _get_zipfile: _check_exists: _check_jarfile: [echo] Checking mongo-java-driver-2.11.3.jar [echo] Deleting mongo-java-driver-*.jar (excluding

Build failed in Jenkins: JMeter-trunk #5650

2016-12-28 Thread Apache Jenkins Server
See Changes: [fschumacher] Add a new target nightlysonar, which combines nightly and sonar. That way we will save a test run worth of time on the build server. -- [...truncated 988 lines...]

Jenkins build is back to normal : JMeter-trunk #5649

2016-12-28 Thread Apache Jenkins Server
See

Re: Lock usage in SessionFilter

2016-12-28 Thread Felix Schumacher
Am 27.12.2016 um 21:52 schrieb Vladimir Sitnikov: On managersInUse we use wait() and notify(), which seems wrong to me, as we synchronized using LOCK and not managersInUse. Is that code used at all? Could be, but probably only very seldom. I now have looked into the history of this file and

Build failed in Jenkins: JMeter-trunk #5648

2016-12-28 Thread Apache Jenkins Server
See Changes: [fschumacher] Add Apache license and set eol to native. -- [...truncated 2420 lines...] compile: prepare-resources: [copy] Copying 3 files to