[GitHub] jmeter pull request #250: Feature/bz60564 (1)

2017-02-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/250 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

Re: svn commit: r1781805 - /jmeter/trunk/src/core/org/apache/jmeter/gui/logging/GuiLogEventBus.java

2017-02-05 Thread Felix Schumacher
Am 5. Februar 2017 21:56:14 MEZ schrieb pmoua...@apache.org: >Author: pmouawad >Date: Sun Feb 5 20:56:14 2017 >New Revision: 1781805 > >URL: http://svn.apache.org/viewvc?rev=1781805&view=rev >Log: >Take into account Felix comment > >Modified: >jmeter/trunk/src/core/org/apache/jmeter/gui/logging/

[GitHub] jmeter pull request #262: Updated README.md

2017-02-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/262 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

Re: svn commit: r1780852 - in /jmeter/trunk: src/protocol/http/org/apache/jmeter/protocol/http/control/DNSCacheManager.java test/src/org/apache/jmeter/protocol/http/control/TestDNSCacheManager.java

2017-02-05 Thread Milamber
I've comment the test about ipv4/ipv6. It's possible to have a notification to dev@j.a.o from Travis if a build failed? On 05/02/2017 17:44, Philippe Mouawad wrote: Hi, Maybe we should adapt the test to the ip typology. Regards On Sunday, February 5, 2017, Graham Russell wrote: The same

[GitHub] jmeter pull request #262: Updated README.md

2017-02-05 Thread ham1
GitHub user ham1 opened a pull request: https://github.com/apache/jmeter/pull/262 Updated README.md Updated: * formatting * grammar * wording You can merge this pull request into a Git repository by running: $ git pull https://github.com/ham1/jmeter readme-update A

Re: svn commit: r1780852 - in /jmeter/trunk: src/protocol/http/org/apache/jmeter/protocol/http/control/DNSCacheManager.java test/src/org/apache/jmeter/protocol/http/control/TestDNSCacheManager.java

2017-02-05 Thread Philippe Mouawad
Hi, Maybe we should adapt the test to the ip typology. Regards On Sunday, February 5, 2017, Graham Russell wrote: > The same failure is happening on Travis as well: > https://travis-ci.org/apache/jmeter/jobs/198595940 > > Graham > Graham > > > On 5 February 2017 at 16:40, Milamber > > wrote: >

Re: svn commit: r1780852 - in /jmeter/trunk: src/protocol/http/org/apache/jmeter/protocol/http/control/DNSCacheManager.java test/src/org/apache/jmeter/protocol/http/control/TestDNSCacheManager.java

2017-02-05 Thread Graham Russell
The same failure is happening on Travis as well: https://travis-ci.org/apache/jmeter/jobs/198595940 Graham Graham On 5 February 2017 at 16:40, Milamber wrote: > > > On 29/01/2017 20:35, pmoua...@apache.org wrote: >> >> Modified: >> jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/T

Re: svn commit: r1780852 - in /jmeter/trunk: src/protocol/http/org/apache/jmeter/protocol/http/control/DNSCacheManager.java test/src/org/apache/jmeter/protocol/http/control/TestDNSCacheManager.java

2017-02-05 Thread Milamber
On 29/01/2017 20:35, pmoua...@apache.org wrote: Modified: jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestDNSCacheManager.java URL:http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestDNSCacheManager.java?rev=1780852&r1=1780851&r2=178

Jenkins build is back to normal : JMeter-trunk #5796

2017-02-05 Thread Apache Jenkins Server
See

Re: Want to help with migrating from Apache LogKit to SLF4J

2017-02-05 Thread Philippe Mouawad
Thanks Felix for your review. I've merged the PR with only modifications related to build and exclusions/cleanup in build. I've not taken into account the remarks on PR, feel free to commit and review. I've cleaned up aaareadme but did not update it yet. Regards Philippe On Sat, Feb 4, 2017 at 10

buildbot success in on jmeter-trunk

2017-02-05 Thread buildbot
The Buildbot has detected a restored build on builder jmeter-trunk while building . Full details are available at: https://ci.apache.org/builders/jmeter-trunk/builds/2104 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_slave1_ubuntu Build Reason: The AnyBranchScheduler sc

Build failed in Jenkins: JMeter-trunk #5795

2017-02-05 Thread Apache Jenkins Server
See Changes: [pmouawad] Bug 60589 - Migrate LogKit to SLF4J - Drop avalon, logkit and excalibur with backward compatibility for 3rd party modules Remove mention of commons-logging in docs Bugzilla Id: 60589 [pmouawad] Bug 60589 - Migrate

[GitHub] jmeter pull request #254: Feature/bz60589-1 PR for review (logkit to slf4j /...

2017-02-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/254 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] jmeter pull request #254: Feature/bz60589-1 PR for review (logkit to slf4j /...

2017-02-05 Thread vlsi
Github user vlsi commented on a diff in the pull request: https://github.com/apache/jmeter/pull/254#discussion_r99489638 --- Diff: src/core/org/apache/jmeter/gui/GuiPackage.java --- @@ -71,10 +72,6 @@ /** Logging. */ private static final Logger log = LoggingManager

[GitHub] jmeter pull request #254: Feature/bz60589-1 PR for review (logkit to slf4j /...

2017-02-05 Thread vlsi
Github user vlsi commented on a diff in the pull request: https://github.com/apache/jmeter/pull/254#discussion_r99489555 --- Diff: src/core/org/apache/jmeter/NewDriver.java --- @@ -276,4 +276,106 @@ private static String exceptionsToString(List exceptionsInInit) { }

buildbot failure in on jmeter-trunk

2017-02-05 Thread buildbot
The Buildbot has detected a new failure on builder jmeter-trunk while building . Full details are available at: https://ci.apache.org/builders/jmeter-trunk/builds/2095 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_slave1_ubuntu Build Reason: The AnyBranchScheduler sched

[GitHub] jmeter issue #254: Feature/bz60589-1 PR for review (logkit to slf4j / log4j2...

2017-02-05 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/254 Forget about my comment on jcl --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] jmeter pull request #254: Feature/bz60589-1 PR for review (logkit to slf4j /...

2017-02-05 Thread FSchumacher
Github user FSchumacher commented on a diff in the pull request: https://github.com/apache/jmeter/pull/254#discussion_r99488717 --- Diff: src/core/org/apache/jmeter/NewDriver.java --- @@ -276,4 +276,106 @@ private static String exceptionsToString(List exceptionsInInit) {

[GitHub] jmeter issue #254: Feature/bz60589-1 PR for review (logkit to slf4j / log4j2...

2017-02-05 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/254 I'm not sure commons-logging can be dropped as it's a compile dependency of HttpClient 4.5.3: https://repo1.maven.org/maven2/org/apache/httpcomponents/httpclient/4.5.3/httpclient-4.5.3.pom ---

[GitHub] jmeter pull request #254: Feature/bz60589-1 PR for review (logkit to slf4j /...

2017-02-05 Thread FSchumacher
Github user FSchumacher commented on a diff in the pull request: https://github.com/apache/jmeter/pull/254#discussion_r99488610 --- Diff: src/protocol/http/org/apache/jmeter/protocol/http/control/HttpMirrorServer.java --- @@ -159,14 +192,84 @@ public Exception getException(){

[GitHub] jmeter pull request #254: Feature/bz60589-1 PR for review (logkit to slf4j /...

2017-02-05 Thread FSchumacher
Github user FSchumacher commented on a diff in the pull request: https://github.com/apache/jmeter/pull/254#discussion_r99488452 --- Diff: src/core/org/apache/jmeter/gui/logging/GuiLogEventBus.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] jmeter pull request #254: Feature/bz60589-1 PR for review (logkit to slf4j /...

2017-02-05 Thread FSchumacher
Github user FSchumacher commented on a diff in the pull request: https://github.com/apache/jmeter/pull/254#discussion_r99488425 --- Diff: src/core/org/apache/jmeter/gui/logging/GuiLogEventBus.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] jmeter pull request #254: Feature/bz60589-1 PR for review (logkit to slf4j /...

2017-02-05 Thread FSchumacher
Github user FSchumacher commented on a diff in the pull request: https://github.com/apache/jmeter/pull/254#discussion_r99488229 --- Diff: src/core/org/apache/jmeter/NewDriver.java --- @@ -276,4 +276,106 @@ private static String exceptionsToString(List exceptionsInInit) {