Re: Migration to Slf4j and backward compatibility policy

2017-02-10 Thread Antonio Gomes Rodrigues
Hi, Thanks to the merge of the PR +1 for your solutions Antonio 2017-02-10 7:52 GMT+01:00 Philippe Mouawad : > Hello, > In the process of migrating, there are 2 places where we face the backward > compatibility issue: > - AbstractJavaSamplerClient#getLogger > - Dynamic scripting elements (Jsr2

Drop rhino

2017-02-10 Thread Maxime Chassagneux
Hi, As JMeter 3.2 now use Java 1.8 I would like to drop the Rhino Javscript engine in favor of nashor ( which is already an option today ). It's mostly easy but I have a question about the BSFJavaScriptEngine class. Is-it still used ? I don't understand how it work and where it's use.

Re: Drop rhino

2017-02-10 Thread Philippe Mouawad
Hi Maxime, I think we need for now to keep backward compatibility. We already switch to Nashorn in 3.2 by default, but some users may still rely on Rhino. So for 3.2, let's keep it and probably inform we will drop it in 3.3 or 4.0 if a consensus is reached on this. Thanks. On Fri, Feb 10, 2017

[GitHub] jmeter pull request #272: Bug 60564 - Migrating LogKit to SLF4J - core/gui p...

2017-02-10 Thread woonsan
GitHub user woonsan opened a pull request: https://github.com/apache/jmeter/pull/272 Bug 60564 - Migrating LogKit to SLF4J - core/gui package You can merge this pull request into a Git repository by running: $ git pull https://github.com/woonsan/jmeter feature/bz60564-11 Alte

Re: Migration to Slf4j and backward compatibility policy

2017-02-10 Thread Woonsan Ko
On Fri, Feb 10, 2017 at 1:52 AM, Philippe Mouawad wrote: > Hello, > In the process of migrating, there are 2 places where we face the backward > compatibility issue: > - AbstractJavaSamplerClient#getLogger > - Dynamic scripting elements (Jsr223, Bsf and Beanshell) > > For the first case I think we

buildbot success in on jmeter-trunk

2017-02-10 Thread buildbot
The Buildbot has detected a restored build on builder jmeter-trunk while building . Full details are available at: https://ci.apache.org/builders/jmeter-trunk/builds/2165 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_slave1_ubuntu Build Reason: The AnyBranchScheduler sc

Re: Deprecate HTML Link Parser and HTTP URL Re-writing Modifier

2017-02-10 Thread Felix Schumacher
Am 10.02.2017 um 07:47 schrieb Philippe Mouawad: Hello, From a poll on twitter, it appears around 12% of answerers still need those 2. So I think we should keep them . OK with me :) Felix Regards On Monday, January 30, 2017, Philippe Mouawad wrote: Hi, Any other thoughts on this ? Thanks

Re: [Bug 59995] Allow user to change font size with 2 new menu items and use "jmeter.hidpi.scale.factor" for scaling fonts

2017-02-10 Thread Philippe Mouawad
; OK. So we have to store the changes and apply them after the iteration. > > Will do that tomorrow, of you don't beat me :) > > Felix > > >at java.util.Hashtable$Enumerator.next(Hashtable.java:1378) > >~[?:1.8.0_112] > > at org.apache.jmeter.util

[GitHub] jmeter pull request #271: Bug 60564 - Migrating LogKit to SLF4J - core/sampl...

2017-02-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/271 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] jmeter pull request #272: Bug 60564 - Migrating LogKit to SLF4J - core/gui p...

2017-02-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/272 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

Re: Migration to Slf4j and backward compatibility policy

2017-02-10 Thread Philippe Mouawad
On Fri, Feb 10, 2017 at 6:46 PM, Woonsan Ko wrote: > On Fri, Feb 10, 2017 at 1:52 AM, Philippe Mouawad > wrote: > > Hello, > > In the process of migrating, there are 2 places where we face the > backward > > compatibility issue: > > - AbstractJavaSamplerClient#getLogger > > - Dynamic scripting e

[GitHub] jmeter pull request #273: Bug 60564 - Migrating LogKit to SLF4J - core/teste...

2017-02-10 Thread woonsan
GitHub user woonsan opened a pull request: https://github.com/apache/jmeter/pull/273 Bug 60564 - Migrating LogKit to SLF4J - core/testelement,threads,util,visualizers package You can merge this pull request into a Git repository by running: $ git pull https://github.com/woons

[GitHub] jmeter pull request #274: Bug 60564 - Migrating LogKit to SLF4J - components...

2017-02-10 Thread woonsan
GitHub user woonsan opened a pull request: https://github.com/apache/jmeter/pull/274 Bug 60564 - Migrating LogKit to SLF4J - components (1), functions, protocol, test Migrated old logger to slf4j logger in functions, protocols and test. Also, applied the same backward compatibil