[GitHub] jmeter issue #283: Allow on JMeter client to use variables and functions for...

2017-03-10 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/283 Hello Maxime, Thanks for patch. My remarks: - I think we need here JUnit tests to check no regression will occur. This part of the code is complex and critical and needs 100% coverage

Re: Trim JTexfield

2017-03-10 Thread Philippe Mouawad
Hi Maxime, This "issue" has been diagnosed a while but unfortunately fixing it might break a lot of fields in existing user test plans. You can search in Bugzilla I think (but maybe closed as WONTFIX). If we want to make a change we need to analyze case by case. For now, I think the priority is

Trim JTexfield

2017-03-10 Thread Maxime Chassagneux
Hello, There is a reason why none JTexfield aren't trim by default ? In most cases, end spaces aren't desire and are problematic. By example, If you put one space after the Vuser number the run don't start without any error ... Yesterday I spent an hour to debug a problem on a JDBC connection

[GitHub] jmeter pull request #283: Allow on JMeter client to use variables and functi...

2017-03-10 Thread max3163
GitHub user max3163 opened a pull request: https://github.com/apache/jmeter/pull/283 Allow on JMeter client to use variables and functions for Listener This patch allow to use in all ResultCollector and Backend sampler ( which are executed in the client side for a distributed

Re: Variable in BackendListener

2017-03-10 Thread Maxime Chassagneux
Hi, Could you look at the #283 PR on github to review my patch. Thanks. 2017-03-09 14:58 GMT+01:00 Maxime Chassagneux : > > 2017-03-09 14:42 GMT+01:00 sebb : > >> On 9 March 2017 at 08:52, Maxime Chassagneux >>