[GitHub] jmeter issue #346: Bug 61827 - TextFile always adds newline to end of string

2017-12-01 Thread max3163
Github user max3163 commented on the issue: https://github.com/apache/jmeter/pull/346 Hi @ham1, I just review your patch, I use exactly the same way in our environment since 1-2 weeks without any problem. So lgtm +1 ---

[GitHub] jmeter pull request #347: Supply Subject Alternative Name on HTTPS certs.

2017-12-01 Thread buckett
GitHub user buckett opened a pull request: https://github.com/apache/jmeter/pull/347 Supply Subject Alternative Name on HTTPS certs. Recently browsers have started to not trust a certificate if it doesn’t have a Subject Alternative Name (SAN) that matches the domain name. This cau

[GitHub] jmeter pull request #348: Removed LogFilter and associated uses.

2017-12-01 Thread ham1
GitHub user ham1 opened a pull request: https://github.com/apache/jmeter/pull/348 Removed LogFilter and associated uses. Also formatted JavaDocs in SessionFilter. ## Description I was about to write some Spock tests for `LogFilter` but, apart from the file not having me

[GitHub] jmeter pull request #347: Supply Subject Alternative Name on HTTPS certs.

2017-12-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/347 ---

[GitHub] jmeter issue #348: Removed LogFilter and associated uses.

2017-12-01 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/jmeter/pull/348 # [Codecov](https://codecov.io/gh/apache/jmeter/pull/348?src=pr&el=h1) Report > Merging [#348](https://codecov.io/gh/apache/jmeter/pull/348?src=pr&el=desc) into [trunk](https://codecov.io/gh/

[GitHub] jmeter issue #348: Removed LogFilter and associated uses.

2017-12-01 Thread ham1
Github user ham1 commented on the issue: https://github.com/apache/jmeter/pull/348 Happy for someone to show me how this is used and useful and I will close the PR and learn from it :) ---

[GitHub] jmeter pull request #344: Migrate JSON Path Assertion into JMeter core

2017-12-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/344 ---

[GitHub] jmeter issue #342: More edge cases for changeCase function and slight behavi...

2017-12-01 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/342 Hi Felix, It seems there is a consensus to drop CamelCase from function. I agree also with it as I have never really needed in all my tests camel case nor any member of our team. So I have a

[GitHub] jmeter pull request #346: Bug 61827 - TextFile always adds newline to end of...

2017-12-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/346 ---

Build failed in Jenkins: JMeter Windows #919

2017-12-01 Thread Apache Jenkins Server
See Changes: [pmouawad] Bug 61827 - [JMSPublisher] Don't add new line at the end of the file Contributed by Graham Russell This closes #346 Bugzilla Id: 61827 [pmouawad] Bug 61845 - New Component JSON Assertion B

[GitHub] jmeter issue #348: Removed LogFilter and associated uses.

2017-12-01 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/348 Hi @ham1 , I never used this Access log sampler in JMeter . But I think the classes you removed are used as possible implementations for filtering. See: - http://jmeter.apache.or

Build failed in Jenkins: JMeter-trunk #6515

2017-12-01 Thread Apache Jenkins Server
See Changes: [pmouawad] Bug 61846 - Scoped Assertion should follow same order of evaluation as Post Processors Bugzilla Id: 61846 [pmouawad] Default Language has accidentally switched to english on Windows in 3.3

buildbot failure in on jmeter-trunk

2017-12-01 Thread buildbot
The Buildbot has detected a new failure on builder jmeter-trunk while building . Full details are available at: https://ci.apache.org/builders/jmeter-trunk/builds/3300 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_slave1_ubuntu Build Reason: The AnyBranchScheduler sched

[GitHub] jmeter issue #341: Test isIgnore after post processor and assertions

2017-12-01 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/341 Hi @FSchumacher , Good idea. Is this in relation with https://github.com/apache/jmeter/pull/313 ? Thanks ---

buildbot success in on jmeter-trunk

2017-12-01 Thread buildbot
The Buildbot has detected a restored build on builder jmeter-trunk while building . Full details are available at: https://ci.apache.org/builders/jmeter-trunk/builds/3303 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_slave1_ubuntu Build Reason: The AnyBranchScheduler sc

[GitHub] jmeter issue #348: Removed LogFilter and associated uses.

2017-12-01 Thread ham1
Github user ham1 commented on the issue: https://github.com/apache/jmeter/pull/348 Yes it is picked up by the GUI there, but there isn't any way to configure it in the GUI (as confirmed by the docs) so I can't see how it's useful. The default constructor is blank thus I think it just

Jenkins build is back to normal : JMeter-trunk #6516

2017-12-01 Thread Apache Jenkins Server
See

Build failed in Jenkins: JMeter Windows #920

2017-12-01 Thread Apache Jenkins Server
See Changes: [pmouawad] Bug 61846 - Scoped Assertion should follow same order of evaluation as Post Processors Update XML test results Bugzilla Id: 61846 [pmouawad] Bug 61846 - Scoped Assertion should follow sa

[GitHub] jmeter pull request #349: add i18n resouces(zh_CN)

2017-12-01 Thread hellyguo
GitHub user hellyguo opened a pull request: https://github.com/apache/jmeter/pull/349 add i18n resouces(zh_CN) ## Description add i18n resouces add some *_zh_CN.properties ## Motivation and Context to imporve UI in Chinese ## How Has This Been Tested?

[GitHub] jmeter issue #349: add i18n resouces(zh_CN)

2017-12-01 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/jmeter/pull/349 # [Codecov](https://codecov.io/gh/apache/jmeter/pull/349?src=pr&el=h1) Report > Merging [#349](https://codecov.io/gh/apache/jmeter/pull/349?src=pr&el=desc) into [trunk](https://codecov.io/gh/