[GitHub] jmeter issue #384: Minor wording correction

2018-06-15 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/384 Thanks for PR, still I think the initial phrase is correct without comma: - Load test functional behaviour Unless I misunderstand, can you close your PR ? Thank you ---

[GitHub] jmeter issue #385: jMeter threads implemented using CachedThreadPool

2018-06-15 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/385 Thanks for PR and contribution. Still as answered by Felix, this PR is too simple and would break a lot of things in JMeter and important data are stored in ThreadLocal. Thank you to clo

[GitHub] jmeter issue #387: Add delegation for SPNEGO back to JMeter

2018-06-15 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/387 Hi Felix, Did you have time to check the changes are working ? If yes, +1 for committing it. ---

[GitHub] jmeter pull request #383: Docs 4.0

2018-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/383 ---

[GitHub] jmeter pull request #384: Minor wording correction

2018-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/384 ---

[GitHub] jmeter pull request #385: jMeter threads implemented using CachedThreadPool

2018-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/385 ---

[GitHub] jmeter issue #72: MQTT plugin for Jmeter

2018-06-15 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/72 It appears that you have made this a 3rd party plugin for MQTT. So we'll close this PR as WONTFIX. Thank you anyway for your contribution. ---

[GitHub] jmeter issue #233: Bug 60274

2018-06-15 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/233 It appears similar feature is now available a 3rd party plugin : * https://jmeter-plugins.org/?search=Weighted So I propose to close this one. ---

[GitHub] jmeter pull request #233: Bug 60274

2018-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/233 ---

[GitHub] jmeter pull request #72: MQTT plugin for Jmeter

2018-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/72 ---

[GitHub] jmeter issue #356: Sonar fixes

2018-06-15 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/356 Hello @ham1 , I hope you're fine. Thanks for this PR which took some time to be taken into account. It now conflicts with a lot of files so it would be nice if you could rebase it.

[GitHub] jmeter pull request #372: Remove unused variable assignment.

2018-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/372 ---

Re: Add more informations (metadata) to JMeter result

2018-06-15 Thread Philippe Mouawad
Hello, Any thoughts on this and what shall we do with: - https://github.com/apache/jmeter/pull/313 After further thinking, IMO merging the PR does not look to me a good solution. But being able to add comments to the Report is needed: - Simple one : General Comment on test known before

Build failed in Jenkins: JMeter Windows #1094

2018-06-15 Thread Apache Jenkins Server
See Changes: [pmouawad] Remove unused variable assignment. Contributed by Graham Russell This closes #372 [pmouawad] Closing reviewed and WONTFIX PR: This closes #72 This closes #233 [pmouawad] Closing revie

buildbot success in on jmeter-nightly

2018-06-15 Thread buildbot
The Buildbot has detected a restored build on builder jmeter-nightly while building . Full details are available at: https://ci.apache.org/builders/jmeter-nightly/builds/1069 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_slave7_ubuntu Build Reason: The Nightly scheduler