Version 5.2 (Broken poms)

Hello, We have an issue with generated poms: 1/ Unspecified version in ApacheJMeter_core for jorphan: https://repo1.maven.org/maven2/org/apache/jmeter/ApacheJMeter_core/5.2/ApacheJMeter_core-5.2.pom We have this: org.apache.jmeterjorphanunspecified 2/ The other poms are wrong. Previously all mo

Re: Version 5.2 (Broken poms)

Hello, Point 1/ is correct Point 2/ is not. The approach is now to remove inheritance and favor explicit dependency. a) But is it correct to declare dependencies of modules with scope runtime ? b) It was not the case previously, they has compile scope. Thanks On Sat, Nov 9, 2019 at 11:35 AM Phil

Re: Version 5.2 (Broken poms)

I reached out to jmeter-maven-plugin 3 month ago, and they did not seem to care: https://github.com/jmeter-maven-plugin/jmeter-maven-plugin/issues/339 Vladimir

Re: svn commit: r36676 - in /release/jmeter: binaries/ source/

I've added removeStaleArtifacts which is automatically run after publishing the release to /release/jmeter/... The task can be called manually: $ gw removeStaleArtifacts -PasfDryRun -Pjmeter.version=5.2 # keep 5.2 artifacts, and print the files to be removed $ gw removeStaleArtifacts -Pasf -Pjmete

Re: Version 5.2 (Broken poms)

As you know it’s oss, and we have to chose to which project we dedicate time. So maybe they had no slot at that time, they includes me :) And anyway the impact is not only for this project it’s for anybody using maven with jmeter 5.2 Regards On Saturday, November 9, 2019, Vladimir Sitnikov < sit

Re: Version 5.2 (Broken poms)

Hi Vladimir, I do take exception to the assertion that this is our fault. As noted in that ticket you raised, the build system should have no effect on us. It doesn’t matter if you build with Ant, Maven, or Gradle as long as you upload valid binaries and a correct POM to maven central. Second

Send raw results to InfluxDB?

Hi all Is it possible to send raw results to InfluxDB? When I've read the docs and looked at the current BackendListeners it seems we only send summary stats (despite summaryStats=false) I've created a PR which achieves largely what I expected the InfluxDB listner to do https://github.com/apache

Re: Send raw results to InfluxDB?

On Sat, Nov 9, 2019 at 1:28 PM Graham Russell wrote: > Hi all > > Is it possible to send raw results to InfluxDB? > > When I've read the docs and looked at the current BackendListeners it seems > we only send summary stats (despite summaryStats=false) > summary means in this context the total of

Re: svn commit: r36676 - in /release/jmeter: binaries/ source/

On Sat, 9 Nov 2019 at 11:15, Vladimir Sitnikov wrote: > > I've added removeStaleArtifacts which is automatically run after publishing > the release to /release/jmeter/... That is too soon. Should wait until mirrors have had a chance to catch up and the release is announced before removing old ver

Build failed in Jenkins: JMeter-trunk #7547

See Changes: [sitnikov.vladimir] rat-excludes.txt -> .ratignore -- [...truncated 87.00 KB...] > Task :src:testkit-wiremock:assemble UP-TO-DATE > Task :src:jorphan:spotbugsTes

Re: [jmeter] branch master updated: ApacheJMeter_config.jar: Restore bin folder and add missing files

+text("templates.xml") +text("*.jmx") Those files were not here. Are they required? What is the test case for the jar? Vladimir

Re: [jmeter] branch master updated: ApacheJMeter_config.jar: Restore bin folder and add missing files

The case is for jmeter maven plugin at least See this: https://github.com/jmeter-maven-plugin/jmeter-maven-plugin/issues/342 On Sat, Nov 9, 2019 at 2:33 PM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > +text("templates.xml") > +text("*.jmx") > >

Jenkins build is back to normal : JMeter-trunk #7548

See

Re: Git enable force push for master branches

Up. Any thoughts? This could have been prevented if force-push was enabled: https://github.com/apache/jmeter/commit/04aab12c68af8c57258c5ae905bd8b7ab0a2dd9f Vladimir

Re: Git enable force push for master branches

Am 9. November 2019 15:28:30 MEZ schrieb Vladimir Sitnikov : >Up. Any thoughts? > >This could have been prevented if force-push was enabled: >https://github.com/apache/jmeter/commit/04aab12c68af8c57258c5ae905bd8b7ab0a2dd9f I still think that it is better to have such commits in the history, th

Re: Git enable force push for master branches

>than to not know if it is the true history. It is "fun" how there were lots of objections re Ant->Gradle, and there were lots of objections re SVN->Gradle. It looks like it is the very same thing happening again. Can we just stop wasting time here and enable force pushes? We can always disable i

gw generatePom not generating pom files

Hello, gradle.md says: # Generate all pom files # The resulting files are placed under build/publications folder gw generatePom But I see nothing in build/publications Am I the only one in this case ? Thanks Regards

Re: gw generatePom not generating pom files

On Sat, 9 Nov 2019 at 16:19, Philippe Mouawad wrote: > Hello, > gradle.md says: > > # Generate all pom files > # The resulting files are placed under build/publications folder > gw generatePom > > But I see nothing in build/publications > > Am I the only one in this case ? > > N

Re: Version 5.2 (Broken poms)

Mark>Secondly we don’t use any local files, we pull binaries directly down from maven central using aether Mark>currently the plugin wouldn’t use them anyway Here you go: https://github.com/jmeter-maven-plugin/jmeter-maven-plugin/pull/345 The current error is "An error occurred: org/xmlpull/v1/Xm

Re: gw generatePom not generating pom files

Philippe>But I see nothing in build/publications Are you sure? $ cd src/core $ gw generatePom $ grep -B 3 -A 3 jorphan build/publications/core/pom-default.xml org.apache.jmeter jorphan 5.2.1-SNAPSHOT Vladimir

Re: gw generatePom not generating pom files

On Saturday, November 9, 2019, Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Philippe>But I see nothing in build/publications > > Are you sure? I run it from jmeter base folder. That’s the explanation. I thought running from there would generate for all projects > > $ cd src/core >

Re: Version 5.2 (Broken poms)

Vladimir>The current error Just to clarify: I believe https://github.com/apache/jmeter/commit/ef06709a780bc776ecc3b5d839c424d39bb1aeae fixes the poms, and the current jmeter/master is ok. Vladimir

Re: gw generatePom not generating pom files

>I thought running from there would generate for all projects Of course, it would. $ gw clean $ find . -name 'pom*.xml' | wc -l 0 $ gw generatePom -m ... :generatePom SKIPPED :src:components:generatePomFileForComponentsPublication SKIPPED :src:components:generatePom SKIPPED :src:config:gene

Re: [jmeter] branch master updated: build.gradle.kts in core, functions, components, protocol: Fix dependencies for pom generation and remove version

>Fix dependencies for pom generation and remove version Why are the dependencies added? They are not used by JMeter. Vladimir

Re: [jmeter] branch master updated: build.gradle.kts in core, functions, components, protocol: Fix dependencies for pom generation and remove version

On Sat, Nov 9, 2019 at 10:30 PM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > >Fix dependencies for pom generation and remove version > > Why are the dependencies added? > Which ones are not used ? They are not used by JMeter. > > Vladimir > -- Cordialement. Philippe Mouawad.

Re: [jmeter] branch master updated: build.gradle.kts in core, functions, components, protocol: Fix dependencies for pom generation and remove version

The ones that you've just added: +implementation("com.miglayout:miglayout-core") +implementation("com.miglayout:miglayout-swing") +implementation("org.ow2.asm:asm") +implementation("xalan:serializer:xalan") +implementation("xmlpull:xmlpull") +implementation("xpp3:xpp3_min")

Re: [jmeter] branch master updated: build.gradle.kts in core, functions, components, protocol: Fix dependencies for pom generation and remove version

Am I misunderstanding the purpose of this ? See below On Sat, Nov 9, 2019 at 10:34 PM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > The ones that you've just added: > +implementation("com.miglayout:miglayout-core") > Used by components in Thread Group UI no ? > +implementatio

Re: [jmeter] branch master updated: build.gradle.kts in core, functions, components, protocol: Fix dependencies for pom generation and remove version

>implementation("xpp3:xpp3_min") >Used by core for persisting This is very simple to check. xpp3_min-1.1.4c.jar jar contains only org/xmlpull/... classes. $ git grep xmlpull checksum.xml: gradle.properties:xmlpull.version=1.1.3.1 lib/aareadme.txt:xmlpull-1.1.3.1 lib/aareadme.txt:http://www.x

Re: [jmeter] branch master updated: build.gradle.kts in core, functions, components, protocol: Fix dependencies for pom generation and remove version

On Sat, Nov 9, 2019 at 10:45 PM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > >implementation("xpp3:xpp3_min") > >Used by core for persisting > > This is very simple to check. > xpp3_min-1.1.4c.jar jar contains only org/xmlpull/... classes. > > $ git grep xmlpull > checksum.xml: v

Re: [jmeter] branch master updated: build.gradle.kts in core, functions, components, protocol: Fix dependencies for pom generation and remove version

Also, check the 5.2 poms, nowhere httpclient is referenced for example while it should. So the commit is not incorrect. On Sat, Nov 9, 2019 at 10:50 PM Philippe Mouawad wrote: > > > On Sat, Nov 9, 2019 at 10:45 PM Vladimir Sitnikov < > sitnikov.vladi...@gmail.com> wrote: > >> >implementation("xp

Re: [jmeter] branch master updated: build.gradle.kts in core, functions, components, protocol: Fix dependencies for pom generation and remove version

>So the commit is not incorrect. Please revert. I'm 100% sure the commit is incorrect. It seems you are driven by "the failure of jmeter-maven-plugin". However, the failure is caused by j-m-p itself, and adding unused dependencies to JMeter is not the right way to workaround j-m-p issue. Vladimi

Re: [jmeter] branch master updated: build.gradle.kts in core, functions, components, protocol: Fix dependencies for pom generation and remove version

On Sat, Nov 9, 2019 at 10:55 PM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > >So the commit is not incorrect. > > Please revert. > I'm 100% sure the commit is incorrect. > AFAIK: - AbstractJMeterGuiComponent uses MigLayout - http modules requires HttpClient, it's not reference

Re: [jmeter] branch master updated: build.gradle.kts in core, functions, components, protocol: Fix dependencies for pom generation and remove version

>No, it's one of my concern but that's not what drives my commit. >The Pom are wrong and I am trying to fix it. That is fine. However, this time the fix is wrong, so I suggest to step back and revert it. >Can you explain instead of requesting revert ? Simple explanation: Gradle builds the code,

Re: [jmeter] branch master updated: build.gradle.kts in core, functions, components, protocol: Fix dependencies for pom generation and remove version

I still have 2 doubts: - For com.miglayout:miglayout-swing , isn't it missing ? - Is scope runtime in the poms correct ? On Sat, Nov 9, 2019 at 11:16 PM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > >No, it's one of my concern but that's not what drives my commit. > >The Pom

Re: [jmeter] branch master updated: build.gradle.kts in core, functions, components, protocol: Fix dependencies for pom generation and remove version

> For com.miglayout:miglayout-swing , isn't it missing ? It is declared in "core": https://github.com/apache/jmeter/blob/b0448c8cb3b70e7c3c58f84af926d0071a091f78/src/core/build.gradle.kts#L74 >- Is scope runtime in the poms correct ? It is Vladimir

Re: [jmeter] branch master updated: build.gradle.kts in core, functions, components, protocol: Fix dependencies for pom generation and remove version

1/ I reverted the ones that indeed look wrong. 2/ But I kept dec which is needed for http. On Sat, Nov 9, 2019 at 11:26 PM Philippe Mouawad wrote: > I still have 2 doubts: > >- For com.miglayout:miglayout-swing , isn't it missing ? >- Is scope runtime in the poms correct ? > > > > > On

Re: [jmeter] branch master updated: build.gradle.kts in core, functions, components, protocol: Fix dependencies for pom generation and remove version

>1/ I reverted the ones that indeed look wrong. Thanks >2/ But I kept dec which is needed for http. Do you mean org.brotli:dec ? It was there. Vladimir

Re: [jmeter] branch master updated: build.gradle.kts in core, functions, components, protocol: Fix dependencies for pom generation and remove version

On Sat, Nov 9, 2019 at 11:48 PM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > >1/ I reverted the ones that indeed look wrong. > > Thanks > > >2/ But I kept dec which is needed for http. > > Do you mean org.brotli:dec ? It was there. > I must be blind this evening. Where ? > > Vladimir

Re: [jmeter] branch master updated: build.gradle.kts in core, functions, components, protocol: Fix dependencies for pom generation and remove version

>Where ? https://github.com/apache/jmeter/blob/2cfdec9d50ddab4649b813c07724588a03371ef4/src/protocol/build.gradle.kts#L86 Vladimir

Re: [jmeter] branch master updated: build.gradle.kts in core, functions, components, protocol: Fix dependencies for pom generation and remove version

Oh, it's ok I didn't add it , I was just misreading diff. Since I had removed version , I thought I had added it. One last point (it's not my day, so let me *drink **th**e chalice till t* *he* *end*)* ,*for httpmime, if we don't add httpcore explicitely , version 4.4.10 will be used as it's the on