I see,
+1 for unifying the properties.
I don't quite like the naming of the fields:
String CIPHER_SUITE_LIST becomes String[] SUPPORTED_CIPHER_LIST after
split(" ").
The names are not that important as the fields are private (which is good),
however, it is really hard to follow which property
codecov-commenter edited a comment on pull request #660:
URL: https://github.com/apache/jmeter/pull/660#issuecomment-968444522
#
codecov-commenter edited a comment on pull request #660:
URL: https://github.com/apache/jmeter/pull/660#issuecomment-968444522
#
vlsi commented on a change in pull request #677:
URL: https://github.com/apache/jmeter/pull/677#discussion_r748907085
##
File path:
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/Proxy.java
##
@@ -89,6 +89,19 @@
private static final String
vlsi commented on a change in pull request #677:
URL: https://github.com/apache/jmeter/pull/677#discussion_r748906691
##
File path:
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/Proxy.java
##
@@ -89,6 +89,19 @@
private static final String
Hello,
https://github.com/apache/jmeter/pull/677
Regards
On Sun, Nov 14, 2021 at 11:13 AM Vladimir Sitnikov <
sitnikov.vladi...@gmail.com> wrote:
> Hi,
>
> I do not completely understand the use case, however, I support adding the
> common property names
> so different implementations could be
pmouawad opened a new pull request #677:
URL: https://github.com/apache/jmeter/pull/677
## Description
- Use https.cipherSuites property for HC4
- Use https.cipherSuites and https.socket.protocols in Proxy
## Motivation and Context
Clarification of use.
Allow fine
codecov-commenter edited a comment on pull request #674:
URL: https://github.com/apache/jmeter/pull/674#issuecomment-968265204
#
>What do you mean ?
https://www.jetbrains.com/help/idea/project-security.html#open_first_time
>Maybe you can share this configuration in the document.
I think we could even share the configuration via .idea/... file (see
Thanks for rapid answer.
My notes inline below.
On Sun, Nov 14, 2021 at 7:09 PM Vladimir Sitnikov <
sitnikov.vladi...@gmail.com> wrote:
> Philippe>1) Using IntelliJ IDEA 2021.2.3, I didn't get a popup to be able
> to select:
> Philippe> - Make sure Create separate module per source set is
Philippe>1) Using IntelliJ IDEA 2021.2.3, I didn't get a popup to be able
to select:
Philippe> - Make sure Create separate module per source set is selected
Philippe> - Make sure Use default gradle wrapper is selected
Those steps indeed seem obsolete. I think nowadays the only question it
Hello,
I have switched today to using IntelliJ as my future hopefully preferred
IDE for JMeter.
I followed below tutorial which is not up to date anymore I think:
-
https://github.com/apache/jmeter/blob/c7279348335b820c35ee570462cb2e0b4eb1c370/CONTRIBUTING.md
1) Using IntelliJ IDEA
Felix>So, in a sense, it is being used. (No idea, if it is useful enough.
Has
Felix>it done its purpose and reminded you to edit both files at once?)
I find the nagging useless since FILEVERSION is the **only** thing that
everybody changes
when adding a new sampler :-/
If other modifications are
Am 14.11.21 um 09:28 schrieb Vladimir Sitnikov:
> Hi,
>
> I see that TestSaveService > testFILEVERSION fails on every update of
> saveservice.properties.
> What is the purpose of testFILEVERSION?
I believe it is intended to nag the developers to keep the too files
SaveService.java and
codecov-commenter edited a comment on pull request #674:
URL: https://github.com/apache/jmeter/pull/674#issuecomment-968265204
#
codecov-commenter commented on pull request #674:
URL: https://github.com/apache/jmeter/pull/674#issuecomment-968265204
#
[Codecov](https://codecov.io/gh/apache/jmeter/pull/674?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
Upd:
I've added the relevant tests and CI now passes.
I've updated the build configuration, so the build now passes without
warnings with Gradle 7.3 and Java 17.
SecurityManager has been deprecated for removal, so we might need to drop
its use.
Vladimir
Hi,
I do not completely understand the use case, however, I support adding the
common property names
so different implementations could be configured in the same way.
So please file the PR with the property names and the supported values.
I don't understand what do you mean by
Hello,
I see few problems in this field in JMeter.
1) Cipher Suite is configurable through 2 properties:
Documented one called "https.cipherSuites" in HttpSSLProtocolSocketFactory
Undocumented one called "https.socket.ciphers" in
LazyLayeredConnectionSocketFactory
For HC4, the latter is the
Hi,
I see that TestSaveService > testFILEVERSION fails on every update of
saveservice.properties.
What is the purpose of testFILEVERSION?
I suggest we just remove SaveService#FILEVERSION field as it is not really
used.
The failure looks as follows:
FAILURE 0.0sec,
20 matches
Mail list logo
