[GitHub] [jmeter] pmouawad merged pull request #677: Align ssl props / Enable setting cipher suite (WIP)

2021-11-20 Thread GitBox
pmouawad merged pull request #677: URL: https://github.com/apache/jmeter/pull/677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

Re: JMeter DSL discussion

2021-11-20 Thread Vladimir Sitnikov
> How do you see the DSL for plugins ? The baseline is they would be able to integrate if they want. They would have to code their DSL in Kotlin though. >How will JSR223 custom code be used inside DSL ? Suggestions are welcome. Kotlin has raw literals (~multiline strings), so coding JSR223 as a

Re: About SSL properties in JMeter and their use in Java / HC Impl and Recorder

2021-11-20 Thread Vladimir Sitnikov
It is better now. Frankly speaking I do not know how to deal with separator, and with array vs List in the API. In most cases, Lists are more pleasant to work from Java. However, I would not die on that hill. Vladimir

[GitHub] [jmeter] vlsi commented on a change in pull request #677: Align ssl props / Enable setting cipher suite (WIP)

2021-11-20 Thread GitBox
vlsi commented on a change in pull request #677: URL: https://github.com/apache/jmeter/pull/677#discussion_r753699684 ## File path: src/core/src/main/java/org/apache/jmeter/util/JMeterUtils.java ## @@ -713,6 +714,27 @@ public static boolean getPropDefault(String propName, bool

Re: Build failed in Jenkins: JMeter » JMeter-trunk #332

2021-11-20 Thread Felix Schumacher
I have temporarily disabled the scm change trigger on that build, as it keeps getting started and fails. Felix Am 20.11.21 um 17:31 schrieb Felix Schumacher: > Infra says, that jenkins is currently being blocked from accessing > gitbox. I think the failed builds will be back to green, once that i

Build failed in Jenkins: JMeter » JMeter-trunk #343

2021-11-20 Thread Apache Jenkins Server
See Changes: -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building remotely on H29 (ubuntu) in workspace

Build failed in Jenkins: JMeter » JMeter-trunk #342

2021-11-20 Thread Apache Jenkins Server
See Changes: -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building remotely on H29 (ubuntu) in workspace

Build failed in Jenkins: JMeter » JMeter-trunk #341

2021-11-20 Thread Apache Jenkins Server
See Changes: -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building remotely on H29 (ubuntu) in workspace

Build failed in Jenkins: JMeter » JMeter-trunk #340

2021-11-20 Thread Apache Jenkins Server
See Changes: -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building remotely on H29 (ubuntu) in workspace

Build failed in Jenkins: JMeter » JMeter-trunk #339

2021-11-20 Thread Apache Jenkins Server
See Changes: -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building remotely on H29 (ubuntu) in workspace

Build failed in Jenkins: JMeter » JMeter-trunk #338

2021-11-20 Thread Apache Jenkins Server
See Changes: -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building remotely on H29 (ubuntu) in workspace

Build failed in Jenkins: JMeter » JMeter-trunk #337

2021-11-20 Thread Apache Jenkins Server
See Changes: -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building remotely on H29 (ubuntu) in workspace

Build failed in Jenkins: JMeter » JMeter-trunk #336

2021-11-20 Thread Apache Jenkins Server
See Changes: -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building remotely on H29 (ubuntu) in workspace

Build failed in Jenkins: JMeter » JMeter-trunk #335

2021-11-20 Thread Apache Jenkins Server
See Changes: -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building remotely on H29 (ubuntu) in workspace

Build failed in Jenkins: JMeter » JMeter-trunk #334

2021-11-20 Thread Apache Jenkins Server
See Changes: -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building remotely on H29 (ubuntu) in workspace

Build failed in Jenkins: JMeter » JMeter-trunk #333

2021-11-20 Thread Apache Jenkins Server
See Changes: -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building remotely on H29 (ubuntu) in workspace

Re: Build failed in Jenkins: JMeter » JMeter-trunk #332

2021-11-20 Thread Felix Schumacher
Infra says, that jenkins is currently being blocked from accessing gitbox. I think the failed builds will be back to green, once that issue has been solved. Felix Am 20.11.21 um 17:29 schrieb Apache Jenkins Server: > See >

Build failed in Jenkins: JMeter » JMeter-trunk #332

2021-11-20 Thread Apache Jenkins Server
See Changes: -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building remotely on H29 (ubuntu) in workspace

Build failed in Jenkins: JMeter » JMeter-trunk #331

2021-11-20 Thread Apache Jenkins Server
See Changes: -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building remotely on H29 (ubuntu) in workspace

Build failed in Jenkins: JMeter » JMeter-trunk #330

2021-11-20 Thread Apache Jenkins Server
See Changes: -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building remotely on H29 (ubuntu) in workspace

Build failed in Jenkins: JMeter » JMeter-trunk #329

2021-11-20 Thread Apache Jenkins Server
See Changes: -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building remotely on H29 (ubuntu) in workspace

Re: About SSL properties in JMeter and their use in Java / HC Impl and Recorder

2021-11-20 Thread Philippe Mouawad
Hello, I updated PR. Shall I merge it. Regards On Monday, November 15, 2021, Vladimir Sitnikov wrote: > I see, > > +1 for unifying the properties. > > I don't quite like the naming of the fields: > String CIPHER_SUITE_LIST becomes String[] SUPPORTED_CIPHER_LIST after > split(" "). > > The name

Build failed in Jenkins: JMeter » JMeter-trunk #328

2021-11-20 Thread Apache Jenkins Server
See Changes: -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building remotely on H29 (ubuntu) in workspace

Build failed in Jenkins: JMeter » JMeter-trunk #327

2021-11-20 Thread Apache Jenkins Server
See Changes: -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building remotely on H29 (ubuntu) in workspace

[GitHub] [jmeter] codecov-commenter commented on pull request #677: Align ssl props / Enable setting cipher suite (WIP)

2021-11-20 Thread GitBox
codecov-commenter commented on pull request #677: URL: https://github.com/apache/jmeter/pull/677#issuecomment-974664202 # [Codecov](https://codecov.io/gh/apache/jmeter/pull/677?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apach

Re: JMeter DSL discussion

2021-11-20 Thread Felix Schumacher
Am 20.11.21 um 14:28 schrieb Vladimir Sitnikov: >> The annotations could be used for scanning for TestPlan elements on > startup, too. > > I remember we have discussed it, however, it sounds like a different > feature. > Of course, some level of code generation might help, however, I have no use >

Re: JMeter DSL discussion

2021-11-20 Thread Philippe Mouawad
Hello, Few questions regarding the feature : - How do you see the DSL for plugins ? - How will JSR223 custom code be used inside DSL ? Also few notes inline below Regards On Saturday, November 20, 2021, Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > >The annotations could be used f

Re: JMeter DSL discussion

2021-11-20 Thread Vladimir Sitnikov
Vladimir> I've idea what would work the best to resolve it. Fix: I've *no* idea what would work :) Vladimir

Re: JMeter DSL discussion

2021-11-20 Thread Vladimir Sitnikov
>The annotations could be used for scanning for TestPlan elements on startup, too. I remember we have discussed it, however, it sounds like a different feature. Of course, some level of code generation might help, however, I have no use cases for it now. >Maybe start with a global org.apache.jmet

Re: JMeter DSL discussion

2021-11-20 Thread Felix Schumacher
Am 20.11.21 um 12:46 schrieb Vladimir Sitnikov: >> Do you have a rough idea, what the dsl would look like, or how the >> elements get mapped/detected to be a part of the dsl? > Commonly used elements have to be mapped manually for consistency reasons. > There might be a generic (string-like) appro

Re: JMeter DSL discussion

2021-11-20 Thread Vladimir Sitnikov
>Do you have a rough idea, what the dsl would look like, or how the >elements get mapped/detected to be a part of the dsl? Commonly used elements have to be mapped manually for consistency reasons. There might be a generic (string-like) approach to allow fine-tuning. >Could you elaborate a bit mo

Re: JMeter DSL discussion

2021-11-20 Thread Felix Schumacher
Am 20.11.21 um 10:20 schrieb Vladimir Sitnikov: >> I think it's important to slowly isolate the Jmeter core from GUI, > If anybody wants to contribute that, please do so. > > Antonio>I think it's a good idea to add DSL in core is a good idea > > The immediate question is do we put classes for DSL

Re: JMeter DSL discussion

2021-11-20 Thread Vladimir Sitnikov
>I think it's important to slowly isolate the Jmeter core from GUI, If anybody wants to contribute that, please do so. Antonio>I think it's a good idea to add DSL in core is a good idea The immediate question is do we put classes for DSL right into the current ApacheJMeter_core, ApacheJMeter_htt