Re: JMeter DSL discussion

2023-06-06 Thread Vladimir Sitnikov
I've been improving tests, and I realized there's a small change that brings a decent way to build test plans. I've updated PR https://github.com/apache/jmeter/pull/678 The PR includes samples for both Kotlin and Java (see OpenModelThreadGroupConfigElementTest and OpenModelThreadGroupConfigElement

[GitHub] [jmeter] vlsi closed pull request #5973: feat: add DSL for programmatic test plan creation

2023-06-06 Thread via GitHub
vlsi closed pull request #5973: feat: add DSL for programmatic test plan creation URL: https://github.com/apache/jmeter/pull/5973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [jmeter] vlsi commented on pull request #5973: feat: add DSL for programmatic test plan creation

2023-06-06 Thread via GitHub
vlsi commented on PR #5973: URL: https://github.com/apache/jmeter/pull/5973#issuecomment-1579359884 Will proceed in https://github.com/apache/jmeter/pull/678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: Need help to a PR

2023-06-06 Thread Vladimir Sitnikov
> DO I need to add a checksum? That is right, we require dependency verification. Here's a sample when I recently added a new dependency: https://github.com/apache/jmeter/commit/a2690e8a6d22420869eb89643c116901cc5c5bce Note that there were changes to checksum.xml, and the new pgp keys have been

Re: Need help to a PR

2023-06-06 Thread Antonio Gomes Rodrigues
Hi Vladimir, Thanks to you quick response What do you mean by " it might be better to add src/har-importer module rather than put it into src/core" I have try your first solution without success I have this error FAILURE: Build failed with an exception. * What went wrong: Could not determine t

Re: Need help to a PR

2023-06-06 Thread Vladimir Sitnikov
> I have added api("com.github.sdstoehr:har-reader:2.2.1") in src/bom-thirdparty/build.gradle.kts That’s right. You declare version in bom-thirdparty, and then you add a dependency without version. For instance, add implementation(“ com.github.sdstoehr:har-reader”) to src/core/build.gradle.kts. H

Need help to a PR

2023-06-06 Thread Antonio Gomes Rodrigues
Hi all, I have some time to work again in JMeter, unfortunately I haven't made code for a long time. It's why I need help I would like to add feature to import HAR file to gain productivity in scripting step. I have checked and it will not be too difficult by using lib like https://github.com/sd

[GitHub] [jmeter] vlsi opened a new pull request, #5973: feat: add DSL for programmatic test plan creation

2023-06-06 Thread via GitHub
vlsi opened a new pull request, #5973: URL: https://github.com/apache/jmeter/pull/5973 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jmeter] nagkumar commented on issue #5957: JUnit Sampler to support JUnit 5 Test Cases or JUnit 5 @Suite test cases

2023-06-06 Thread via GitHub
nagkumar commented on issue #5957: URL: https://github.com/apache/jmeter/issues/5957#issuecomment-1579010544 Another Observation is JUnitSampler is optionally measuring only test method time and not setup and teardown methods, that is a misleading info, as these two are part of test executi

[GitHub] [jmeter] nagkumar commented on issue #5957: JUnit Sampler to support JUnit 5 Test Cases or JUnit 5 @Suite test cases

2023-06-06 Thread via GitHub
nagkumar commented on issue #5957: URL: https://github.com/apache/jmeter/issues/5957#issuecomment-1578997121 Further study of JUnitSampler, which of these properties are to be supported.. ``` private static final String CLASSNAME = "junitSampler.classname"; private

[GitHub] [jmeter] pmouawad commented on issue #5804: BackendListener cannot have the same name

2023-06-06 Thread via GitHub
pmouawad commented on issue #5804: URL: https://github.com/apache/jmeter/issues/5804#issuecomment-1578713074 Hello @vlsi, yes your understanding is correct. I think it is needed, as some implementations send percentiles, would they be meaningful if every agent sends a value based on its s

Jenkins build is back to normal : JMeter » JMeter-trunk #639

2023-06-06 Thread Apache Jenkins Server
See

[GitHub] [jmeter] vlsi merged pull request #5972: chore: bump vlsi-release-plugins to 1.89

2023-06-06 Thread via GitHub
vlsi merged PR #5972: URL: https://github.com/apache/jmeter/pull/5972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

[GitHub] [jmeter] vlsi commented on issue #5804: BackendListener cannot have the same name

2023-06-06 Thread via GitHub
vlsi commented on issue #5804: URL: https://github.com/apache/jmeter/issues/5804#issuecomment-1578371291 @pmouawad , I see `BackendListener implements Remoteable`. If I understand correctly, it means that in the distributed scenario, the agents would collect and pass the samples to the cont

[GitHub] [jmeter] vlsi commented on pull request #5900: Bugfix: User Defined Variables are not evaluated on client (master) i…

2023-06-06 Thread via GitHub
vlsi commented on PR #5900: URL: https://github.com/apache/jmeter/pull/5900#issuecomment-1578361550 > hard to write tests for a pretty simple fix without any other tests doing some basic stuff like creating the TestTree from scratch. Please check https://github.com/apache/jmeter/blob

[GitHub] [jmeter] vlsi opened a new pull request, #5972: chore: bump vlsi-release-plugins to 1.89

2023-06-06 Thread via GitHub
vlsi opened a new pull request, #5972: URL: https://github.com/apache/jmeter/pull/5972 It should reduce the number of created threads, and it should resolve UnsupportedOperationException when filesystem contains inaccessible files. -- This is an automated message from the Apache Git S

[GitHub] [jmeter] vlsi commented on pull request #679: Add variable support for Include Controller

2023-06-06 Thread via GitHub
vlsi commented on PR #679: URL: https://github.com/apache/jmeter/pull/679#issuecomment-1578313960 @ClemRz , could you please clarify your use case in more detail? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [jmeter] ClemRz commented on pull request #679: Add variable support for Include Controller

2023-06-06 Thread via GitHub
ClemRz commented on PR #679: URL: https://github.com/apache/jmeter/pull/679#issuecomment-1578290338 Hi, I see this PR is still open. It is from 2021. Is there any reason this didn't make it into master? I badly need this feature. Thx -- This is an automated message from the A

[GitHub] [jmeter] vlsi commented on pull request #5963: Extras/format converters

2023-06-06 Thread via GitHub
vlsi commented on PR #5963: URL: https://github.com/apache/jmeter/pull/5963#issuecomment-1578238102 I'm not sure we need to co-locate everything under the same directory when storing the files in Git though. My suggestion was to use the same bundler/dependencies/testing for both tasks.

[GitHub] [jmeter] pmirek commented on pull request #5963: Extras/format converters

2023-06-06 Thread via GitHub
pmirek commented on PR #5963: URL: https://github.com/apache/jmeter/pull/5963#issuecomment-1578196324 Let me check on possibilities, I probably won't go for re-typing to .ts due to lack of time, but I'll add something for testing of .js (command line based) Combining html/js parts may be

Build failed in Jenkins: JMeter » JMeter-trunk #638

2023-06-06 Thread Apache Jenkins Server
See Changes: [Vladimir Sitnikov] feat: Add API to declare TestElement schemas [Vladimir Sitnikov] feat: introduce PropertyTransformer interface instead of ValueTransformer [Vladimir Sitnikov] feat: En

[GitHub] [jmeter] vlsi merged pull request #5944: feat: Enable usage of ${...} expressions for checkbox controls

2023-06-06 Thread via GitHub
vlsi merged PR #5944: URL: https://github.com/apache/jmeter/pull/5944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

[GitHub] [jmeter] vlsi closed issue #1252: There is no good way to set checkbox based items using global variable.

2023-06-06 Thread via GitHub
vlsi closed issue #1252: There is no good way to set checkbox based items using global variable. URL: https://github.com/apache/jmeter/issues/1252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the