Want to help with migrating from Apache LogKit to SLF4J

2017-01-02 Thread Woonsan Ko
Hi, I'd like to help with migrating from Apache LogKit to SLF4J [1], and so I've been reading the current logging implementation with logkit, avalon-framework and excalibur-logger. >From my understanding, maybe we can take the following approach: - Since SLF4J API doesn't provide a logging implem

Re: Want to help with migrating from Apache LogKit to SLF4J

2017-01-03 Thread Woonsan Ko
On Tue, Jan 3, 2017 at 2:32 PM, Felix Schumacher wrote: > Am 02.01.2017 um 21:31 schrieb Philippe Mouawad: >> >> On Monday, January 2, 2017, Woonsan Ko wrote: >> >>> Hi, >>> >>> I'd like to help with migrating from Apache LogKit to SLF4J

Re: Want to help with migrating from Apache LogKit to SLF4J

2017-01-09 Thread Woonsan Ko
On Fri, Jan 6, 2017 at 3:23 PM, Philippe Mouawad wrote: > On Wednesday, January 4, 2017, sebb wrote: > >> On 3 January 2017 at 20:59, Woonsan Ko > >> wrote: >> > On Tue, Jan 3, 2017 at 2:32 PM, Felix Schumacher >> > > wrote: >> >> Am 02.01.20

Re: Want to help with migrating from Apache LogKit to SLF4J

2017-01-15 Thread Woonsan Ko
On Mon, Jan 9, 2017 at 1:29 PM, Woonsan Ko wrote: > On Fri, Jan 6, 2017 at 3:23 PM, Philippe Mouawad > wrote: >> On Wednesday, January 4, 2017, sebb wrote: >> >>> On 3 January 2017 at 20:59, Woonsan Ko > >>> wrote: >>> > On Tue, Jan 3, 2017 at

Re: Migration to SLF4J

2017-02-06 Thread Woonsan Ko
Hi, I've just searched 'LoggingManager.getLogger' in *.java files in the latest trunk: components 72 core 116 function 2 protocol 4 test 12 So, it's not that many. Thanks a lot for your work, Philippe! I can provide 3 pull requests: one for components, second for core and third for the rest if t

Re: Migration to Slf4j and backward compatibility policy

2017-02-10 Thread Woonsan Ko
On Fri, Feb 10, 2017 at 1:52 AM, Philippe Mouawad wrote: > Hello, > In the process of migrating, there are 2 places where we face the backward > compatibility issue: > - AbstractJavaSamplerClient#getLogger > - Dynamic scripting elements (Jsr223, Bsf and Beanshell) > > For the first case I think we

Re: Dropping LogKit in favor of Apache Log4J2 or SLF4J+ Logback orCommons-Logging

2017-02-12 Thread Woonsan Ko
t initiative! Good to hear that project is migrating towards modern > libraries. > > Andrey Pokhilko > > On 11.02.2017 11:38, Philippe Mouawad wrote: >> Hello, >> I'm happy to announce that thanks to the huge work of Woonsan Ko, we've now >> completed the mi

Re: Proposition for contribution

2017-02-16 Thread Woonsan Ko
Hi folks, Is there anyone working in unit tests for JDBC protocol? If not, I'd like to take a look into it next week. Cheers, Woonsan On Fri, Jan 6, 2017 at 2:35 PM, Philippe Mouawad wrote: > Hello, > Thanks for your proposal. > Yes it is still up to date. > > You can have a look at our Sonar

Re: svn commit: r1784829 - in /jmeter/trunk: extras/remote.bsh xdocs/usermanual/best-practices.xml

2017-02-28 Thread Woonsan Ko
On Tue, Feb 28, 2017 at 6:16 PM, sebb wrote: > On 28 February 2017 at 22:39, wrote: >> Author: pmouawad >> Date: Tue Feb 28 22:39:25 2017 >> New Revision: 1784829 >> >> URL: http://svn.apache.org/viewvc?rev=1784829&view=rev >> Log: >> Remove log_level occurences >> >> Modified: >> jmeter/tru

Re: Release a 3.2

2017-03-24 Thread Woonsan Ko
On Mon, Mar 20, 2017 at 7:05 PM, sebb wrote: > On 20 March 2017 at 22:57, Philippe Mouawad > wrote: >> On Monday, March 20, 2017, sebb wrote: >> >>> I know I keep going on about this, but the logging documentation still >>> needs some work. >>> >>> The logging level names have changed. >>> User

Re: Release a 3.2

2017-03-25 Thread Woonsan Ko
On Fri, Mar 24, 2017 at 10:39 AM, Woonsan Ko wrote: > On Mon, Mar 20, 2017 at 7:05 PM, sebb wrote: >> On 20 March 2017 at 22:57, Philippe Mouawad >> wrote: >>> On Monday, March 20, 2017, sebb wrote: >>> >>>> I know I keep going on about this, b

Re: Migrating build system to Gradle

2019-02-23 Thread Woonsan Ko
On Sat, Feb 23, 2019 at 11:49 AM Philippe Mouawad wrote: > > On Sat, Feb 23, 2019 at 5:24 PM Graham Russell wrote: > > > Sebb: > > I will try again on a new VM and write them up, perhaps on Monday. > > > > I doubt it would have done it automatically, but it probably would > > have been quicker to

Re: Migrating build system to Gradle

2019-02-23 Thread Woonsan Ko
On Sat, Feb 23, 2019 at 12:05 PM Woonsan Ko wrote: > > On Sat, Feb 23, 2019 at 11:49 AM Philippe Mouawad > wrote: > > > > On Sat, Feb 23, 2019 at 5:24 PM Graham Russell wrote: > > > > > Sebb: > > > I will try again on a new VM and write them up, pe

Re: Migrating build system to Gradle

2019-02-25 Thread Woonsan Ko
On Mon, Feb 25, 2019 at 6:21 AM Vladimir Sitnikov wrote: > > sebb> Is is absolutely necessary to move the files around? > > 1) What's wrong with moving files? > > 2) What's your suggestion? > How are you going to co-locate runtime and test classes yet use > current core/org/apache/jmeter folder st

GraphQL sampler?

2020-09-18 Thread Woonsan Ko
Hi, I have used HTTP Request sampler for GraphQL testing with setting request body with escaped json strings like this: {"operationName":null,"variables":{},"query":"{\n fineSomethings(text: \"\", offset: 0, limit: 200) {\n offset\n limit\n count\n total\n items {\n ... }\n }\n }\n }\n}\n"} It i

Re: GraphQL sampler?

2020-09-18 Thread Woonsan Ko
ntroducing any new dependency. Please share your insights otherwise. Cheers, Woonsan > > > Regards > > On Fri, Sep 18, 2020 at 1:15 PM Woonsan Ko wrote: > > > Hi, > > > > I have used HTTP Request sampler for GraphQL testing with setting > > request body

Re: GraphQL sampler?

2020-09-20 Thread Woonsan Ko
On Fri, Sep 18, 2020 at 4:02 PM Philippe Mouawad wrote: > > On Fri, Sep 18, 2020 at 4:39 PM Woonsan Ko wrote: > > > Hello Philippe, > > > > On Fri, Sep 18, 2020 at 7:20 AM Philippe Mouawad > > wrote: > > > > > > Hello Woonsan, > >

Re: GraphQL sampler?

2020-09-26 Thread Woonsan Ko
Hello, I've submitted a PR: https://github.com/apache/jmeter/pull/627 Please take a look. Thanks in advance, Woonsan On Sun, Sep 20, 2020 at 5:14 PM Woonsan Ko wrote: > > On Fri, Sep 18, 2020 at 4:02 PM Philippe Mouawad > wrote: > > > > On Fri, Sep 18, 2020 at

Re: [VOTE] Release JMeter 5.4 RC2

2020-11-30 Thread Woonsan Ko
+1 (non-binding with my supports and thanks) Woonsan On Sun, Nov 29, 2020 at 11:55 AM Milamber wrote: > > Hello, > > The second release candidate for JMeter 5.4 (079404a06a) has been > prepared, and your votes are solicited. > > This release brings some new features and improvements, and also fi