[GitHub] jmeter issue #390: Update mongo-java-driver version

2018-06-30 Thread undera
Github user undera commented on the issue: https://github.com/apache/jmeter/pull/390 Maybe revive old idea of extracting MongoDB components into external plugin? Custom plugin detaches version from core JMeter, which means some users can use older version of plugin, while rest

[GitHub] jmeter pull request #378: Fix 43612

2018-03-20 Thread undera
Github user undera commented on a diff in the pull request: https://github.com/apache/jmeter/pull/378#discussion_r175759441 --- Diff: src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java --- @@ -1649,6 +1648,43 @@ else if(getSendParameterValuesAsPostBody

[GitHub] jmeter issue #300: Bug 57039 - Inconsistency with the undo/redo log

2017-07-29 Thread undera
Github user undera commented on the issue: https://github.com/apache/jmeter/pull/300 IMO it is better to merge it even before 3.3. It will not do much harm because most of users have the feature disabled by default. Merging would simplify further reviews and improvements, I'd favor

[GitHub] jmeter issue #300: Bug 57039 - Inconsistency with the undo/redo log

2017-07-23 Thread undera
Github user undera commented on the issue: https://github.com/apache/jmeter/pull/300 If undo/redo is going to be fixed, can we consider re-enabling it by default through default properties? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] jmeter issue #300: Bug 57039 - Inconsistency with the undo/redo log

2017-07-23 Thread undera
Github user undera commented on the issue: https://github.com/apache/jmeter/pull/300 Amazing initiative! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] jmeter issue #298: Vary header cache

2017-06-29 Thread undera
Github user undera commented on the issue: https://github.com/apache/jmeter/pull/298 Great progress, Felix! Now we need to test it against real websites with Vary header, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] jmeter pull request #298: Vary header cache

2017-06-19 Thread undera
Github user undera commented on a diff in the pull request: https://github.com/apache/jmeter/pull/298#discussion_r122796806 --- Diff: src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPJavaImpl.java --- @@ -626,6 +627,19 @@ protected HTTPSampleResult sample(URL url

[GitHub] jmeter pull request #298: Vary header cache

2017-06-19 Thread undera
Github user undera commented on a diff in the pull request: https://github.com/apache/jmeter/pull/298#discussion_r122796161 --- Diff: src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java --- @@ -152,22 +197,18 @@ private boolean hasVaryHeader(URLConnection

[GitHub] jmeter pull request #291: Add time shifting function

2017-04-26 Thread undera
Github user undera commented on a diff in the pull request: https://github.com/apache/jmeter/pull/291#discussion_r113537870 --- Diff: src/functions/org/apache/jmeter/functions/TimeShiftingFunction.java --- @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software

[GitHub] jmeter pull request: Separate thirdparty dirs

2016-04-08 Thread undera
Github user undera closed the pull request at: https://github.com/apache/jmeter/pull/181 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] jmeter pull request: Separate thirdparty dirs

2016-04-04 Thread undera
Github user undera commented on the pull request: https://github.com/apache/jmeter/pull/181#issuecomment-205281826 The git commits won't go into SVN anyway, but I'll try to rebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] jmeter pull request: Separate thirdparty dirs

2016-04-04 Thread undera
GitHub user undera reopened a pull request: https://github.com/apache/jmeter/pull/181 Separate thirdparty dirs You can merge this pull request into a Git repository by running: $ git pull https://github.com/Blazemeter/jmeter separate-thirdparty-dirs Alternatively you can

[GitHub] jmeter pull request: Separate thirdparty dirs

2016-04-04 Thread undera
Github user undera closed the pull request at: https://github.com/apache/jmeter/pull/181 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] jmeter pull request: Separate thirdparty dirs

2016-04-04 Thread undera
GitHub user undera opened a pull request: https://github.com/apache/jmeter/pull/181 Separate thirdparty dirs You can merge this pull request into a Git repository by running: $ git pull https://github.com/Blazemeter/jmeter separate-thirdparty-dirs Alternatively you can

[GitHub] jmeter pull request: Hotkeys to add elements

2015-06-03 Thread undera
Github user undera closed the pull request at: https://github.com/apache/jmeter/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] jmeter pull request: Hotkeys to add elements

2015-06-03 Thread undera
Github user undera commented on the pull request: https://github.com/apache/jmeter/pull/16#issuecomment-108307822 https://bz.apache.org/bugzilla/show_bug.cgi?id=57988 committed in --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] jmeter pull request: Use FileServer in HTTP Request files

2015-06-03 Thread undera
Github user undera closed the pull request at: https://github.com/apache/jmeter/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] jmeter pull request: Use FileServer in HTTP Request files

2015-06-03 Thread undera
Github user undera commented on the pull request: https://github.com/apache/jmeter/pull/23#issuecomment-108417526 Committed revision 1683328 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] jmeter pull request: Use FileServer in HTTP Request files

2015-06-02 Thread undera
Github user undera commented on the pull request: https://github.com/apache/jmeter/pull/22#issuecomment-107948802 Occasional changes get into, closing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] jmeter pull request: Use FileServer in HTTP Request files

2015-06-02 Thread undera
Github user undera closed the pull request at: https://github.com/apache/jmeter/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] jmeter pull request: Use FileServer in HTTP Request files

2015-06-02 Thread undera
GitHub user undera opened a pull request: https://github.com/apache/jmeter/pull/23 Use FileServer in HTTP Request files You can merge this pull request into a Git repository by running: $ git pull https://github.com/Blazemeter/jmeter fileserver-in-httprequest Alternatively

[GitHub] jmeter pull request: Use FileServer in HTTP Request files

2015-06-02 Thread undera
GitHub user undera opened a pull request: https://github.com/apache/jmeter/pull/22 Use FileServer in HTTP Request files You can merge this pull request into a Git repository by running: $ git pull https://github.com/Blazemeter/jmeter http-sampler-fileserver Alternatively you

[GitHub] jmeter pull request: Hotkeys to add elements

2015-04-20 Thread undera
GitHub user undera opened a pull request: https://github.com/apache/jmeter/pull/16 Hotkeys to add elements This feature allows configuring elements to be inserted with keys Ctrl+0 .. Ctrl+9. This makes scripting faster. You can merge this pull request into a Git repository

[GitHub] jmeter pull request: Rmi retry

2015-01-30 Thread undera
Github user undera closed the pull request at: https://github.com/apache/jmeter/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] jmeter pull request: Rmi retry

2015-01-26 Thread undera
GitHub user undera opened a pull request: https://github.com/apache/jmeter/pull/13 Rmi retry You can merge this pull request into a Git repository by running: $ git pull https://github.com/Blazemeter/jmeter rmi-retry Alternatively you can review and apply these changes

[GitHub] jmeter pull request: Introduce connect time into SampleResult

2015-01-26 Thread undera
Github user undera closed the pull request at: https://github.com/apache/jmeter/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] jmeter pull request: Introduce connect time into SampleResult

2014-12-03 Thread undera
GitHub user undera opened a pull request: https://github.com/apache/jmeter/pull/11 Introduce connect time into SampleResult You can merge this pull request into a Git repository by running: $ git pull https://github.com/Blazemeter/jmeter connect-times Alternatively you can