Github user max3163 commented on the issue:
https://github.com/apache/jmeter/pull/291
Close with commit r1794517 :
http://svn.apache.org/viewvc?rev=1794517=rev
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/291
Hello,
Regarding format, for maintainability and documentation, using Java8
Duration is better IMO.
Regards
---
If your project is set up for it, you can reply to this email and have
Github user max3163 commented on the issue:
https://github.com/apache/jmeter/pull/291
I found the format more complex and you can't add month.
But it's more java native like my implementation.
What do you prefer ?
---
If your project is set up for it, you can reply to this
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/291
You might want to look at `Duration#parse(CharSequence)`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user max3163 commented on the issue:
https://github.com/apache/jmeter/pull/291
I took into account all yours feedbacks, so please can you review new
commits ?
I add a new library ( hamcrest-date ) to easily check date.
---
If your project is set up for it, you can reply
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/291
Thanks for the changes. Looks good to me for commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/291
Hello,
Looks good to me (see my comments), very good idea !
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
