Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/298
Hi Felix,
I suggest you commit the PR so that we can update and test code more easily.
Thanks
Regards
---
If your project is set up for it, you can reply to this email and have
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/298
Hi Felix,
Looks good to me.
I'd just change a bit in HTTPJavaImpl#getHeaders(HeaderManager
headerManager) to:
`private Header[] getHeaders(HeaderManager headerManager) {
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/298
Great @FSchumacher !
Thanks for your work !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/298
I think this feature can be tested now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/298
@undera there are still a few tests missing, mainly the ones for vary
headers for multiple and different headers. But you are welcome to give this
some testing on real sites.
@pmouawad
Github user undera commented on the issue:
https://github.com/apache/jmeter/pull/298
Great progress, Felix!
Now we need to test it against real websites with Vary header, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/298
Thanks Felix for PR.
I reviewed it, it looks good to me.
Maybe since we're making API modifications we should start thinking about:
- https://bz.apache.org/bugzilla/show_bug.cgi?id=53540
