[GitHub] jmeter issue #345: Checkstyle

2017-12-06 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/345 Hi team, anybody wants to merge this one ? if not I’ll do it this week-end. Thanks ---

[GitHub] jmeter issue #345: Checkstyle

2017-12-04 Thread romani
Github user romani commented on the issue: https://github.com/apache/jmeter/pull/345 if master branch of this project (jmeter) start to use about 80 Checks in its config with ERROR severity and no violations reported, we can start to use jmeter in out CI for regression testing.

[GitHub] jmeter issue #345: Checkstyle

2017-11-30 Thread ham1
Github user ham1 commented on the issue: https://github.com/apache/jmeter/pull/345 @romani, sorry I'm not clear on what, if anything, you'd want me to do/change? ---

[GitHub] jmeter issue #345: Checkstyle

2017-11-30 Thread romani
Github user romani commented on the issue: https://github.com/apache/jmeter/pull/345 @ham1 , if you enforce(ERROR level) more than half of Checks on this project, we can use jmeter project in each commit (in checkstyle) regression testing. ---

[GitHub] jmeter issue #345: Checkstyle

2017-11-30 Thread ham1
Github user ham1 commented on the issue: https://github.com/apache/jmeter/pull/345 Yes, that's correct, I some how missed it in the docs. I've suggested on https://github.com/checkstyle/checkstyle/issues/5305 that the error message is changed to something like: `"Return

[GitHub] jmeter issue #345: Checkstyle

2017-11-30 Thread romani
Github user romani commented on the issue: https://github.com/apache/jmeter/pull/345 Looks like a reason was in `maxForVoid` with default value., Right ? ---

[GitHub] jmeter issue #345: Checkstyle

2017-11-30 Thread ham1
Github user ham1 commented on the issue: https://github.com/apache/jmeter/pull/345 @romani it's commented out to stop this PR failing but where you see it commented out was where I had: ``` ``` ---

[GitHub] jmeter issue #345: Checkstyle

2017-11-29 Thread romani
Github user romani commented on the issue: https://github.com/apache/jmeter/pull/345 @ham1 , ReturnCount check is commented out. Please point me to place where you configure it. ---

[GitHub] jmeter issue #345: Checkstyle

2017-11-29 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/jmeter/pull/345 # [Codecov](https://codecov.io/gh/apache/jmeter/pull/345?src=pr=h1) Report > Merging [#345](https://codecov.io/gh/apache/jmeter/pull/345?src=pr=desc) into