[GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/167 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Thank a lot Cet e-mail a été envoyé depuis un ordinateur protégé par Avast. www.avast.com <#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2> 2016-04-01 10:22 GMT+02:00 Vladimir Sitnikov : > > Can y

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

> Can you merge it in few days if there are no news from other commiter? sure. Vladimir

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Hi Vladimir, Thank to your quick feed back Can you merge it in few days if there are no news from other commiter? Antonio Cet e-mail a été envoyé depuis un ordinateur protégé par Avast. www.avast.com

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Antonio, thanks for your patience. The change looks good to me. Vladimir

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Hi Vladimir and Sebb, Do you think you can take some time to review my PR and merge it if it's ok or said to me how to ameliorate it to be merged? Thank Antonio 2016-03-25 12:14 GMT+01:00 Antonio Gomes Rodrigues : > Hi all, > > Anybody have the time to review it and merge it if it's ok? > If yo

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Hi all, Anybody have the time to review it and merge it if it's ok? If you think I need more work on this PR, I can do it Thank Antonio 2016-03-22 16:24 GMT+01:00 Antonio Gomes Rodrigues : > Hi all, > > I would like to add new enhancements to CSV Data Set with new PR > > For this PR, is it ok o

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Hi all, I would like to add new enhancements to CSV Data Set with new PR For this PR, is it ok or I need rework it to be integrated? Thank Antonio 2016-03-19 9:30 GMT+01:00 Antonio Gomes Rodrigues : > Hi all, > > Do I need to modify something to allow the PR be accepted? > > Thank > Antonio >

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Hi, New commit with formating and swap else branch Antonio Cet e-mail a été envoyé depuis un ordinateur protégé par Avast. www.avast.com <#DDB4FAA8-2DD7

[GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Github user vlsi commented on a diff in the pull request: https://github.com/apache/jmeter/pull/167#discussion_r56486961 --- Diff: src/core/org/apache/jmeter/services/FileServer.java --- @@ -428,7 +431,7 @@ private BufferedReader createBufferedReader(FileEntry fileEntry) throws IOE

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Hi, Modification made and new commit provided Do we have a checkstyle configuration or something like that to avoid waste time (your time and mine) in how to code to JMeter? Antonio Cet e-mail a été envoyé depuis un ordinateur protégé par Avast. www.avast.com

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Antonio>Do we have a checkstyle configuration or something like that to avoid waste Antonio>time (your time and mine) in how to code to JMeter? There's a checkstyle (it is run as a part of Travis job), however it would never check 100% of the issues. My "else branch swap" request was just to make

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Hi, Unitary tests fixed Antonio Cet e-mail a été envoyé depuis un ordinateur protégé par Avast. www.avast.com <#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2> 2016-03-1

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Hi, Thanks to the feedback check exists() is not necessary canRead public boolean canRead() Tests whether the application can read the file denoted by this abstract pathname. Returns:true if and only if the file specified by this abstract pathname exists *and* can be read by the application; f

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

On 17 March 2016 at 07:39, vlsi wrote: > Github user vlsi commented on a diff in the pull request: > > https://github.com/apache/jmeter/pull/167#discussion_r56465359 > > --- Diff: src/core/org/apache/jmeter/services/FileServer.java --- > @@ -418,16 +418,20 @@ private BufferedReader get

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

I will fix the unit test asap Can you provide the checkstyle configuration to run it in local before commit the change? Antonio Cet e-mail a été envoyé depuis un ordinateur protégé par Avast. www.avast.com

[GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Github user ra0077 commented on the pull request: https://github.com/apache/jmeter/pull/167#issuecomment-197735103 New commit with formating and swap else branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Hi all, Do I need to modify something to allow the PR be accepted? Thank Antonio 2016-03-17 14:45 GMT+01:00 Antonio Gomes Rodrigues : > Hi, > > Unitary tests fixed > > Antonio > > Cet e-mail a été envoyé depuis un ordinateur protégé par Avast. > www.avast.com >

[GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Github user vlsi commented on a diff in the pull request: https://github.com/apache/jmeter/pull/167#discussion_r56465359 --- Diff: src/core/org/apache/jmeter/services/FileServer.java --- @@ -418,16 +418,20 @@ private BufferedReader getReader(String alias, boolean recycle, boolean f

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

On 17 March 2016 at 11:20, Antonio Gomes Rodrigues wrote: > I will fix the unit test asap > > Can you provide the checkstyle configuration to run it in local before > commit the change? It's in SVN. But as already noted it does not catch everything. The best is to follow the layout convention f

[GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Github user ra0077 commented on the pull request: https://github.com/apache/jmeter/pull/167#issuecomment-196829738 Ok I will wait other review or a go before modify my PR to avoid problem like in my previous PR about this bug Antonio --- If your project is set up fo

[GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Github user vlsi commented on a diff in the pull request: https://github.com/apache/jmeter/pull/167#discussion_r56164700 --- Diff: src/core/org/apache/jmeter/services/FileServer.java --- @@ -428,6 +429,9 @@ private BufferedReader createBufferedReader(FileEntry fileEntry) throws IOE

[GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/167 bug59153_CSVDataSetFilesExceptions More clear message for CSV Data Set with filename empty wrong filename (not readable, not exist) I don't have made formating to help reviewing