Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/298
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/298#discussion_r125741694
--- Diff:
src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPJavaImpl.java ---
@@ -626,6 +627,19 @@ protected HTTPSampleResult sample(URL url,
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/298#discussion_r123043982
--- Diff:
src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java ---
@@ -152,22 +197,18 @@ private boolean hasVaryHeader(URLConnecti
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/298#discussion_r123043201
--- Diff:
src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java ---
@@ -127,19 +163,28 @@ public Date getExpires() {
* @p
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/298#discussion_r122906273
--- Diff:
src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java ---
@@ -127,19 +163,28 @@ public Date getExpires() {
* @param re
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/298#discussion_r122906537
--- Diff:
src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java ---
@@ -180,65 +221,97 @@ private void setCache(String lastModified, Strin
Github user undera commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/298#discussion_r122796806
--- Diff:
src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPJavaImpl.java ---
@@ -626,6 +627,19 @@ protected HTTPSampleResult sample(URL url, Stri
Github user undera commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/298#discussion_r122796161
--- Diff:
src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java ---
@@ -152,22 +197,18 @@ private boolean hasVaryHeader(URLConnection co
GitHub user FSchumacher opened a pull request:
https://github.com/apache/jmeter/pull/298
Vary header cache
First try on an implementation to support vary header as asked for in
https://bz.apache.org/bugzilla/show_bug.cgi?id=61176
Do not merge.
I haven't written
