[CANCELLED] [VOTE] Release JMeter 5.2.1 RC4

Hello, Vote for 5.2.1 RC4: Cancelled. We need to fix this issues (jks file into the binary archive) and if it's possible, add the cleaning of the distributions directory before put the generated archives (see my mail on dev@ list) Milamber On 19/11/2019 21:41, Philippe Mouawad wrote: There

Re: [VOTE] Release JMeter 5.2.1 RC4

There is a jks file, so by default remote testing would work with it without requiring user to create his own. As such it can be considered as a CVE. So I am afraid a new RC is required . Regards On Tue, Nov 19, 2019 at 9:36 PM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > I guess i

Re: [VOTE] Release JMeter 5.2.1 RC4

On Tue, 19 Nov 2019 at 20:32, Philippe Mouawad wrote: > So I guess we need to do a new RC. > > Does it actually affect user testing? > On Tue, Nov 19, 2019 at 2:25 PM Vladimir Sitnikov < > sitnikov.vladi...@gmail.com> wrote: > > > >it could be moved to a test resources directory instead > > > >

Re: [VOTE] Release JMeter 5.2.1 RC4

I guess it is up to RM, but I do not think those are significant issues. It takes too much time to vote/announce, so redoing RC for minor issues seems to be a waste of time. Vladimis

Re: [VOTE] Release JMeter 5.2.1 RC4

So I guess we need to do a new RC. On Tue, Nov 19, 2019 at 2:25 PM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > >it could be moved to a test resources directory instead > > I agree. We should refrain from mixing production code with testing code in > the same folder. > > Vladimir >

Re: [VOTE] Release JMeter 5.2.1 RC4

>it could be moved to a test resources directory instead I agree. We should refrain from mixing production code with testing code in the same folder. Vladimir

Re: [VOTE] Release JMeter 5.2.1 RC4

On Tue, 19 Nov 2019 at 12:55, Vladimir Sitnikov wrote: > >It's also in the source release and in the Git repo, so I assume it is > >supposed to be there. > > That depends. It might be in the source repo for testing purposes only. > That's what the original commit suggests. > So I would suggest

Re: [VOTE] Release JMeter 5.2.1 RC4

>It's also in the source release and in the Git repo, so I assume it is >supposed to be there. That depends. It might be in the source repo for testing purposes only. So I would suggest we keep it in the source distribution (otherwise source build would fail), and we exclude the file from the bina

Re: [VOTE] Release JMeter 5.2.1 RC4

On Tue, 19 Nov 2019 at 09:38, Felix Schumacher < felix.schumac...@internetallee.de> wrote: > Hi all, > > is it OK to include bin/rmi_keystore.jks in the binary release? I > thought the idea was, that everyone had to generate those keys themselves. > > It's also in the source release and in the Git

Re: [VOTE] Release JMeter 5.2.1 RC4

Hi all, is it OK to include bin/rmi_keystore.jks in the binary release? I thought the idea was, that everyone had to generate those keys themselves. Felix Am 16.11.19 um 22:09 schrieb Milamber: > The fourth release candidate for JMeter 5.2.1 (c5a7888289) has been > prepared, and your votes are s

Re: [VOTE] Release JMeter 5.2.1 RC4

Hello, Thanks to RM. +1 I support this release (binding) Regards Philippe On Monday, November 18, 2019, Milamber wrote: > Hello Valdimir, > > My SVN version is 1.10.4-1+deb10u1 (from Debian 10) > > Milamber > > On 18/11/2019 18:13, Vladimir Sitnikov wrote: > >> Just a side note: the release s

Re: [VOTE] Release JMeter 5.2.1 RC4

Hello Valdimir, My SVN version is 1.10.4-1+deb10u1 (from Debian 10) Milamber On 18/11/2019 18:13, Vladimir Sitnikov wrote: Just a side note: the release step (gw publishDist) is known to fail if SVN 1.9 is used (see https://issues.apache.org/jira/browse/SVN-4666 , https://github.com/vlsi/asfli

Re: [VOTE] Release JMeter 5.2.1 RC4

Just a side note: the release step (gw publishDist) is known to fail if SVN 1.9 is used (see https://issues.apache.org/jira/browse/SVN-4666 , https://github.com/vlsi/asflike-release-environment/issues/1) I guess Milamber is using a newer version (since the previous release succeeded), however, I wo

Re: [VOTE] Release JMeter 5.2.1 RC4

>The fourth release candidate for JMeter 5.2.1 Thank you +1: I verified checksums, signatures, build, tests, pom files JMeter from binary distribution starts. --- script VER=5.2.1 RC=4 svn checkout https://dist.apache.org/repos/dist/dev/jmeter/apache-jmeter-$VER-rc$RC cd apache-jmeter-$VER-rc4

Re: [VOTE] Release JMeter 5.2.1 RC4

Yes, that looks ok to me. On Sunday, November 17, 2019, Jmeter Tea wrote: > You can put irrelevant values as "user=irrelevant" and it will work > ignoring it. > > בתאריך יום א׳, 17 בנוב׳ 2019, 16:03, מאת Philippe Mouawad ‏< > pmoua...@apache.org>: > > > Hello, > > Can you give more details ? > >

Re: [VOTE] Release JMeter 5.2.1 RC4

You can put irrelevant values as "user=irrelevant" and it will work ignoring it. בתאריך יום א׳, 17 בנוב׳ 2019, 16:03, מאת Philippe Mouawad ‏< pmoua...@apache.org>: > Hello, > Can you give more details ? > > Thanks > > On Sunday, November 17, 2019, Jmeter Tea wrote: > > > Hello > > > > About chan

Re: [VOTE] Release JMeter 5.2.1 RC4

Hello, Can you give more details ? Thanks On Sunday, November 17, 2019, Jmeter Tea wrote: > Hello > > About change Bug 63926 > - JDBC Connection > Configuration: Add ability to set connection properties > I tried to give wrong configuration

Re: [VOTE] Release JMeter 5.2.1 RC4

Hello About change Bug 63926 - JDBC Connection Configuration: Add ability to set connection properties I tried to give wrong configuration and it seems to be ignored, was it checked? On Sat, Nov 16, 2019 at 11:09 PM Milamber wrote: > The f

[VOTE] Release JMeter 5.2.1 RC4

The fourth release candidate for JMeter 5.2.1 (c5a7888289) has been prepared, and your votes are solicited. This release is mainly a bug fixes for v5.2. Please, test this release candidate (with load tests and/or functional tests) using Java 8+ on Linux/Windows/macOS, especially on the changes.