Re: Version 5.2 (Broken poms)

2019-11-09 Thread Vladimir Sitnikov
Vladimir>The current error Just to clarify: I believe https://github.com/apache/jmeter/commit/ef06709a780bc776ecc3b5d839c424d39bb1aeae fixes the poms, and the current jmeter/master is ok. Vladimir

Re: Version 5.2 (Broken poms)

2019-11-09 Thread Vladimir Sitnikov
Mark>Secondly we don’t use any local files, we pull binaries directly down from maven central using aether Mark>currently the plugin wouldn’t use them anyway Here you go: https://github.com/jmeter-maven-plugin/jmeter-maven-plugin/pull/345 The current error is "An error occurred:

Re: Version 5.2 (Broken poms)

2019-11-09 Thread Mark Collin
Hi Vladimir, I do take exception to the assertion that this is our fault. As noted in that ticket you raised, the build system should have no effect on us. It doesn’t matter if you build with Ant, Maven, or Gradle as long as you upload valid binaries and a correct POM to maven central.

Re: Version 5.2 (Broken poms)

2019-11-09 Thread Philippe Mouawad
As you know it’s oss, and we have to chose to which project we dedicate time. So maybe they had no slot at that time, they includes me :) And anyway the impact is not only for this project it’s for anybody using maven with jmeter 5.2 Regards On Saturday, November 9, 2019, Vladimir Sitnikov <

Re: Version 5.2 (Broken poms)

2019-11-09 Thread Vladimir Sitnikov
I reached out to jmeter-maven-plugin 3 month ago, and they did not seem to care: https://github.com/jmeter-maven-plugin/jmeter-maven-plugin/issues/339 Vladimir

Re: Version 5.2 (Broken poms)

2019-11-09 Thread Philippe Mouawad
Hello, Point 1/ is correct Point 2/ is not. The approach is now to remove inheritance and favor explicit dependency. a) But is it correct to declare dependencies of modules with scope runtime ? b) It was not the case previously, they has compile scope. Thanks On Sat, Nov 9, 2019 at 11:35 AM

Version 5.2 (Broken poms)

2019-11-09 Thread Philippe Mouawad
Hello, We have an issue with generated poms: 1/ Unspecified version in ApacheJMeter_core for jorphan: https://repo1.maven.org/maven2/org/apache/jmeter/ApacheJMeter_core/5.2/ApacheJMeter_core-5.2.pom We have this: org.apache.jmeterjorphanunspecified 2/ The other poms are wrong. Previously all