jeanouii opened a new pull request, #98:
URL: https://github.com/apache/johnzon/pull/98
Signed-off-by: Jean-Louis Monteiro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jeanouii merged PR #97:
URL: https://github.com/apache/johnzon/pull/97
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@johnzon.apache.or
rmannibucau commented on PR #89:
URL: https://github.com/apache/johnzon/pull/89#issuecomment-1378657470
@jeanouii AFAIK we did the work in the merged PR so think we can close
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jeanouii commented on PR #89:
URL: https://github.com/apache/johnzon/pull/89#issuecomment-1378636777
Does ok mean already merged in another PR so we can close without merge?
Or does it mean, it's ready to be merged
--
This is an automated message from the Apache Git Service.
To respond
jeanouii closed pull request #90: Catalog of deserialization error messages as
they are now
URL: https://github.com/apache/johnzon/pull/90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
jeanouii commented on PR #90:
URL: https://github.com/apache/johnzon/pull/90#issuecomment-1378636061
As requested closing because #91 has been merged already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
jeanouii opened a new pull request, #97:
URL: https://github.com/apache/johnzon/pull/97
Signed-off-by: Jean-Louis Monteiro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
rmannibucau commented on PR #89:
URL: https://github.com/apache/johnzon/pull/89#issuecomment-1358148847
guess this one is ok now? should we close?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rmannibucau commented on PR #77:
URL: https://github.com/apache/johnzon/pull/77#issuecomment-1323818292
Hi @radu-almasan ,
I took time to check this case and as suspected it is still a bug but here
what I meant for the fix (`validable` is the one to handle, root is just a
particular
radu-almasan commented on PR #77:
URL: https://github.com/apache/johnzon/pull/77#issuecomment-1322561709
Regarding the 2nd half of your statement, the existing tests passed
successfully and the one I added was probably specific to this case.
It's been too long since I coded this and d
rmannibucau commented on PR #77:
URL: https://github.com/apache/johnzon/pull/77#issuecomment-1322475009
@radu-almasan normally no, `validable` is really the value to validate
extractor result, if you pass root you break all the cases not using root so
part of the validations.
--
This is
radu-almasan commented on PR #77:
URL: https://github.com/apache/johnzon/pull/77#issuecomment-1322420615
From what I remember the `root` is always passed. We just need to use the
`valueProvider` if available to get the actual validable value from the `root`.
--
This is an automated messag
rmannibucau merged PR #96:
URL: https://github.com/apache/johnzon/pull/96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@johnzon.apache
SingingBush commented on PR #96:
URL: https://github.com/apache/johnzon/pull/96#issuecomment-1313959040
I think I've resolved all issues. requested re-review to to force pushing
squashed commits. I also updated original comment to better reflect the current
changes in the PR.
--
This is
rmannibucau commented on code in PR #96:
URL: https://github.com/apache/johnzon/pull/96#discussion_r1021680080
##
pom.xml:
##
@@ -164,16 +177,50 @@
+
+ org.apache.maven.plugins
+ maven-checkstyle-plugin
+ ${c
SingingBush commented on code in PR #96:
URL: https://github.com/apache/johnzon/pull/96#discussion_r1021670047
##
pom.xml:
##
@@ -164,16 +177,50 @@
+
+ org.apache.maven.plugins
+ maven-checkstyle-plugin
+ ${c
rmannibucau commented on code in PR #96:
URL: https://github.com/apache/johnzon/pull/96#discussion_r1021667525
##
pom.xml:
##
@@ -387,8 +433,7 @@
false
false
false
- none
- 8
Review Comment:
right but sam
SingingBush commented on code in PR #96:
URL: https://github.com/apache/johnzon/pull/96#discussion_r1021664833
##
pom.xml:
##
@@ -103,7 +116,7 @@
org.apache.maven.plugins
maven-shade-plugin
- 3.2.3
+
Review Comment:
fixed in
SingingBush commented on code in PR #96:
URL: https://github.com/apache/johnzon/pull/96#discussion_r1021662696
##
.github/workflows/maven.yml:
##
@@ -22,10 +22,7 @@ jobs:
distribution: ${{ matrix.dist }}
cache: 'maven'
- - name: Maven Package
+
SingingBush commented on code in PR #96:
URL: https://github.com/apache/johnzon/pull/96#discussion_r1021659592
##
pom.xml:
##
@@ -387,8 +433,7 @@
false
false
false
- none
- 8
Review Comment:
Javadoc plugi
rmannibucau commented on code in PR #96:
URL: https://github.com/apache/johnzon/pull/96#discussion_r1021642715
##
pom.xml:
##
@@ -164,16 +177,50 @@
+
+ org.apache.maven.plugins
+ maven-checkstyle-plugin
+ ${c
SingingBush commented on code in PR #96:
URL: https://github.com/apache/johnzon/pull/96#discussion_r1021638210
##
pom.xml:
##
@@ -164,16 +177,50 @@
+
+ org.apache.maven.plugins
+ maven-checkstyle-plugin
+ ${c
SingingBush commented on code in PR #96:
URL: https://github.com/apache/johnzon/pull/96#discussion_r1021630047
##
johnzon-osgi/pom.xml:
##
@@ -29,6 +29,10 @@
Johnzon :: Support for OSGI Jaxrs Whiteboard
bundle
+
+true
Review Comment:
yes the osgi properties wer
SingingBush commented on code in PR #96:
URL: https://github.com/apache/johnzon/pull/96#discussion_r1021627910
##
.github/workflows/maven.yml:
##
@@ -22,10 +22,7 @@ jobs:
distribution: ${{ matrix.dist }}
cache: 'maven'
- - name: Maven Package
+
rmannibucau commented on code in PR #96:
URL: https://github.com/apache/johnzon/pull/96#discussion_r1021625991
##
johnzon-jsonb/src/test/java/org/apache/johnzon/jsonb/JsonbRecordTest.java:
##
@@ -34,19 +34,19 @@ public class JsonbRecordTest {
@Test
public void roundT
SingingBush commented on code in PR #96:
URL: https://github.com/apache/johnzon/pull/96#discussion_r1021618768
##
johnzon-jsonb/src/test/java/org/apache/johnzon/jsonb/JsonbRecordTest.java:
##
@@ -34,19 +34,19 @@ public class JsonbRecordTest {
@Test
public void roundT
rmannibucau commented on code in PR #96:
URL: https://github.com/apache/johnzon/pull/96#discussion_r1021605409
##
pom.xml:
##
@@ -164,16 +177,50 @@
+
+ org.apache.maven.plugins
+ maven-checkstyle-plugin
+ ${c
rmannibucau commented on code in PR #96:
URL: https://github.com/apache/johnzon/pull/96#discussion_r1021602898
##
.github/workflows/maven.yml:
##
@@ -22,10 +22,7 @@ jobs:
distribution: ${{ matrix.dist }}
cache: 'maven'
- - name: Maven Package
+
SingingBush opened a new pull request, #96:
URL: https://github.com/apache/johnzon/pull/96
building on the work done by @hboutemy in PR #93, and the javadoc fixes in
PR #95, these changes fix some outstanding errors with Javadoc and aim to
improve the build by making sure that maven plugins
jbonofre commented on PR #82:
URL: https://github.com/apache/johnzon/pull/82#issuecomment-1313472574
Yes I think so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
rmannibucau closed pull request #49: JOHNZON-279 Fails to build on Travis CI
(Xenial)
URL: https://github.com/apache/johnzon/pull/49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
rmannibucau commented on PR #49:
URL: https://github.com/apache/johnzon/pull/49#issuecomment-1313442563
no more travis build so guess we can close
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rmannibucau commented on PR #12:
URL: https://github.com/apache/johnzon/pull/12#issuecomment-1313442119
guess it is fixed by osgi module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
rmannibucau commented on PR #63:
URL: https://github.com/apache/johnzon/pull/63#issuecomment-1313441458
up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
rmannibucau closed pull request #64: enable Dependabot v2
URL: https://github.com/apache/johnzon/pull/64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rmannibucau commented on PR #64:
URL: https://github.com/apache/johnzon/pull/64#issuecomment-1313441035
seems like it does not attract anyone so will close since no action is
really plan on this one until it changes later
--
This is an automated message from the Apache Git Service.
To res
rmannibucau commented on PR #75:
URL: https://github.com/apache/johnzon/pull/75#issuecomment-1313439994
done i guess?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
rmannibucau commented on PR #77:
URL: https://github.com/apache/johnzon/pull/77#issuecomment-1313439470
up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
rmannibucau commented on PR #82:
URL: https://github.com/apache/johnzon/pull/82#issuecomment-1313438855
guess this one is done now we have an osgi module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
rmannibucau commented on PR #95:
URL: https://github.com/apache/johnzon/pull/95#issuecomment-1313438009
Thanks @SingingBush !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
rmannibucau merged PR #95:
URL: https://github.com/apache/johnzon/pull/95
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@johnzon.apache
SingingBush opened a new pull request, #95:
URL: https://github.com/apache/johnzon/pull/95
small PR here for fixing some Javadoc linting problems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
rmannibucau commented on PR #93:
URL: https://github.com/apache/johnzon/pull/93#issuecomment-1312769082
Integrated, seems output does not have the pitfall I was thinking about
cause project never set it up, thanks for the ready to use PR :+1:
--
This is an automated message from the Apac
rmannibucau merged PR #93:
URL: https://github.com/apache/johnzon/pull/93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@johnzon.apache
rmannibucau commented on PR #93:
URL: https://github.com/apache/johnzon/pull/93#issuecomment-1312715118
It is more about having the real build timestamp in the jar than a
meaningless value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
hboutemy commented on PR #93:
URL: https://github.com/apache/johnzon/pull/93#issuecomment-1312710333
oh, you want a more complex setup: is there a concrete problem you're trying
to solve?
if you really want to disable reproducible builds for SNAPSHOTs (for a
reason I'd love to unders
rmannibucau commented on PR #93:
URL: https://github.com/apache/johnzon/pull/93#issuecomment-1312491562
Maybe to only set a build timestamp in release profile - maybe based on the
version, didnt think of that last part.
--
This is an automated message from the Apache Git Service.
To resp
hboutemy commented on PR #93:
URL: https://github.com/apache/johnzon/pull/93#issuecomment-1312451143
> I can handle the fact to keep a dynamic timestamp for snapshot after the
merge
what does that mean?
--
This is an automated message from the Apache Git Service.
To respond to the
rmannibucau commented on PR #93:
URL: https://github.com/apache/johnzon/pull/93#issuecomment-1312421688
Ok for me, i cna handle the fact to keep a dynamic timestamp for snapshot
after the merge so let's go
--
This is an automated message from the Apache Git Service.
To respond to the mess
hboutemy commented on PR #93:
URL: https://github.com/apache/johnzon/pull/93#issuecomment-1311554193
@SingingBush rebase done
@rmannibucau ok to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
SingingBush commented on PR #93:
URL: https://github.com/apache/johnzon/pull/93#issuecomment-1278604781
@hboutemy could you rebase this on top of the recent changes in master along
with also putting `1.8` into the
properties of the main pom because the apache super pom set's it to 1.7
rmannibucau merged PR #94:
URL: https://github.com/apache/johnzon/pull/94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@johnzon.apache
rmannibucau commented on code in PR #94:
URL: https://github.com/apache/johnzon/pull/94#discussion_r994885019
##
.github/dependabot.yml:
##
@@ -0,0 +1,7 @@
+version: 2
Review Comment:
I'm really for not using depandabot which got proven to create more noise
than solving any
SingingBush opened a new pull request, #94:
URL: https://github.com/apache/johnzon/pull/94
similar to #75 but with a few differences and dependency tweaks. I've pulled
out cobertura for now as it's dead. JaCoCo should be setup in it's place. I'm
keen to open a few more PR's but having a vis
rmannibucau merged PR #92:
URL: https://github.com/apache/johnzon/pull/92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@johnzon.apache
bmarwell opened a new pull request, #92:
URL: https://github.com/apache/johnzon/pull/92
Fixes [JOHNZON-386](https://issues.apache.org/jira/browse/JOHNZON-386)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
rmannibucau commented on PR #91:
URL: https://github.com/apache/johnzon/pull/91#issuecomment-1127292848
@dblevins FYI here is a test showing the comment I made in the PR to explain
why current exception handling is not yet release friendly/ready (and why I
spoke of mutable exception as an o
rmannibucau merged PR #91:
URL: https://github.com/apache/johnzon/pull/91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@johnzon.apache
dblevins commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r873230118
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -373,11 +377,20 @@ private Object buildObject(final Type inType, final
JsonObject o
dblevins commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r873212628
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +412,43 @@ private Object buildObject(final Type inType, final
JsonObject o
rmannibucau commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r873210774
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +412,43 @@ private Object buildObject(final Type inType, final
JsonObjec
dblevins commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r873209624
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +412,43 @@ private Object buildObject(final Type inType, final
JsonObject o
rmannibucau commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r873207822
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +412,43 @@ private Object buildObject(final Type inType, final
JsonObjec
rmannibucau commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r873207680
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -373,11 +377,20 @@ private Object buildObject(final Type inType, final
JsonObjec
dblevins commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r873205579
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +412,43 @@ private Object buildObject(final Type inType, final
JsonObject o
dblevins commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r873201691
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -373,11 +377,20 @@ private Object buildObject(final Type inType, final
JsonObject o
rmannibucau commented on PR #91:
URL: https://github.com/apache/johnzon/pull/91#issuecomment-1126977526
@dblevins any hope you review the question about catch(MapperException) (2
locations)? Except that where we potentially can avoid a double MapperException
(e+cause) it is ready to merge f
rmannibucau commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r873195622
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +412,43 @@ private Object buildObject(final Type inType, final
JsonObjec
rmannibucau commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r873195595
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -373,11 +377,20 @@ private Object buildObject(final Type inType, final
JsonObjec
dblevins commented on PR #91:
URL: https://github.com/apache/johnzon/pull/91#issuecomment-1121370527
@rmannibucau we should consider merging this PR and working on any further
exception handling fixes in separate PRs. My concern is this PR is getting a
bit too large for people to digest.
rmannibucau commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r866255768
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +403,43 @@ private Object buildObject(final Type inType, final
JsonObjec
dblevins commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r866237948
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +403,43 @@ private Object buildObject(final Type inType, final
JsonObject o
rmannibucau commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r866227299
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +403,43 @@ private Object buildObject(final Type inType, final
JsonObjec
dblevins commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r866173683
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +403,43 @@ private Object buildObject(final Type inType, final
JsonObject o
rmannibucau commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r866165266
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +403,43 @@ private Object buildObject(final Type inType, final
JsonObjec
dblevins commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r866161480
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +403,43 @@ private Object buildObject(final Type inType, final
JsonObject o
dblevins commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r866161480
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +403,43 @@ private Object buildObject(final Type inType, final
JsonObject o
dblevins commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r866161480
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +403,43 @@ private Object buildObject(final Type inType, final
JsonObject o
rmannibucau commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r866077545
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +403,43 @@ private Object buildObject(final Type inType, final
JsonObjec
dblevins commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r866063602
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +403,43 @@ private Object buildObject(final Type inType, final
JsonObject o
dblevins commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r866057577
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +403,43 @@ private Object buildObject(final Type inType, final
JsonObject o
rmannibucau commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r865574510
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +403,43 @@ private Object buildObject(final Type inType, final
JsonObjec
dblevins commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r865355702
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +403,43 @@ private Object buildObject(final Type inType, final
JsonObject o
dblevins commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r865355702
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +403,43 @@ private Object buildObject(final Type inType, final
JsonObject o
dblevins commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r865355702
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +403,43 @@ private Object buildObject(final Type inType, final
JsonObject o
rmannibucau commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r864511109
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +403,43 @@ private Object buildObject(final Type inType, final
JsonObjec
dblevins commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r864413944
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +403,43 @@ private Object buildObject(final Type inType, final
JsonObject o
dblevins commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r864274184
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +403,43 @@ private Object buildObject(final Type inType, final
JsonObject o
rmannibucau commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r864096288
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/ExceptionMessages.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
rmannibucau commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r864095505
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +403,43 @@ private Object buildObject(final Type inType, final
JsonObjec
dblevins commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r864016735
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/ExceptionMessages.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
dblevins commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r864010786
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/ExceptionMessages.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
dblevins commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r864000401
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +403,43 @@ private Object buildObject(final Type inType, final
JsonObject o
dblevins commented on PR #90:
URL: https://github.com/apache/johnzon/pull/90#issuecomment-1116334779
This should be closed and not merged when #91 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
rmannibucau commented on code in PR #91:
URL: https://github.com/apache/johnzon/pull/91#discussion_r863514532
##
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MappingParserImpl.java:
##
@@ -399,36 +403,43 @@ private Object buildObject(final Type inType, final
JsonObjec
dblevins opened a new pull request, #91:
URL: https://github.com/apache/johnzon/pull/91
Addresses:
- [JOHNZON-370](https://issues.apache.org/jira/browse/JOHNZON-370) Include
class, property, type and json value in mapping exceptions
- [JOHNZON-371](https://issues.apache.org/jira/
dblevins opened a new pull request, #90:
URL: https://github.com/apache/johnzon/pull/90
Submitting this as its own PR with the idea that actual changes to exception
messages can happen in other PRs over time. We'll be able to see in those PRs
a diff of what the message was and what it will
rmannibucau commented on PR #89:
URL: https://github.com/apache/johnzon/pull/89#issuecomment-949924
@dblevins idea was to use the full string representation without johnzon
(check the SnippetFactory used). It is ok to be in degraded mode for this case
with other implementations. Ultimat
dblevins opened a new pull request, #89:
URL: https://github.com/apache/johnzon/pull/89
If our intent is to optimize for small snippets and support JSONP
implementations aside from Johnzon, we still need to fall back to doing the
`flush()`.
The only reason we were able to get rid of
asfgit merged PR #88:
URL: https://github.com/apache/johnzon/pull/88
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@johnzon.apache.org
1 - 100 of 570 matches
Mail list logo
