Re: [GitHub] incubator-joshua pull request: More work on structuring translatio...

2016-04-28 Thread kellen sunderland
Hey Matt. I'd suggest we hook up the unit test runs in Vancouver (only a week away). They should be runnable with junit. On Apr 28, 2016 9:55 PM, "mjpost" wrote: > Github user mjpost commented on the pull request: > > >

Build failed in Jenkins: joshua_master #30

2016-04-28 Thread Apache Jenkins Server
See Changes: [kellens] Reworked most of the hypergraph traversals for Viterbi and n-best [kellens] LanguageModelFF.estimateFutureCost refactorings and test [kellens] Updated license files for tests [kellens] Modified KenLM jni to

[GitHub] incubator-joshua pull request: More work on structuring translatio...

2016-04-28 Thread mjpost
Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/9#issuecomment-215626822 Okay, this is merged. This is nice work. A few notes: - Can you tell me how to run the unit tests? @KellenSunderland @fhieber - The phrase-based

[GitHub] incubator-joshua pull request: More work on structuring translatio...

2016-04-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-joshua/pull/9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (JOSHUA-257) Add license headers to all Python scripts

2016-04-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/JOSHUA-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263305#comment-15263305 ] Hudson commented on JOSHUA-257: --- FAILURE: Integrated in joshua_master #29 (See

Build failed in Jenkins: joshua_master #29

2016-04-28 Thread Apache Jenkins Server
See Changes: [lewis.j.mcgibbney] JOSHUA-257 Add license headers to all Python scripts -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on

[GitHub] incubator-joshua pull request: More work on structuring translatio...

2016-04-28 Thread mjpost
Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/9#issuecomment-215596770 Can you describe how to run the unit tests? Are you folks using Eclipse? --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (JOSHUA-258) Add back penn-treebank-(de)tokenizer perl scripts

2016-04-28 Thread Lewis John McGibbney (JIRA)
[ https://issues.apache.org/jira/browse/JOSHUA-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263260#comment-15263260 ] Lewis John McGibbney commented on JOSHUA-258: - Cool > Add back penn-treebank-(de)tokenizer

[jira] [Commented] (JOSHUA-257) Add license headers to all Python scripts

2016-04-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JOSHUA-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263259#comment-15263259 ] ASF GitHub Bot commented on JOSHUA-257: --- Github user asfgit closed the pull request at:

[GitHub] incubator-joshua pull request: JOSHUA-257 Add license headers to a...

2016-04-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-joshua/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (JOSHUA-258) Add back penn-treebank-(de)tokenizer perl scripts

2016-04-28 Thread Matt Post (JIRA)
[ https://issues.apache.org/jira/browse/JOSHUA-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263258#comment-15263258 ] Matt Post commented on JOSHUA-258: -- Yes, it's been too-long neglected! I've been thinking this might be

[GitHub] incubator-joshua pull request: JOSHUA-258 Add back penn-treebank-(...

2016-04-28 Thread mjpost
Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/8#issuecomment-215592405 As noted there, this was moved to $JOSHUA/scripts/preparation/tokenize.pl (detokenize.pl), for the 6.1 release (part of an attempt to impose some organization on

[jira] [Commented] (JOSHUA-258) Add back penn-treebank-(de)tokenizer perl scripts

2016-04-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JOSHUA-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263253#comment-15263253 ] ASF GitHub Bot commented on JOSHUA-258: --- Github user mjpost commented on the pull request:

[GitHub] incubator-joshua pull request: More work on structuring translatio...

2016-04-28 Thread KellenSunderland
GitHub user KellenSunderland opened a pull request: https://github.com/apache/incubator-joshua/pull/9 More work on structuring translation output These commits focus on two areas: - One is structured translation output, and this should be our last PR for this topic for the

[jira] [Commented] (JOSHUA-258) Add back penn-treebank-(de)tokenizer perl scripts

2016-04-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JOSHUA-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263079#comment-15263079 ] ASF GitHub Bot commented on JOSHUA-258: --- Github user lewismc commented on the pull request:

[GitHub] incubator-joshua pull request: JOSHUA-258 Add back penn-treebank-(...

2016-04-28 Thread lewismc
Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/8#issuecomment-215571337 I also noted this issue over on https://github.com/joshua-decoder/joshua_translation_engine/issues/15 --- If your project is set up for it, you can reply to

[jira] [Commented] (JOSHUA-258) Add back penn-treebank-(de)tokenizer perl scripts

2016-04-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JOSHUA-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263078#comment-15263078 ] ASF GitHub Bot commented on JOSHUA-258: --- GitHub user lewismc opened a pull request:

[GitHub] incubator-joshua pull request: JOSHUA-258 Add back penn-treebank-(...

2016-04-28 Thread lewismc
GitHub user lewismc opened a pull request: https://github.com/apache/incubator-joshua/pull/8 JOSHUA-258 Add back penn-treebank-(de)tokenizer perl scripts This issue addresses https://issues.apache.org/jira/browse/JOSHUA-258 You can merge this pull request into a Git repository by

[jira] [Created] (JOSHUA-258) Add back penn-treebank-(de)tokenizer perl scripts

2016-04-28 Thread Lewis John McGibbney (JIRA)
Lewis John McGibbney created JOSHUA-258: --- Summary: Add back penn-treebank-(de)tokenizer perl scripts Key: JOSHUA-258 URL: https://issues.apache.org/jira/browse/JOSHUA-258 Project: Joshua

[GitHub] incubator-joshua pull request: JOSHUA-257 Add license headers to a...

2016-04-28 Thread chrismattmann
Github user chrismattmann commented on the pull request: https://github.com/apache/incubator-joshua/pull/7#issuecomment-215553414 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (JOSHUA-257) Add license headers to all Python scripts

2016-04-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JOSHUA-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262913#comment-15262913 ] ASF GitHub Bot commented on JOSHUA-257: --- GitHub user lewismc opened a pull request:

[jira] [Created] (JOSHUA-257) Add license headers to all Python scripts

2016-04-28 Thread Lewis John McGibbney (JIRA)
Lewis John McGibbney created JOSHUA-257: --- Summary: Add license headers to all Python scripts Key: JOSHUA-257 URL: https://issues.apache.org/jira/browse/JOSHUA-257 Project: Joshua Issue