[GitHub] incubator-joshua issue #24: Maven multi-module project layout proposal

Github user logogin commented on the issue: https://github.com/apache/incubator-joshua/pull/24 When I change base to "7" it says no more new commits. I thing it can be closed as resolved. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-joshua issue #24: Maven multi-module project layout proposal

Github user mjpost commented on the issue: https://github.com/apache/incubator-joshua/pull/24 No big deal, but if you update this pull request to be against the "7" branch instead of master, it will be marked as resolved. --- If your project is set up for it, you can reply to this

[GitHub] incubator-joshua issue #24: Maven multi-module project layout proposal

Github user lewismc commented on the issue: https://github.com/apache/incubator-joshua/pull/24 Boom goes the dynamite On Aug 17, 2016 3:33 AM, "Matt Post" wrote: > Awesome, that merged really cleanly. There is now a pushed 7 branch that

[GitHub] incubator-joshua issue #24: Maven multi-module project layout proposal

Github user mjpost commented on the issue: https://github.com/apache/incubator-joshua/pull/24 Awesome, that merged really cleanly. There is now a pushed 7 branch that we can begin work on for release 7. [Travis-CI](https://travis-ci.org/apache/incubator-joshua/builds/152931806) is

[GitHub] incubator-joshua issue #24: Maven multi-module project layout proposal

Github user mjpost commented on the issue: https://github.com/apache/incubator-joshua/pull/24 Yeah, that was one of our main concerns, too. Which is why we want to get this into master as soon as possible. There are some nasty merges ahead of us, but the unit tests should help pull

[GitHub] incubator-joshua issue #24: Maven multi-module project layout proposal

Github user mjpost commented on the issue: https://github.com/apache/incubator-joshua/pull/24 We wanted to include this in 6.1, but felt that a responsible manager would say that it is non-critical and that we should instead base our future release on it. We rebuilt this

[GitHub] incubator-joshua issue #24: Maven multi-module project layout proposal

Github user lewismc commented on the issue: https://github.com/apache/incubator-joshua/pull/24 @mjpost so is the proposal to include this in 6.1? Or 7 only? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-joshua issue #24: Maven multi-module project layout proposal

Github user logogin commented on the issue: https://github.com/apache/incubator-joshua/pull/24 re-beased again; migrated test to TetsNG --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-joshua issue #24: Maven multi-module project layout proposal

Github user logogin commented on the issue: https://github.com/apache/incubator-joshua/pull/24 Hi @mjpost . I wanted general opinion on the proposal but looks mostly people support it. Some things to take into account if that will go into master: * joshua-servet contains only

[GitHub] incubator-joshua issue #24: Maven multi-module project layout proposal

Github user mjpost commented on the issue: https://github.com/apache/incubator-joshua/pull/24 Thanks, @logogin. I have only glanced at this, but it seems like a good idea. I hope to be able to take a look tonight, and expect all will be well. Do you want more discussion, or should I

[GitHub] incubator-joshua issue #24: Maven multi-module project layout proposal

Github user logogin commented on the issue: https://github.com/apache/incubator-joshua/pull/24 Re-based on top of master. I also split the change into two separate commits to simplify the review: the 1st one is just moving files, no changes; the 2nd contains actual modifications

[GitHub] incubator-joshua issue #24: Maven multi-module project layout proposal

Github user logogin commented on the issue: https://github.com/apache/incubator-joshua/pull/24 @mjpost The pattern is just a standard one. I was not aware of naming in deeplearning4j. @hsaputra Yes, that is correct. The code base tends to become monolith peace of software which

[GitHub] incubator-joshua issue #24: Maven multi-module project layout proposal

Github user hsaputra commented on the issue: https://github.com/apache/incubator-joshua/pull/24 Just to clarify, so the idea is to move components into separate modules that could be compile and included by parent module? --- If your project is set up for it, you can reply to this

[GitHub] incubator-joshua issue #24: Maven multi-module project layout proposal

Github user mjpost commented on the issue: https://github.com/apache/incubator-joshua/pull/24 This looks cool to me. Is this a recent pattern or something? I just noticed a similar approach on the [deeplearning4j](https://github.com/deeplearning4j/deeplearning4j) repo. --- If your

[GitHub] incubator-joshua issue #24: Maven multi-module project layout proposal

Github user lewismc commented on the issue: https://github.com/apache/incubator-joshua/pull/24 This is dynamite. I'll pull later and check it out. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not