[GitHub] incubator-joshua pull request: JOSHUA-264 System.exit() calls are ...

2016-05-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-joshua/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] incubator-joshua pull request: JOSHUA-264 System.exit() calls are ...

2016-05-21 Thread KellenSunderland
Github user KellenSunderland commented on the pull request: https://github.com/apache/incubator-joshua/pull/13#issuecomment-220772283 Hey Thamme, thanks for the great PR. Haven't checked the build yet myself but the commit looks good to me. --- If your project is set up for it, you

[GitHub] incubator-joshua pull request: JOSHUA-264 System.exit() calls are ...

2016-05-16 Thread lewismc
Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/13#issuecomment-219586971 Nice, I've been working on the eats for the last hour or so, so I'll update feature branch once this is done. @matt did you merge this PR into feature branc

[GitHub] incubator-joshua pull request: JOSHUA-264 System.exit() calls are ...

2016-05-16 Thread thammegowda
Github user thammegowda commented on the pull request: https://github.com/apache/incubator-joshua/pull/13#issuecomment-219571959 @mjpost Added `maven-assembly-plugin` to make the build cycle easy: https://github.com/apache/incubator-joshua/pull/14 --- If your project is set up for it

[GitHub] incubator-joshua pull request: JOSHUA-264 System.exit() calls are ...

2016-05-16 Thread thammegowda
Github user thammegowda commented on the pull request: https://github.com/apache/incubator-joshua/pull/13#issuecomment-219570096 My maven version $ mvn --version Apache Maven 3.0.5 Maven home: /usr/share/maven Java version: 1.8.0_91, vendor: Oracle Corporation J

[GitHub] incubator-joshua pull request: JOSHUA-264 System.exit() calls are ...

2016-05-16 Thread mjpost
Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/13#issuecomment-219568967 Can you describe the maven build process? What version do you use, and what command do you type? --- If your project is set up for it, you can reply to this ema

[GitHub] incubator-joshua pull request: JOSHUA-264 System.exit() calls are ...

2016-05-16 Thread thammegowda
Github user thammegowda commented on the pull request: https://github.com/apache/incubator-joshua/pull/13#issuecomment-219568358 This is based on Maven build. Since the files are moved to new location in maven build, I branched off from JOSHUA-252 to avoid merge conflicts later ti

[GitHub] incubator-joshua pull request: JOSHUA-264 System.exit() calls are ...

2016-05-16 Thread mjpost
Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/13#issuecomment-219567425 Oh, I see, you are building off JOSHUA-252. We will need to merge that in with master first. --- If your project is set up for it, you can reply to this email a

[GitHub] incubator-joshua pull request: JOSHUA-264 System.exit() calls are ...

2016-05-16 Thread mjpost
Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/13#issuecomment-219566852 I can't compile this — Are you using Ivy here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] incubator-joshua pull request: JOSHUA-264 System.exit() calls are ...

2016-05-16 Thread thammegowda
GitHub user thammegowda opened a pull request: https://github.com/apache/incubator-joshua/pull/13 JOSHUA-264 System.exit() calls are replaced by throw new RuntimeException() This PR replaces system exit calls with runtime exception + The error messages are preserved by passing th