[jira] [Commented] (JOSHUA-251) Address Website Branding Issues

[ https://issues.apache.org/jira/browse/JOSHUA-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261475#comment-15261475 ] Matt Post commented on JOSHUA-251: -- Related to this: after trying to use it a little, I think the current

[GitHub] incubator-joshua pull request: More work on structuring translatio...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/6#issuecomment-215286087 Okay, going to hold off until I hear from you... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] incubator-joshua pull request: More work on structuring translatio...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/6#issuecomment-215274644 Should I wait then to pull this in and fix the test cases? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Re: joshua_api

Sure thing, hope to tonight. matt > On Apr 27, 2016, at 6:41 PM, kellen sunderland > wrote: > > Hey Matt, > > If you had time that would be fantastic. I've created a new PR in case you > want to pull it in. There's actually 4 tests failing for me currently >

[GitHub] incubator-joshua pull request: More work on structuring translatio...

Github user KellenSunderland commented on the pull request: https://github.com/apache/incubator-joshua/pull/6#issuecomment-215274462 Closing this PR temporarily as we want to tweak some commit messages. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-joshua pull request: More work on structuring translatio...

Github user KellenSunderland closed the pull request at: https://github.com/apache/incubator-joshua/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Re: joshua_api

Hey Matt, If you had time that would be fantastic. I've created a new PR in case you want to pull it in. There's actually 4 tests failing for me currently (casing issues causing at least one). If you want to wait until we fix these tests that's also completely fine. -Kellen On Wed, Apr 27,

[GitHub] incubator-joshua pull request: More work on structuring translatio...

GitHub user KellenSunderland opened a pull request: https://github.com/apache/incubator-joshua/pull/6 More work on structuring translation output These commits focus on two areas: * One is structured translation output, and this should be our last PR for this topic for the

Re: [jira] [Commented] (JOSHUA-253) Enable execution of Unit tests

I am fine with you just doing this. The current setup was a something-is-better-than-nothing (which is true) hack, and I'd be happy to have better practices pushed into the project. matt (from my phone) > On Apr 27, 2016, at 2:39 PM, Kellen Sunderland (JIRA) wrote: > > >

Re: joshua_api

Do you want me to fix the recapitalization? Or are you going to do that? I looked a bit, and it seems I'll have to add a method to get a word alignment object instead of just the string, so that I can poke through them. This approach is as good as true-casing in some languages. A few other

Re: joshua_api

Thanks for taking a look Matt, I think this is all we've got planned as far as changes relating to an API would go. We have a few more commits coming but they're just performance improvements and they don't change too much in the way of interfaces or method signatures. -Kellen On Wed, Apr 27,

[jira] [Commented] (JOSHUA-256) Note that Joshua builds and runs with >= Java 1.8

[ https://issues.apache.org/jira/browse/JOSHUA-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260657#comment-15260657 ] Hudson commented on JOSHUA-256: --- SUCCESS: Integrated in joshua_master #27 (See

[jira] [Commented] (JOSHUA-256) Note that Joshua builds and runs with >= Java 1.8

[ https://issues.apache.org/jira/browse/JOSHUA-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260529#comment-15260529 ] ASF GitHub Bot commented on JOSHUA-256: --- Github user asfgit closed the pull request at:

[GitHub] incubator-joshua pull request: JOSHUA-256 Note that Joshua builds ...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-joshua/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (JOSHUA-253) Enable execution of Unit tests

[ https://issues.apache.org/jira/browse/JOSHUA-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260525#comment-15260525 ] Matt Post commented on JOSHUA-253: -- Yes, Tommaso is correct. test/ holds what I think are better termed

[GitHub] incubator-joshua pull request: JOSHUA-256 Note that Joshua builds ...

GitHub user lewismc opened a pull request: https://github.com/apache/incubator-joshua/pull/5 JOSHUA-256 Note that Joshua builds and runs with >= Java 1.8 This PR addresses https://issues.apache.org/jira/browse/JOSHUA-256 You can merge this pull request into a Git repository by

[jira] [Commented] (JOSHUA-253) Enable execution of Unit tests

[ https://issues.apache.org/jira/browse/JOSHUA-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260269#comment-15260269 ] Lewis John McGibbney commented on JOSHUA-253: - bq. so no Java unit test is executed as far as

[jira] [Commented] (JOSHUA-253) Enable execution of Unit tests

[ https://issues.apache.org/jira/browse/JOSHUA-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260253#comment-15260253 ] Tommaso Teofili commented on JOSHUA-253: as far as I can see the ant test target executes the

[jira] [Commented] (JOSHUA-253) Enable execution of Unit tests

[ https://issues.apache.org/jira/browse/JOSHUA-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260231#comment-15260231 ] Lewis John McGibbney commented on JOSHUA-253: - [~teofili] [~post] where are the Unit tests we

[GitHub] incubator-joshua pull request: Fixed files in wrong folder, append...

Github user KellenSunderland commented on the pull request: https://github.com/apache/incubator-joshua/pull/2#issuecomment-215097582 Thanks for the merge Matt. I'll take a look at the commit you mention and rebase the next PR on top of it. --- If your project is set up for it, you

[jira] [Commented] (JOSHUA-255) License headers for all bash scripts

[ https://issues.apache.org/jira/browse/JOSHUA-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260221#comment-15260221 ] ASF GitHub Bot commented on JOSHUA-255: --- GitHub user lewismc opened a pull request:

[GitHub] incubator-joshua pull request: JOSHUA-255 License headers for all ...

GitHub user lewismc opened a pull request: https://github.com/apache/incubator-joshua/pull/4 JOSHUA-255 License headers for all bash scripts This issue addresses https://issues.apache.org/jira/browse/JOSHUA-255 You can merge this pull request into a Git repository by running: