Re: Heads up if you're getting JVM Crashes

2016-09-15 Thread Kenneth Heafield
Darn. I guess GetLongArrayRegion is implemented reasonably efficiently, which is shocking for JNI. Kenneth On 09/15/16 23:13, Matt Post wrote: > Sadly, no performance improvements were to be found with avoiding the long[] > allocation (commit 9ea7eebf0164d1676f633b441bd952eaa20b0760), but

[GitHub] incubator-joshua pull request #65: This PR is a first attempt to minimize ng...

2016-09-15 Thread KellenSunderland
GitHub user KellenSunderland opened a pull request: https://github.com/apache/incubator-joshua/pull/65 This PR is a first attempt to minimize ngram array copies by utilizing DirectBuffers. This is a work in progress but posted so that Matt + Ken can review (and do some speed

[GitHub] incubator-joshua pull request #64: Fixed Rescoring test

2016-09-15 Thread fhieber
GitHub user fhieber opened a pull request: https://github.com/apache/incubator-joshua/pull/64 Fixed Rescoring test You can merge this pull request into a Git repository by running: $ git pull https://github.com/fhieber/incubator-joshua 7 Alternatively you can review and

[GitHub] incubator-joshua pull request #63: Fixed more tests in 7

2016-09-15 Thread fhieber
GitHub user fhieber opened a pull request: https://github.com/apache/incubator-joshua/pull/63 Fixed more tests in 7 You can merge this pull request into a Git repository by running: $ git pull https://github.com/fhieber/incubator-joshua 7_new Alternatively you can review and

[GitHub] incubator-joshua pull request #62: Fixed NumTranslationOptions test and adde...

2016-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-joshua/pull/62 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-joshua pull request #62: Fixed NumTranslationOptions test and adde...

2016-09-15 Thread fhieber
GitHub user fhieber opened a pull request: https://github.com/apache/incubator-joshua/pull/62 Fixed NumTranslationOptions test and added deterministic output order… … of feature vectors You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-joshua pull request #61: Fixed NAry, Constrained deocoding, and Le...

2016-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-joshua/pull/61 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-joshua pull request #61: Fixed NAry test for 7

2016-09-15 Thread fhieber
GitHub user fhieber opened a pull request: https://github.com/apache/incubator-joshua/pull/61 Fixed NAry test for 7 You can merge this pull request into a Git repository by running: $ git pull https://github.com/fhieber/incubator-joshua 7 Alternatively you can review and

[GitHub] incubator-joshua pull request #60: Moved several regression tests to unit te...

2016-09-15 Thread michael-aloys
GitHub user michael-aloys opened a pull request: https://github.com/apache/incubator-joshua/pull/60 Moved several regression tests to unit tests (3). You can merge this pull request into a Git repository by running: $ git pull https://github.com/michael-aloys/incubator-joshua

[GitHub] incubator-joshua pull request #59: Fixed NoGrammarTest for 7

2016-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-joshua/pull/59 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-joshua pull request #59: Fixed NoGrammarTest for 7

2016-09-15 Thread fhieber
GitHub user fhieber opened a pull request: https://github.com/apache/incubator-joshua/pull/59 Fixed NoGrammarTest for 7 You can merge this pull request into a Git repository by running: $ git pull https://github.com/fhieber/incubator-joshua 7 Alternatively you can review and

[GitHub] incubator-joshua pull request #55: Refactoring of ComputeNodeResult into a s...

2016-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-joshua/pull/55 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-joshua pull request #58: Moved new unit tests (former regression t...

2016-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-joshua/pull/58 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Heads up if you're getting JVM Crashes

2016-09-15 Thread Kenneth Heafield
It was a € and I won the bet because the speed improvement is larger than 5%. On 09/13/16 23:54, Matt Post wrote: > PS. (Kellen, be sure to collect your £ from Ken tomorrow)

[GitHub] incubator-joshua issue #58: Moved new unit tests (former regression tests) t...

2016-09-15 Thread mjpost
Github user mjpost commented on the issue: https://github.com/apache/incubator-joshua/pull/58 Ah, right. Note that the test works from the command line: cd $JOSHUA/joshua-core cat src/test/resources/bn-en/hiero/input.bn | $JOSHUA/bin/joshua-decoder -c

[GitHub] incubator-joshua issue #58: Moved new unit tests (former regression tests) t...

2016-09-15 Thread fhieber
Github user fhieber commented on the issue: https://github.com/apache/incubator-joshua/pull/58 Depends whether we had any end-to-end tests like this already in 7. For the existing unit tests I already made the necessary changes to pass in 7. Quote from my commit for the featureFector

[GitHub] incubator-joshua issue #58: Moved new unit tests (former regression tests) t...

2016-09-15 Thread mjpost
Github user mjpost commented on the issue: https://github.com/apache/incubator-joshua/pull/58 My guess is that grammar weights need reversing, but then I wonder why we haven't had to do that for other tests. I'll check this out later in the morning. --- If your project is set up