[GitHub] incubator-joshua issue #58: Moved new unit tests (former regression tests) t...

2016-09-15 Thread mjpost
Github user mjpost commented on the issue: https://github.com/apache/incubator-joshua/pull/58 Ah, right. Note that the test works from the command line: cd $JOSHUA/joshua-core cat src/test/resources/bn-en/hiero/input.bn | $JOSHUA/bin/joshua-decoder -c

[GitHub] incubator-joshua issue #58: Moved new unit tests (former regression tests) t...

2016-09-15 Thread fhieber
Github user fhieber commented on the issue: https://github.com/apache/incubator-joshua/pull/58 Depends whether we had any end-to-end tests like this already in 7. For the existing unit tests I already made the necessary changes to pass in 7. Quote from my commit for the featureFector

[GitHub] incubator-joshua issue #58: Moved new unit tests (former regression tests) t...

2016-09-15 Thread mjpost
Github user mjpost commented on the issue: https://github.com/apache/incubator-joshua/pull/58 My guess is that grammar weights need reversing, but then I wonder why we haven't had to do that for other tests. I'll check this out later in the morning. --- If your project is set up