JS & CSS compression may be overrated today anyway, in a world of
super-fast internet and YouTube videos, a few fat JS & CSS files may
take up the same amount of bandwidth as three seconds of a video, so it
may not be worth spending much time over. (FWIW, AFAIK Roller doesn't
do any compressi
Hi,
I don't have the time right now to dig into what you guys are proposing
with wro4j so I
can only add a cautionary tale to the table. I imagine that the vast
majority of JSPWiki
users (i.e., installers) will be modifying the PlainVanilla theme to create
a style that
matches their individual req
Hi All,
OK, converted. Main issue was that I had to move jspwiki.properties out
of the WEB-INF folder and into to src/main/resources/ini (where the
default_jspwiki.properties, now incorporated into jspwiki.properties,
used to be.) I believe it was because certain bootstrapping classes
don't
Hi,
I was thinking in existing users who might be using this feature, but just
realised that simlpy using -Djspwiki.custom.config for the same file would
be equally valid, so I'm +1 on your approach
br,
juan pablo
On Thu, Aug 8, 2013 at 2:43 PM, Glen Mazza wrote:
> Umm, I really would *not* w
Umm, I really would *not* want to go that route, there's no practical
benefit to providing both options (never has been on Roller for over a
decade now), it would raise unnecessary confusion among users, and it
would be cumbersome to code.
With my proposed change, you are never going to alter
Hi,
one quick note, if I recall correctly, "-Djspwiki.propertyfile" is used to
load the main jspwiki.properties from outside the war, so it should be able
to coexist with "-Djspwiki.custom.config", something like:
- jspwiki.properties, loaded first, from war (unless -Djspwiki.propertyfile
is give
Yes, I like -Djspwiki.custom.config too. I'll see what I can do for
logging.
Glen
On 08/08/2013 08:01 AM, Harry Metske wrote:
Changing the propname to something else would not be a problem,
"-Djspwiki.custom.config" is fine.
What I meant is that it should be very clear _how_ these things pl
Changing the propname to something else would not be a problem,
"-Djspwiki.custom.config" is fine.
What I meant is that it should be very clear _how_ these things play
together, both in documentation and logging.
kind regards,
Harry
On 8 August 2013 13:56, Glen Mazza wrote:
> Yes, [#1] would
Yes, [#1] would be the [3] I mentioned below. But would it be a problem
if I renamed our "-Djspwiki.propertyfile" setting to
"-Djspwiki.custom.propertyfile" (or "-Djspwiki.custom.config" similar to
Roller) as it's technically no longer a replacement of the
jspwiki.properties file (which will a
On 08/07/2013 06:10 AM, Dirk Frederickx wrote:
I recommend to only run JSLINT on the javascript written dedicated for
JSPWiki. JSLINT should not be run on the external libraries ( such as
mootools.js, prettify.js ) on which we are not having any impact anyway.
+1. The errors reported by jshin
On 08/07/2013 05:47 AM, Dirk Frederickx wrote:
One of the main advantages for using wro4j at RUNTIME, is that the wro4j
filter also GZIP's the JS and CSS files. This has an enormous impact on
the size of these files, and we should definitely consider to add this to
JSPWiki in the future.
( ei
Oops, OK, I'll revert it to 8.xxx then. I recently upgraded Roller from
Jetty 6 to Jetty 9 and no Jenkins problem, but forgot that Jetty isn't
used during the unit tests with Roller.
Glen
On 08/07/2013 10:19 AM, Harry Metske wrote:
http://www.eclipse.org/jetty/documentation/current/what-jett
12 matches
Mail list logo
