[ 
https://issues.apache.org/jira/browse/JSPWIKI-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jürgen Weber updated JSPWIKI-1035:
----------------------------------
    Attachment: WikiEngine.java.patch
                jspwiki.properties.patch
                DefaultURLConstructor.java.patch

Actually getting rid of baseURL can be done with ServletContext.getContextPath()
which is there since Servlet 2.5

With the patch getBaseURL() only returns /context, so no host + port in the 
generated html.

Please do some more testing!

> get rid of jspwiki.baseURL
> --------------------------
>
>                 Key: JSPWIKI-1035
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-1035
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Core & storage
>    Affects Versions: 2.10.2
>            Reporter: Jürgen Weber
>         Attachments: DefaultURLConstructor.java.patch, WikiEngine.java.patch, 
> jspwiki.properties.patch
>
>
> Could we get rid of  jspwiki.baseURL and calculate it on 
> HttpServletRequest#getContextPath() ?
> It's the only mandatory property you have to set for JSPWiki, so removing it 
> would make installation much easier.
> And, first and foremost, it makes JSPWiki only work on exactly this URL, i.e. 
> you cannot use the same JSPWiki instance in an intranet and on the internet 
> (e.g. wiki.firm.com and wiki.firm.private), neither with and without JK'ed 
> Apache, neither SSL and non-SSL.
> If you look at the source of https://jspwiki-wiki.apache.org/ 
> there are not many places where the whole base url is used. So, I wonder, if 
> context relative links could be sufficient.
> http://stackoverflow.com/questions/4764405/how-to-use-relative-paths-without-including-the-context-root-name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to