Re: [PR] Use try-with-resources. (jspwiki)

juanpablo-santos commented on PR #207: URL: https://github.com/apache/jspwiki/pull/207#issuecomment-1656893050 Hi! just've seen now a pending review here - there're still a bunch of `try (JspWriter out = pageContext.getOut()) {` that should be reverted? -- This is an automated message fro

Re: [PR] Serializable class without serialVersionUID (jspwiki)

juanpablo-santos commented on PR #292: URL: https://github.com/apache/jspwiki/pull/292#issuecomment-1656891408 merged in 2.12.1-git-02, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Serializable class without serialVersionUID (jspwiki)

juanpablo-santos merged PR #292: URL: https://github.com/apache/jspwiki/pull/292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jspwiki

Re: [PR] Constant charset String literal (for example, "UTF-8") can be replaced with the predefined StandardCharsets.UTF_8 code. (jspwiki)

juanpablo-santos commented on PR #290: URL: https://github.com/apache/jspwiki/pull/290#issuecomment-1656891269 merged in 2.12.1-git-02, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Use placeholders in the logger message. (jspwiki)

juanpablo-santos merged PR #291: URL: https://github.com/apache/jspwiki/pull/291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jspwiki

Re: [PR] Constant charset String literal (for example, "UTF-8") can be replaced with the predefined StandardCharsets.UTF_8 code. (jspwiki)

juanpablo-santos merged PR #290: URL: https://github.com/apache/jspwiki/pull/290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jspwiki

Re: [PR] Use placeholders in the logger message. (jspwiki)

juanpablo-santos commented on PR #291: URL: https://github.com/apache/jspwiki/pull/291#issuecomment-1656891355 merged in 2.12.1-git-02, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [JSPWIKI-1172] Set jspwiki.workDir default to servlet context temp directory (jspwiki)

juanpablo-santos commented on PR #282: URL: https://github.com/apache/jspwiki/pull/282#issuecomment-1656890604 merged in 2.12.1-git-02, would you mind resolving the associated jira issue? thx! -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] [JSPWIKI-1172] Set jspwiki.workDir default to servlet context temp directory (jspwiki)

juanpablo-santos merged PR #282: URL: https://github.com/apache/jspwiki/pull/282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jspwiki

[jira] [Commented] (JSPWIKI-1172) jspwiki.workDir default should be in $javax.servlet.context.tempdir

[ https://issues.apache.org/jira/browse/JSPWIKI-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17748857#comment-17748857 ] ASF subversion and git services commented on JSPWIKI-1172: -- Co

Re: [PR] java 11 improvements. (jspwiki)

juanpablo-santos commented on PR #272: URL: https://github.com/apache/jspwiki/pull/272#issuecomment-1656888291 merged in 2.12.1-git-02, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] java 11 improvements. (jspwiki)

juanpablo-santos merged PR #272: URL: https://github.com/apache/jspwiki/pull/272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jspwiki

Re: [PR] Bump flexmark.version from 0.64.6 to 0.64.8 (jspwiki)

juanpablo-santos closed pull request #286: Bump flexmark.version from 0.64.6 to 0.64.8 URL: https://github.com/apache/jspwiki/pull/286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump com.codeborne:selenide from 6.15.0 to 6.16.1 (jspwiki)

juanpablo-santos closed pull request #294: Bump com.codeborne:selenide from 6.15.0 to 6.16.1 URL: https://github.com/apache/jspwiki/pull/294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Bump hsqldb.version from 2.7.1 to 2.7.2 (jspwiki)

juanpablo-santos closed pull request #287: Bump hsqldb.version from 2.7.1 to 2.7.2 URL: https://github.com/apache/jspwiki/pull/287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Bump mockito.version from 5.3.1 to 5.4.0 (jspwiki)

juanpablo-santos closed pull request #288: Bump mockito.version from 5.3.1 to 5.4.0 URL: https://github.com/apache/jspwiki/pull/288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme